Attachment 188317 Details for Bug 109811 – Patch

[patch] Patch

bug-109811-20130214162237.patch (text/plain), 1.90 KB, created by Yury Semikhatsky on 2013-02-14 04:26:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yury Semikhatsky

Created: 2013-02-14 04:26:10 PST

Size: 1.90 KB

patch

obsolete

>Subversion Revision: 142863
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ec6fb3a47114c7ec5bd3a9bb7d25e99f688ce697..d8750b7f95d8bab08cb4f0555b9d1adcc3f40ef9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,5 +1,18 @@
> 2013-02-14  Yury Semikhatsky  <yurys@chromium.org>
> 
>+        Web Inspector: don't create static local string for program literal in InspectorTimelineAgent
>+        https://bugs.webkit.org/show_bug.cgi?id=109811
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use const char* constant value instead of creating String from it in thread-unsafe
>+        static local variable.
>+
>+        * inspector/InspectorTimelineAgent.cpp:
>+        (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
>+
>+2013-02-14  Yury Semikhatsky  <yurys@chromium.org>
>+
>         Web Inspector: extract DOM counters graph implementation into its own class
>         https://bugs.webkit.org/show_bug.cgi?id=109796
> 
>diff --git a/Source/WebCore/inspector/InspectorTimelineAgent.cpp b/Source/WebCore/inspector/InspectorTimelineAgent.cpp
>index 7cde8f976f8bfcadad1f6d1135b5a31125d48974..97e14697f3176815d099a62186034c74bc2ceba9 100644
>--- a/Source/WebCore/inspector/InspectorTimelineAgent.cpp
>+++ b/Source/WebCore/inspector/InspectorTimelineAgent.cpp
>@@ -499,13 +499,11 @@ void InspectorTimelineAgent::addRecordToTimeline(PassRefPtr<InspectorObject> rec
> 
> void InspectorTimelineAgent::innerAddRecordToTimeline(PassRefPtr<InspectorObject> prpRecord, const String& type, const String& frameId)
> {
>-    DEFINE_STATIC_LOCAL(String, program, (TimelineRecordType::Program));
>-
>     RefPtr<InspectorObject> record(prpRecord);
>     record->setString("type", type);
>     if (!frameId.isEmpty())
>         record->setString("frameId", frameId);
>-    if (type == program)
>+    if (type == TimelineRecordType::Program)
>         setNativeHeapStatistics(record.get());
>     else
>         setDOMCounters(record.get());

Actions: View | Formatted Diff | Diff

Attachments on bug 109811: 188317