Attachment 187983 Details for Bug 109645 – Patch

[patch] Patch

bug-109645-20130213112027.patch (text/plain), 3.39 KB, created by Dongseong Hwang on 2013-02-12 18:24:38 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Dongseong Hwang

Created: 2013-02-12 18:24:38 PST

Size: 3.39 KB

patch

obsolete

>Subversion Revision: 142692
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d0a0f15ea2e6a177d73258b5d5dd040453102106..9dfed854c0b6821d01bf4f69ad1e6cc0310735cc 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,29 @@
>+2013-02-12  Huang Dongsung  <luxtella@company100.net>
>+
>+        Coordinated Graphics: a long page is scaled vertically while loading.
>+        https://bugs.webkit.org/show_bug.cgi?id=109645
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When loading http://www.w3.org/TR/xpath-datamodel/, Coordinated Graphics draws
>+        vertically scaled contents. It is because there is the difference between the
>+        size of a layer and the size of CoordinatedBackingStore.
>+
>+        Currently, CoordinatedGraphicsScene notifies the size to CoordinatedBackingStore
>+        at the moment of creating, updating and removing a tile. However, it is not
>+        necessary to send tile-related messages when the size of layer is changed.
>+        So this patch resets the size of CoordinatedBackingStore when receiving the
>+        message that is created when the size is changed: SyncLayerState.
>+
>+        Unfortunately, I couldn't think of a way to test this in an automated
>+        fashion.
>+
>+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
>+        (WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
>+        (WebCore::CoordinatedGraphicsScene::createTile):
>+        (WebCore::CoordinatedGraphicsScene::removeTile):
>+        (WebCore::CoordinatedGraphicsScene::updateTile):
>+
> 2013-02-12  Simon Fraser  <simon.fraser@apple.com>
> 
>         Crash when scrolling soon after page starts loading
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp
>index 103ed1defeca40fdcac615f2975077e759c0ddb2..c0efccfa05018d6ab3107fcba0a55db722b5444a 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp
>@@ -393,6 +393,7 @@ void CoordinatedGraphicsScene::prepareContentBackingStore(GraphicsLayer* graphic
>     }
> 
>     createBackingStoreIfNeeded(graphicsLayer);
>+    resetBackingStoreSizeToLayerSize(graphicsLayer);
> }
> 
> void CoordinatedGraphicsScene::createBackingStoreIfNeeded(GraphicsLayer* graphicsLayer)
>@@ -428,7 +429,6 @@ void CoordinatedGraphicsScene::createTile(CoordinatedLayerID layerID, uint32_t t
>     RefPtr<CoordinatedBackingStore> backingStore = m_backingStores.get(layer);
>     ASSERT(backingStore);
>     backingStore->createTile(tileID, scale);
>-    resetBackingStoreSizeToLayerSize(layer);
> }
> 
> void CoordinatedGraphicsScene::removeTile(CoordinatedLayerID layerID, uint32_t tileID)
>@@ -439,7 +439,6 @@ void CoordinatedGraphicsScene::removeTile(CoordinatedLayerID layerID, uint32_t t
>         return;
> 
>     backingStore->removeTile(tileID);
>-    resetBackingStoreSizeToLayerSize(layer);
>     m_backingStoresWithPendingBuffers.add(backingStore);
> }
> 
>@@ -453,7 +452,6 @@ void CoordinatedGraphicsScene::updateTile(CoordinatedLayerID layerID, uint32_t t
>     ASSERT(it != m_surfaces.end());
> 
>     backingStore->updateTile(tileID, update.sourceRect, update.tileRect, it->value, update.offset);
>-    resetBackingStoreSizeToLayerSize(layer);
>     m_backingStoresWithPendingBuffers.add(backingStore);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 109645: 187983 | 188040 | 188226