Attachment 18401 Details for Bug 16715 – Using font options from gdk screen

[patch] Using font options from gdk screen

bug_16715_glyph_spacing.diff (text/plain), 1.99 KB, created by Sylvain Pasche on 2008-01-11 17:18:35 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Sylvain Pasche

Created: 2008-01-11 17:18:35 PST

Size: 1.99 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 29422)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2008-01-11  Sylvain Pasche  <sylvain.pasche@gmail.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [Gtk] Uneven glyph spacing with subpixel antialiasing
>+        http://bugs.webkit.org/show_bug.cgi?id=16715
>+
>+        Use cairo font options from the default GDK screen when creating a
>+        scaled font.
>+
>+        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
>+        (WebCore::FontPlatformData::FontPlatformData):
>+
> 2008-01-11  Christian Dywan  <christian@imendio.com>
> 
>         Reviewed by Alp Toker.
>Index: WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp
>===================================================================
>--- WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp	(revision 29420)
>+++ WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp	(working copy)
>@@ -31,6 +31,7 @@
> #include <cairo-ft.h>
> #include <cairo.h>
> #include <fontconfig/fcfreetype.h>
>+#include <gtk/gtk.h>
> 
> namespace WebCore {
> 
>@@ -55,7 +56,7 @@ FontPlatformData::FontPlatformData(const
> 
>     FcPattern* pattern = FcPatternCreate();
>     cairo_font_face_t* fontFace;
>-    cairo_font_options_t* options;
>+    const cairo_font_options_t* options;
>     cairo_matrix_t fontMatrix;
> 
>     if (!FcPatternAddString(pattern, FC_FAMILY, reinterpret_cast<const FcChar8*>(fcfamily)))
>@@ -98,10 +99,9 @@ FontPlatformData::FontPlatformData(const
>     cairo_matrix_t ctm;
>     cairo_matrix_init_scale(&fontMatrix, m_fontDescription.computedSize(), m_fontDescription.computedSize());
>     cairo_matrix_init_identity(&ctm);
>-    options = cairo_font_options_create();
>+    options = gdk_screen_get_font_options(gdk_screen_get_default());
>     m_scaledFont = cairo_scaled_font_create(fontFace, &fontMatrix, &ctm, options);
>     cairo_font_face_destroy(fontFace);
>-    cairo_font_options_destroy(options);
> 
> freePattern:
>     FcPatternDestroy(pattern);

Flags:

alp: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 16715: 18246 | 18261 | 18262 | 18401