Attachment 179273 Details for Bug 104915 – Patch

[patch] Patch

bug-104915-20121213175315.patch (text/plain), 1.81 KB, created by Thiago Marcos P. Santos on 2012-12-13 07:51:24 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Thiago Marcos P. Santos

Created: 2012-12-13 07:51:24 PST

Size: 1.81 KB

patch

obsolete

>Subversion Revision: 137584
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index 7210f080e6253dc0a68f24474fa15e6b1e0d5a51..6863b783da21894df60378bdf801cb12f27f888b 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-12-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
>+
>+        [EFL] Update the way we set the cookies policy
>+        https://bugs.webkit.org/show_bug.cgi?id=104915
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We are mistakenly assigning the cookie policy to the persistent storage
>+        type which is not correct. This was caused by r137432 and is making
>+        the unit tests fail.
>+
>+        * UIProcess/efl/WebContextEfl.cpp:
>+        (WebKit::WebContext::platformInitializeWebProcess):
>+
> 2012-12-13  Joaquim Rocha  <jrocha@igalia.com>
> 
>         REGRESSION (r137432): The /webkit2/WebKitCookieManager/accept-policy unit test is failing
>diff --git a/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp b/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp
>index ec864cc893428e3b5b734d2745ffb0c534809821..6a00be04165969bb02a0bf975a76b8bac9e8ff38 100644
>--- a/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp
>+++ b/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp
>@@ -89,7 +89,8 @@ void WebContext::platformInitializeWebProcess(WebProcessCreationParameters& para
>     initializeInspectorServer();
> 
>     parameters.urlSchemesRegistered = m_soupRequestManagerProxy->registeredURISchemes();
>-    m_cookieManagerProxy->getCookiePersistentStorage(parameters.cookiePersistentStoragePath, parameters.cookieAcceptPolicy);
>+    m_cookieManagerProxy->getCookiePersistentStorage(parameters.cookiePersistentStoragePath, parameters.cookiePersistentStorageType);
>+    parameters.cookieAcceptPolicy = m_initialHTTPCookieAcceptPolicy;
> }
> 
> void WebContext::platformInvalidateContext()

Actions: View | Formatted Diff | Diff

Attachments on bug 104915: 179273