Attachment 167985 Details for Bug 98892 – Patch

[patch] Patch

bug-98892-20121010150558.patch (text/plain), 2.01 KB, created by Mike West on 2012-10-10 06:06:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mike West

Created: 2012-10-10 06:06:59 PDT

Size: 2.01 KB

patch

obsolete

>Subversion Revision: 130749
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e46252a322e42152564f2ba0bcb42a2fde7be61d..817367935e6d508569849a184d8ca57461eb7870 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2012-10-10  Mike West  <mkwst@google.com>
>+
>+        HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters.
>+        https://bugs.webkit.org/show_bug.cgi?id=98892
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        HTMLTextFormControlElement::updatePlaceholderVisibility calls
>+        HTMLElement::setInlineStyleProperty with an ExceptionCode as the last
>+        parameter. This only succeeds because it's automagically cast to a bool,
>+        which is what the method actually expects.
>+
>+        Explicitly passing in 'false' shouldn't change any functionality; so no
>+        new tests are required.
>+
>+        * html/HTMLTextFormControlElement.cpp:
>+        (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
>+
> 2012-10-09  Sheriff Bot  <webkit.review.bot@gmail.com>
> 
>         Unreviewed, rolling out r130746.
>diff --git a/Source/WebCore/html/HTMLTextFormControlElement.cpp b/Source/WebCore/html/HTMLTextFormControlElement.cpp
>index 70c06191ed45972a044578cdc039ebe9ff16138e..93047d8c9bf4db385e9e837e0791f751bad02038 100644
>--- a/Source/WebCore/html/HTMLTextFormControlElement.cpp
>+++ b/Source/WebCore/html/HTMLTextFormControlElement.cpp
>@@ -159,9 +159,7 @@ void HTMLTextFormControlElement::updatePlaceholderVisibility(bool placeholderVal
>     HTMLElement* placeholder = placeholderElement();
>     if (!placeholder)
>         return;
>-    ExceptionCode ec = 0;
>-    placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden", ec);
>-    ASSERT(!ec);
>+    placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden", false);
> }
> 
> void HTMLTextFormControlElement::fixPlaceholderRenderer(HTMLElement* placeholder, HTMLElement* siblingElement)

Actions: View | Formatted Diff | Diff

Attachments on bug 98892: 167985 | 167990