Attachment 159150 Details for Bug 94255 – Patch

[patch] Patch

bug-94255-20120817101338.patch (text/plain), 3.52 KB, created by Shadi on 2012-08-17 10:14:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Shadi

Created: 2012-08-17 10:14:14 PDT

Size: 3.52 KB

patch

obsolete

>Subversion Revision: 125811
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 89be72f038f48497a3cbbe3c1321163b93c07358..04b8293d73b3621eaa1418523096c2217771ab83 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2012-08-16  Shadi Khalek  <shadi@chromium.org>
>+
>+        Add AV perf layout tests to webkit flakiness dashboard
>+        https://bugs.webkit.org/show_bug.cgi?id=94255
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
>+        The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
>+        It assumes the new names they are getting renamed to (AV Linux, AV Win7).
>+
>+        * TestResultServer/static-dashboards/builders.js:
>+        (isChromiumTipOfTreeAVTestRunner):
>+        (loadBuildersList):
>+
> 2012-08-16  Roger Fong  <roger_fong@apple.com>
> 
>         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
>diff --git a/Tools/TestResultServer/static-dashboards/builders.js b/Tools/TestResultServer/static-dashboards/builders.js
>index f6dbdf56413f15015218df5417a682b3a644e93d..10abbed6d37993fbcf9da462b09969c5653691b9 100644
>--- a/Tools/TestResultServer/static-dashboards/builders.js
>+++ b/Tools/TestResultServer/static-dashboards/builders.js
>@@ -52,14 +52,19 @@ CHROMIUM_LINUX_BUILDER_MASTER = new BuilderMaster('ChromiumLinux', 'http://build
> CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/');
> CHROMIUM_GPU_BUILDER_MASTER = new BuilderMaster('ChromiumGPU', 'http://build.chromium.org/p/chromium.gpu/');
> CHROMIUM_GPU_FYI_BUILDER_MASTER = new BuilderMaster('ChromiumGPUFYI', 'http://build.chromium.org/p/chromium.gpu.fyi/');
>+CHROMIUM_PERF_AV_BUILDER_MASTER = new BuilderMaster('ChromiumPerfAv', 'http://build.chromium.org/p/chromium.perf_av/');
> CHROMIUM_WEBKIT_BUILDER_MASTER = new BuilderMaster('ChromiumWebkit', 'http://build.chromium.org/p/chromium.webkit/');
> WEBKIT_BUILDER_MASTER = new BuilderMaster('webkit.org', 'http://build.webkit.org/');
> 
> var LEGACY_BUILDER_MASTERS_TO_GROUPS = {
>     'Chromium': '@DEPS - chromium.org',
>+    'ChromiumWin': '@DEPS - chromium.org',
>+    'ChromiumMac': '@DEPS - chromium.org',
>+    'ChromiumLinux': '@DEPS - chromium.org',
>     'ChromiumChromiumOS': '@DEPS CrOS - chromium.org',
>     'ChromiumGPU': '@DEPS - chromium.org',
>     'ChromiumGPUFYI': '@DEPS FYI - chromium.org',
>+    'ChromiumPerfAv': '@DEPS - chromium.org',
>     'ChromiumWebkit': '@ToT - chromium.org',
>     'webkit.org': '@ToT - webkit.org'
> };
>@@ -191,6 +196,11 @@ function isChromiumTipOfTreeGTestRunner(builder)
>          builder.indexOf('Webkit') == -1 && builder.indexOf('Valgrind') == -1 && builder.indexOf('Chrome Frame') == -1;
> }
> 
>+function isChromiumDepsAVTestRunner(builder)
>+{
>+    return builder.indexOf('Builder') == -1;
>+}
>+
> function generateBuildersFromBuilderList(builderList, filter)
> {
>     return builderList.filter(filter).map(function(tester, index) {
>@@ -253,6 +263,7 @@ function loadBuildersList(groupName, testType) {
>         case '@DEPS - chromium.org':
>             var builderGroup = new BuilderGroup(BuilderGroup.DEPS_WEBKIT);
>             requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumWebkitDepsTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.DEPS_WEBKIT, builderGroup);
>+            requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumDepsAVTestRunner, CHROMIUM_PERF_AV_BUILDER_MASTER, groupName, BuilderGroup.DEPS_WEBKIT, builderGroup);
>             break;
>         }
>         break;

Actions: View | Formatted Diff | Diff

Attachments on bug 94255: 158911 | 158925 | 159150