Attachment 156553 Details for Bug 92824 – Patch

[patch] Patch

bug-92824-20120804233605.patch (text/plain), 3.97 KB, created by Ami Fischman on 2012-08-04 23:36:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ami Fischman

Created: 2012-08-04 23:36:27 PDT

Size: 3.97 KB

patch

obsolete

>Subversion Revision: 124698
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index c956189bcd31325fd1e12a6f3ab2cc04f59a3410..b2d4f5020c2fce6a9ce50bed7ca327b210755653 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2012-08-04  Ami Fischman  <fischman@chromium.org>
>+
>+        media/video-poster-blocked-by-willsendrequest.html isn't blocking poster on willsendrequest
>+        https://bugs.webkit.org/show_bug.cgi?id=92824
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Chromium/Mac/GTK DRTs appear not to clear the cache between tests so append a random query-string param to avoid a cache hit in this test.
>+        Filed 93195 for the chromium port, Mac has 82976, and GTK has 79760.
>+
>+        * media/video-poster-blocked-by-willsendrequest.html:
>+        * platform/chromium/TestExpectations:
>+        * platform/gtk/TestExpectations
>+        * platform/mac/Skipped
>+
> 2012-08-03  Robert Hogan  <robert@webkit.org>
> 
>         CSS 2.1 failure: overflow-applies-to-001 fails
>diff --git a/LayoutTests/media/video-poster-blocked-by-willsendrequest.html b/LayoutTests/media/video-poster-blocked-by-willsendrequest.html
>index 46af3d2fa0cd9f5b2771abe8c343e6ecd08c5564..4e23e7b93888417f9b19704d550b434ae5470f20 100644
>--- a/LayoutTests/media/video-poster-blocked-by-willsendrequest.html
>+++ b/LayoutTests/media/video-poster-blocked-by-willsendrequest.html
>@@ -37,7 +37,10 @@
>                 testExpected("video.clientWidth", 300);
>                 testExpected("video.clientHeight", 150);
> 
>-                video.poster = "content/abe.png";
>+                // Since this is testing resource-loading being blocked, append a random query string to avoid cache hits from other tests.
>+                // FIXME: it's madness that this needs to account for other tests.
>+                // Why isn't the cache being cleared between tests?  Looks like port-specific DRT bugs (chromium: 93195, mac: 82976, gtk: 79760).
>+                video.poster = "content/abe.png?" + Math.random();
> 
>                 setTimeout(testAfterLoadingPoster, 100);
>             }
>diff --git a/LayoutTests/platform/chromium/TestExpectations b/LayoutTests/platform/chromium/TestExpectations
>index fdc65d7080b5aaf44e19eb42b3908131a4f1a647..24f7770a8198fdc6d9af86acd30b4eaed5589a34 100644
>--- a/LayoutTests/platform/chromium/TestExpectations
>+++ b/LayoutTests/platform/chromium/TestExpectations
>@@ -3190,8 +3190,6 @@ BUGWK86414 : fast/loader/javascript-url-in-embed.html = TEXT
> 
> BUGDPRANKE : http/tests/security/sandboxed-iframe-modify-self.html = TEXT
> 
>-// The result of jquery/traversing.html is bleeding into this test.
>-BUGDPRANKE : media/video-poster-blocked-by-willsendrequest.html = TEXT PASS
> BUGDPRANKE MAC : userscripts/user-style-all-frames.html = TEXT PASS
> 
> // Interferes with the rAF tests that are enabled
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 4ae86eb3b740383d6657f1b142e5a5ee85c0d554..4e0043a52335ba2ae54427612a2352025bb3eae3 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -447,7 +447,6 @@ BUGWK80129 : fast/frames/flattening/iframe-flattening-out-of-view.html = TEXT PA
> BUGWK87363 : fast/frames/flattening/iframe-tiny.html = PASS TEXT
> 
> BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT
>-BUGWK79760 : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
> 
> BUGWK73772 : fast/table/multiple-captions-display.xhtml = PASS TEXT
> 
>diff --git a/LayoutTests/platform/mac/Skipped b/LayoutTests/platform/mac/Skipped
>index 859d37356d58035cc3798de718a8e947e1e4ce26..cfc69d3f78f34c9bcf63ede45244db6a4fd4238e 100644
>--- a/LayoutTests/platform/mac/Skipped
>+++ b/LayoutTests/platform/mac/Skipped
>@@ -759,7 +759,6 @@ plugins/multiple-plugins.html
> 
> # https://bugs.webkit.org/show_bug.cgi?id=82976
> media/W3C/video/networkState/networkState_during_progress.html
>-media/video-poster-blocked-by-willsendrequest.html
> 
> # https://bugs.webkit.org/show_bug.cgi?id=82978
> inspector/styles/svg-style.xhtml

Actions: View | Formatted Diff | Diff

Attachments on bug 92824: 156552 | 156553 | 156554 | 156555 | 156561