Attachment 156107 Details for Bug 93000 – Patch

[patch] Patch

bug-93000-20120802203003.patch (text/plain), 1.59 KB, created by Vsevolod Vlasov on 2012-08-02 09:30:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Vsevolod Vlasov

Created: 2012-08-02 09:30:22 PDT

Size: 1.59 KB

patch

obsolete

>Subversion Revision: 124466
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ff7f96b41f5aaa91ff7fe46c12c643ad75748ae0..0f153fe43f8f0ccb010ebda9a8f1689db6124bd1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2012-08-02  Vsevolod Vlasov  <vsevik@chromium.org>
>+
>+        Web Inspector: [Regression] context menu does not open on Sources panel tabs on mac
>+        https://bugs.webkit.org/show_bug.cgi?id=93000
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/front-end/UIUtils.js:
>+        (WebInspector._elementDragStart):
>+
> 2012-08-02  Kwang Yul Seo  <skyul@company100.net>
> 
>         Check if the last table element's parent node is an element when determining the foster parent element.
>diff --git a/Source/WebCore/inspector/front-end/UIUtils.js b/Source/WebCore/inspector/front-end/UIUtils.js
>index ce5b3dbdfeda67fc20ffa2f5ec4554924f4df503..7f93f0d22ec8dbddbbc4d32c3b4ebf429215e60e 100644
>--- a/Source/WebCore/inspector/front-end/UIUtils.js
>+++ b/Source/WebCore/inspector/front-end/UIUtils.js
>@@ -50,8 +50,8 @@ WebInspector.installDragHandle = function(element, elementDragStart, elementDrag
>  */
> WebInspector._elementDragStart = function(elementDragStart, elementDrag, elementDragEnd, cursor, event)
> {
>-    // Only drag upon left button. Right will likely cause a context menu.
>-    if (event.button)
>+    // Only drag upon left button. Right will likely cause a context menu. So will ctrl-click on mac.
>+    if (event.button || (WebInspector.isMac() && event.ctrlKey))
>         return;
> 
>     if (WebInspector._elementDraggingEventListener)

Flags:

pfeldman: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 93000: 156107