Attachment 152417 Details for Bug 91317 – ROLLOUT of r122614

[patch] ROLLOUT of r122614

bug-91317-20120714085834.patch (text/plain), 1.29 KB, created by WebKit Review Bot on 2012-07-14 01:53:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Review Bot

Created: 2012-07-14 01:53:08 PDT

Size: 1.29 KB

patch

obsolete

>Subversion Revision: 122662
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1dbb66da2b14989a3d810f8016f25839a2a67914..c895dfd1d8617d6df779953a2b068250e90a8b8f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2012-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
>+
>+        Unreviewed, rolling out r122614.
>+        http://trac.webkit.org/changeset/122614
>+        https://bugs.webkit.org/show_bug.cgi?id=91317
>+
>+        Broke performance tests (Requested by rniwa on #webkit).
>+
>+        * bindings/v8/V8Binding.cpp:
>+        (WebCore::StringCache::v8ExternalStringSlow):
>+
> 2012-07-13  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Iterating backwards over HTMLCollection is O(n^2)
>diff --git a/Source/WebCore/bindings/v8/V8Binding.cpp b/Source/WebCore/bindings/v8/V8Binding.cpp
>index df789186d86f4c8a97c73d5ed922fa92b05d80d7..8198ad0d6ac1e99549b0ac1e1398ff21f04d9214 100644
>--- a/Source/WebCore/bindings/v8/V8Binding.cpp
>+++ b/Source/WebCore/bindings/v8/V8Binding.cpp
>@@ -493,7 +493,6 @@ v8::Local<v8::String> StringCache::v8ExternalStringSlow(StringImpl* stringImpl,
>         return newString;
> 
>     stringImpl->ref();
>-    wrapper.MarkIndependent();
>     wrapper.MakeWeak(stringImpl, cachedStringCallback);
>     m_stringCache.set(stringImpl, *wrapper);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 91317: 152417