Attachment 150944 Details for Bug 90612 – Patch

[patch] Patch

bug-90612-20120705171933.patch (text/plain), 2.06 KB, created by Jocelyn Turcotte on 2012-07-05 08:22:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jocelyn Turcotte

Created: 2012-07-05 08:22:46 PDT

Size: 2.06 KB

patch

obsolete

>Subversion Revision: 121903
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 3c1389fefe4eb9fd891392698d9e32fb965a59ca..20d01efa16d52c526ace1e937993097b7bacf657 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,22 @@
>+2012-07-05  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
>+
>+        Re-enable __declspec(dl{import,export}) for MinGW when using EXPORT_MACROS
>+        https://bugs.webkit.org/show_bug.cgi?id=90612
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        MinGW was switched to do auto import/export on r44184.
>+        From my understanding of the documentation, MinGW will not auto-export symbols
>+        unless there are no other __declspec(dlexport) in the whole DLL.
>+
>+        The issues that originally made us relied on the auto-import feature of MinGW
>+        should now be resolved with the EXPORT_MACROS work. This patch re-enables them.
>+
>+        It also removes the GCC check for internal symbols hiding as the visibility should
>+        already be hidden by default for both MSVC and GCC on Windows anyway.
>+
>+        * wtf/ExportMacros.h:
>+
> 2012-07-05  Zoltan Herczeg  <zherczeg@webkit.org>
> 
>         Port DFG JIT to traditional ARM
>diff --git a/Source/WTF/wtf/ExportMacros.h b/Source/WTF/wtf/ExportMacros.h
>index 36d7f48df10b9d82eac99bb012cdeb7b0615d85a..20732b2a60300fcac7c530b4c05a5e5908958169 100644
>--- a/Source/WTF/wtf/ExportMacros.h
>+++ b/Source/WTF/wtf/ExportMacros.h
>@@ -38,7 +38,7 @@
> // being local to the target being generated, and thus not subject to (e.g.) ELF
> // symbol interposition rules.
> 
>-#if !PLATFORM(CHROMIUM) && OS(WINDOWS) && !COMPILER(GCC)
>+#if !PLATFORM(CHROMIUM) && OS(WINDOWS)
> #define HAVE_INTERNAL_VISIBILITY 1
> #define WTF_INTERNAL
> #elif defined(__GNUC__) && !defined(__CC_ARM) && !defined(__ARMCC__)
>@@ -51,7 +51,7 @@
> // See note in wtf/Platform.h for more info on EXPORT_MACROS.
> #if USE(EXPORT_MACROS)
> 
>-#if !PLATFORM(CHROMIUM) && OS(WINDOWS) && !COMPILER(GCC)
>+#if !PLATFORM(CHROMIUM) && OS(WINDOWS)
> #define WTF_EXPORT __declspec(dllexport)
> #define WTF_IMPORT __declspec(dllimport)
> #define WTF_HIDDEN

Actions: View | Formatted Diff | Diff

Attachments on bug 90612: 150944 | 150945