Attachment 128272 Details for Bug 79270 – Patch

[patch] Patch

bug-79270-20120222190752.patch (text/plain), 5.79 KB, created by Raphael Kubo da Costa (:rakuco) on 2012-02-22 13:06:27 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Raphael Kubo da Costa (:rakuco)

Created: 2012-02-22 13:06:27 PST

Size: 5.79 KB

patch

obsolete

>Subversion Revision: 108536
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 18f27be370ab6481a9e98899b30ba3e511c2fc94..44eb4523a214eabf70d9d8c3c980119adb2afae8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2012-02-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
>+
>+        [EFL] Get rid of GeolocationServiceEfl
>+        https://bugs.webkit.org/show_bug.cgi?id=79270
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These were just a bunch of dummy files with no real functionality, and
>+        removing them helps the preparation of bug 78853, which will make
>+        client-based geolocation the default.
>+
>+        No new tests, this functionality was not used.
>+
>+        * PlatformEfl.cmake:
>+        * platform/efl/GeolocationServiceEfl.cpp: Removed.
>+        * platform/efl/GeolocationServiceEfl.h: Removed.
>+
> 2012-02-22  Alexei Svitkine  <asvitkine@chromium.org>
> 
>         [chromium] Fix remaining compositing/rubberbanding test failures
>diff --git a/Source/WebCore/PlatformEfl.cmake b/Source/WebCore/PlatformEfl.cmake
>index ac4d1b4f174339b3a9c36cd644c700e7e5ac6ba8..5d98c89049b92dfa2db76b5e1472e9c24b23a05d 100644
>--- a/Source/WebCore/PlatformEfl.cmake
>+++ b/Source/WebCore/PlatformEfl.cmake
>@@ -181,12 +181,6 @@ IF (WTF_USE_ICU_UNICODE)
>   )
> ENDIF ()
> 
>-IF (ENABLE_GEOLOCATION)
>-  LIST(APPEND WebCore_SOURCES
>-    platform/efl/GeolocationServiceEfl.cpp
>-  )
>-ENDIF()
>-
> IF (ENABLE_VIDEO)
>   LIST(APPEND WebCore_INCLUDE_DIRECTORIES
>     "${WEBCORE_DIR}/platform/graphics/gstreamer"
>diff --git a/Source/WebCore/platform/efl/GeolocationServiceEfl.cpp b/Source/WebCore/platform/efl/GeolocationServiceEfl.cpp
>deleted file mode 100644
>index 975c72098df00cf92cdb283f210dc594e4fd5c52..0000000000000000000000000000000000000000
>--- a/Source/WebCore/platform/efl/GeolocationServiceEfl.cpp
>+++ /dev/null
>@@ -1,72 +0,0 @@
>-/*
>- * Copyright (C) 2008 Holger Hans Peter Freyther
>- * Copyright (C) 2011 Samsung Electronics
>- *
>- * This library is free software; you can redistribute it and/or
>- * modify it under the terms of the GNU Library General Public
>- * License as published by the Free Software Foundation; either
>- * version 2 of the License, or (at your option) any later version.
>- *
>- * This library is distributed in the hope that it will be useful,
>- * but WITHOUT ANY WARRANTY; without even the implied warranty of
>- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>- * Library General Public License for more details.
>- *
>- * You should have received a copy of the GNU Library General Public License
>- * along with this library; see the file COPYING.LIB.  If not, write to
>- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>- * Boston, MA 02110-1301, USA.
>- */
>-
>-#include "config.h"
>-#include "GeolocationServiceEfl.h"
>-
>-#if ENABLE(GEOLOCATION)
>-#include "NotImplemented.h"
>-#include "PositionOptions.h"
>-#include <wtf/text/CString.h>
>-
>-namespace WebCore {
>-
>-#if !ENABLE(CLIENT_BASED_GEOLOCATION)
>-GeolocationService::FactoryFunction* GeolocationService::s_factoryFunction = &GeolocationServiceEfl::create;
>-#endif
>-
>-PassOwnPtr<GeolocationService> GeolocationServiceEfl::create(GeolocationServiceClient* client)
>-{
>-    return adoptPtr(new GeolocationServiceEfl(client));
>-}
>-
>-GeolocationServiceEfl::GeolocationServiceEfl(GeolocationServiceClient* client)
>-    : GeolocationService(client)
>-{
>-}
>-
>-GeolocationServiceEfl::~GeolocationServiceEfl()
>-{
>-    notImplemented();
>-}
>-
>-bool GeolocationServiceEfl::startUpdating(PositionOptions* options)
>-{
>-    notImplemented();
>-    return false;
>-}
>-
>-void GeolocationServiceEfl::stopUpdating()
>-{
>-    notImplemented();
>-}
>-
>-Geoposition* GeolocationServiceEfl::lastPosition() const
>-{
>-    return m_lastPosition.get();
>-}
>-
>-PositionError* GeolocationServiceEfl::lastError() const
>-{
>-    return m_lastError.get();
>-}
>-
>-}
>-#endif // ENABLE(GEOLOCATION)
>diff --git a/Source/WebCore/platform/efl/GeolocationServiceEfl.h b/Source/WebCore/platform/efl/GeolocationServiceEfl.h
>deleted file mode 100644
>index 0cd3e8be7c6b1df1d2cc1f9b717b48f487b94dc3..0000000000000000000000000000000000000000
>--- a/Source/WebCore/platform/efl/GeolocationServiceEfl.h
>+++ /dev/null
>@@ -1,53 +0,0 @@
>-/*
>- * Copyright (C) 2008 Holger Hans Peter Freyther
>- * Copyright (C) 2011 Samsung Electronics
>- *
>- * This library is free software; you can redistribute it and/or
>- * modify it under the terms of the GNU Library General Public
>- * License as published by the Free Software Foundation; either
>- * version 2 of the License, or (at your option) any later version.
>- *
>- * This library is distributed in the hope that it will be useful,
>- * but WITHOUT ANY WARRANTY; without even the implied warranty of
>- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>- * Library General Public License for more details.
>- *
>- * You should have received a copy of the GNU Library General Public License
>- * along with this library; see the file COPYING.LIB.  If not, write to
>- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>- * Boston, MA 02110-1301, USA.
>- */
>-
>-#ifndef GeolocationServiceEfl_h
>-#define GeolocationServiceEfl_h
>-
>-#if ENABLE(GEOLOCATION)
>-#include "GeolocationService.h"
>-#include "Geoposition.h"
>-#include "PositionError.h"
>-#include "RefPtr.h"
>-
>-namespace WebCore {
>-
>-class GeolocationServiceEfl : public GeolocationService {
>-public:
>-    static PassOwnPtr<GeolocationService> create(GeolocationServiceClient*);
>-    ~GeolocationServiceEfl();
>-
>-    virtual bool startUpdating(PositionOptions*);
>-    virtual void stopUpdating();
>-
>-    virtual Geoposition* lastPosition() const;
>-    virtual PositionError* lastError() const;
>-
>-private:
>-    GeolocationServiceEfl(GeolocationServiceClient*);
>-
>-    RefPtr<Geoposition> m_lastPosition;
>-    RefPtr<PositionError> m_lastError;
>-
>-};
>-
>-}
>-#endif // ENABLE(GEOLOCATION)
>-#endif

Flags:

abarth: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 79270: 128272