Attachment 125523 Details for Bug 77829 – Patch

[patch] Patch

bug-77829-20120205133357.patch (text/plain), 2.49 KB, created by Ilya Tikhonovsky on 2012-02-05 01:33:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ilya Tikhonovsky

Created: 2012-02-05 01:33:59 PST

Size: 2.49 KB

patch

obsolete

>Subversion Revision: 106756
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a7f2944536141f3b0327fd025c1cdce5273bc62f..5f0c7f4272693fe6510f352dc8a7095d85ade4e4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2012-02-05  Ilya Tikhonovsky  <loislo@chromium.org>
>+
>+        Web Inspector: REGRESSION detached dom nodes aren't highlighted
>+        https://bugs.webkit.org/show_bug.cgi?id=77829
>+
>+        This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/front-end/HeapSnapshot.js:
>+        (WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
>+        (WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
>+
> 2012-02-05  Andreas Kling  <awesomekling@apple.com>
> 
>         Kill CSSMappedAttributeDeclaration.
>diff --git a/Source/WebCore/inspector/front-end/HeapSnapshot.js b/Source/WebCore/inspector/front-end/HeapSnapshot.js
>index 5e243aa14e29852982839fea25fbe1267dec5b5e..6a9c8c29fbc33168a9b02f8479f6d0f3c9ce1607 100644
>--- a/Source/WebCore/inspector/front-end/HeapSnapshot.js
>+++ b/Source/WebCore/inspector/front-end/HeapSnapshot.js
>@@ -571,9 +571,9 @@ WebInspector.HeapSnapshotNode.prototype = {
>         return this.name.substr(0, 9) === "DOMWindow";
>     },
> 
>-    get isNativeRoot()
>+    get isDetachedDOMTreesRoot()
>     {
>-        return this.name === "(Native objects)";
>+        return this.name === "(Detached DOM trees)";
>     },
> 
>     get isDetachedDOMTree()
>@@ -1081,19 +1081,19 @@ WebInspector.HeapSnapshot.prototype = {
>     _markDetachedDOMTreeNodes: function()
>     {
>         var flag = this._nodeFlags.detachedDOMTreeNode;
>-        var nativeRoot;
>+        var detachedDOMTreesRoot;
>         for (var iter = this.rootNode.edges; iter.hasNext(); iter.next()) {
>             var node = iter.edge.node;
>-            if (node.isNativeRoot) {
>-                nativeRoot = node;
>+            if (node.isDetachedDOMTreesRoot) {
>+                detachedDOMTreesRoot = node;
>                 break;
>             }
>         }
> 
>-        if (!nativeRoot)
>+        if (!detachedDOMTreesRoot)
>             return;
> 
>-        for (var iter = nativeRoot.edges; iter.hasNext(); iter.next()) {
>+        for (var iter = detachedDOMTreesRoot.edges; iter.hasNext(); iter.next()) {
>             var node = iter.edge.node;
>             if (node.isDetachedDOMTree) {
>                 for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next())

Actions: View | Formatted Diff | Diff

Attachments on bug 77829: 125523