Attachment 12312 Details for Bug 12168 – patch-1 for 3.2

patch-1 for 3.2

historyView_ccb.patch (text/plain), 2.49 KB, created by Shyam Sareen on 2007-01-08 14:54:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Shyam Sareen

Created: 2007-01-08 14:54:33 PST

Size: 2.49 KB

patch

obsolete

>Index: WebKit/ChangeLog
>===================================================================
>--- WebKit/ChangeLog	(revision 18680)
>+++ WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2007-01-08  sareen  <shyam.sareen@nokia.com>
>+
>+        Reviewed by Sachin Padma.
>+        DESC: Switching to landscape while graphical back is open causes UI problem.
>+        http://bugs.webkit.org/show_bug.cgi?id=12168
>+
>+        * BrowserView/src/WebKitView.cpp:
>+        (CWebKitView::SizeChanged):
>+
> 2007-01-08  spadma  <Sachin.Padma@nokia.com>
> 
>         Reviewed by Yongjun.
>Index: WebKit/BrowserView/src/WebKitView.cpp
>===================================================================
>--- WebKit/BrowserView/src/WebKitView.cpp	(revision 18680)
>+++ WebKit/BrowserView/src/WebKitView.cpp	(working copy)
>@@ -74,6 +74,7 @@
> #include "textrendererfactory.h"
> #include "MemoryManager.h"
> #include "LoaderContainer.h"
>+#include "HistoryView.h"
> 
> // DEFINES
> 
>@@ -719,26 +720,35 @@ void CWebKitView::SizeChanged()
>         iMainFrame->SetFrameRect(r);
>         // set the maximum width for text columns
>         CWebKitFrame* f = iMainFrame;
>+
>         while ( f )
>             {
>             f->CalcBidiWidth();
>             f = f->TraverseNext();
>             }
>+
>+
>         // forces relayout
>         iMainFrame->LayoutRecursive(ETrue,widthChanged, sendResizeEvents);
>         if( sendResizeEvents )
>             {
>             UpdateScrollBarsL( CEikScrollBar::EVertical, iMainFrame->ContentPosition().iY, iMainFrame->ContentSize().iHeight );
>             UpdateScrollBarsL( CEikScrollBar::EHorizontal, iMainFrame->ContentPosition().iX, iMainFrame->ContentSize().iWidth );
>-            if( iInputWidget  )
>+            if( iInputWidget )
>                 {
>                 //The following is required when phone is flipped from
>                 //the portrait mode to landscape or vice versa. The text
>                 //in the active box is redrawn correctly.
>                 DeActivate(ETrue);
>                 }
>-            }
>-        }
>+            CHistoryView* historyView = iWebKitControl->HistoryView();
>+            if( historyView )
>+                {
>+                historyView->SetRect( Rect() );
>+                DrawNow();                                
>+                } //end if( historyView )
>+            } // end if( sendResizeEvents )
>+        }//end if (iMainFrame)
>     }
> 
> //-------------------------------------------------------------------------------

Actions: View

Attachments on bug 12168: 12311 | 12312 | 12333 | 12334