Attachment 110299 Details for Bug 69722 – the patch

[patch] the patch

69722.patch (text/plain), 1.56 KB, created by Yuqiang Xian on 2011-10-09 05:11:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yuqiang Xian

Created: 2011-10-09 05:11:26 PDT

Size: 1.56 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 97026)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2011-10-09  Yuqiang Xian  <yuqiang.xian@intel.com>
>+
>+        Remove unused callOperation code of DFG JIT on X86
>+        https://bugs.webkit.org/show_bug.cgi?id=69722
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dfg/DFGJITCodeGenerator.h:
>+        (JSC::DFG::callOperation):
>+
> 2011-10-09  Yuqiang Xian  <yuqiang.xian@intel.com>
> 
>         Fix value profiling in 32_64 JIT
>Index: Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h	(revision 97026)
>+++ Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h	(working copy)
>@@ -1343,18 +1343,6 @@ protected:
>     {
>         callOperation((V_DFGOperation_EJJP)operation, arg1Tag, arg1Payload, arg2Tag, arg2Payload, identifier);
>     }
>-    void callOperation(V_DFGOperation_EJJJ operation, GPRReg arg1Tag, GPRReg arg1Payload, GPRReg arg2Tag, GPRReg arg2Payload, GPRReg arg3Tag, GPRReg arg3Payload)
>-    {
>-        m_jit.push(arg3Tag);
>-        m_jit.push(arg3Payload);
>-        m_jit.push(arg2Tag);
>-        m_jit.push(arg2Payload);
>-        m_jit.push(arg1Tag);
>-        m_jit.push(arg1Payload);
>-        m_jit.push(GPRInfo::callFrameRegister);
>-
>-        appendCallWithExceptionCheck(operation);
>-    }
> 
>     void callOperation(D_DFGOperation_DD operation, FPRReg result, FPRReg arg1, FPRReg arg2)
>     {

Flags:

fpizlo: review+
webkit.review.bot: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 69722: 110299