WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
the patch
69075.patch (text/plain), 2.45 KB, created by
Yuqiang Xian
on 2011-09-29 02:05:23 PDT
(
hide
)
Description:
the patch
Filename:
MIME Type:
Creator:
Yuqiang Xian
Created:
2011-09-29 02:05:23 PDT
Size:
2.45 KB
patch
obsolete
>Index: Source/JavaScriptCore/ChangeLog >=================================================================== >--- Source/JavaScriptCore/ChangeLog (revision 96313) >+++ Source/JavaScriptCore/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com> >+ >+ Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT >+ https://bugs.webkit.org/show_bug.cgi?id=69075 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * dfg/DFGSpeculativeJIT32_64.cpp: >+ (JSC::DFG::SpeculativeJIT::compile): >+ > 2011-09-29 Yuqiang Xian <yuqiang.xian@intel.com> > > JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor >Index: Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp >=================================================================== >--- Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp (revision 96313) >+++ Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp (working copy) >@@ -1674,8 +1674,9 @@ void SpeculativeJIT::compile(Node& node) > slowPath.link(&m_jit); > > silentSpillAllRegisters(resultGPR); >- m_jit.move(protoGPR, GPRInfo::argumentGPR1); >- m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0); >+ m_jit.push(TrustedImm32(JSValue::CellTag)); >+ m_jit.push(protoGPR); >+ m_jit.push(GPRInfo::callFrameRegister); > appendCallWithExceptionCheck(operationCreateThis); > m_jit.move(GPRInfo::returnValueGPR, resultGPR); > silentFillAllRegisters(resultGPR); >@@ -1702,7 +1703,7 @@ void SpeculativeJIT::compile(Node& node) > slowPath.link(&m_jit); > > silentSpillAllRegisters(resultGPR); >- m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0); >+ m_jit.push(GPRInfo::callFrameRegister); > appendCallWithExceptionCheck(operationNewObject); > m_jit.move(GPRInfo::returnValueGPR, resultGPR); > silentFillAllRegisters(resultGPR); >@@ -1834,7 +1835,6 @@ void SpeculativeJIT::compile(Node& node) > GPRReg resultTagGPR = resultTag.gpr(); > GPRReg resultPayloadGPR = resultPayload.gpr(); > >- storage.use(); > StorageAccessData& storageAccessData = m_jit.graph().m_storageAccessData[node.storageAccessDataIndex()]; > > m_jit.load32(JITCompiler::Address(storageGPR, storageAccessData.offset * sizeof(EncodedJSValue) + OBJECT_OFFSETOF(EncodedValueDescriptor, asBits.payload)), resultPayloadGPR);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 69075
: 109136