Attachment 108400 Details for Bug 68654 – Patch

[patch] Patch

bug-68654-20110922140847.patch (text/plain), 1.63 KB, created by Anders Carlsson on 2011-09-22 14:08:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Anders Carlsson

Created: 2011-09-22 14:08:48 PDT

Size: 1.63 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 95750)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2011-09-22  Anders Carlsson  <andersca@apple.com>
>+
>+        We should add support for OVERRIDE and FINAL annotations
>+        https://bugs.webkit.org/show_bug.cgi?id=68654
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add OVERRIDE and FINAL macros for compilers that support them.
>+
>+        * wtf/Compiler.h:
>+
> 2011-09-22  Oliver Hunt  <oliver@apple.com>
> 
>         Implement get_scoped_var in the DFG
>Index: Source/JavaScriptCore/wtf/Compiler.h
>===================================================================
>--- Source/JavaScriptCore/wtf/Compiler.h	(revision 95748)
>+++ Source/JavaScriptCore/wtf/Compiler.h	(working copy)
>@@ -34,6 +34,11 @@
> /* COMPILER(CLANG) - Clang  */
> #if defined(__clang__)
> #define WTF_COMPILER_CLANG 1
>+
>+#ifndef __has_extension
>+#define __has_extension __has_feature /* Compatibility with older versions of clang */
>+#endif
>+
> #endif
> 
> /* COMPILER(MSVC) - Microsoft Visual C++ */
>@@ -189,5 +194,32 @@
> #define WARN_UNUSED_RETURN
> #endif
> 
>+/* OVERRIDE */
>+
>+#ifndef OVERRIDE
>+#if COMPILER(CLANG)
>+#if __has_extension(cxx_override_control)
>+#define OVERRIDE override
>+#endif
>+#elif COMPILER(MSVC)
>+#define OVERRIDE override
>+#else
>+#define OVERRIDE
>+#endif
>+#endif
>+
>+/* FINAL */
>+
>+#ifndef FINAL
>+#if COMPILER(CLANG)
>+#if __has_extension(cxx_override_control)
>+#define FINAL final
>+#endif
>+#elif COMPILER(MSVC)
>+#define FINAL sealed
>+#else
>+#define FINAL
>+#endif
>+#endif
> 
> #endif /* WTF_Compiler_h */

Flags:

hyatt: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 68654: 108396 | 108400