Attachment 108358 Details for Bug 68637 – Patch

[patch] Patch

bug-68637-20110922104830.patch (text/plain), 1.20 KB, created by Anders Carlsson on 2011-09-22 10:48:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Anders Carlsson

Created: 2011-09-22 10:48:28 PDT

Size: 1.20 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 95729)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2011-09-22  Anders Carlsson  <andersca@apple.com>
>+
>+        Widget::frameRect shouldn't be virtual
>+        https://bugs.webkit.org/show_bug.cgi?id=68637
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Nobody overrides Widget::frameRect and nobody should.
>+
>+        * platform/Widget.h:
>+
> 2011-09-22  Sergey Glazunov  <serg.glazunov@gmail.com>
> 
>         Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
>Index: Source/WebCore/platform/Widget.h
>===================================================================
>--- Source/WebCore/platform/Widget.h	(revision 95725)
>+++ Source/WebCore/platform/Widget.h	(working copy)
>@@ -149,7 +149,7 @@ public:
>     IntPoint location() const { return frameRect().location(); }
> 
>     virtual void setFrameRect(const IntRect&);
>-    virtual IntRect frameRect() const;
>+    IntRect frameRect() const;
>     IntRect boundsRect() const { return IntRect(0, 0, width(),  height()); }
> 
>     void resize(int w, int h) { setFrameRect(IntRect(x(), y(), w, h)); }

Flags:

sam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 68637: 108358