Attachment #94788 for bug #42697

View Details Raw Unified Return to Bug 42697



2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by NOBODY (OOPS!).

        WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42697

        Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetPrivateBrowsingEnabled):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
        * WebProcess/InjectedBundle/InjectedBundle.h:

2011-05-24  Timothy Hatcher  <timothy@apple.com>

        Make the Web Inspector bring the right window to the front when docked.

Lines 142-147 void InjectedBundle::setJavaScriptCanAcc Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp_sec1
- Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp +7 lines
142	(*iter)->settings()->setJavaScriptCanAccessClipboard(enabled);	142	(*iter)->settings()->setJavaScriptCanAccessClipboard(enabled);
143	}	143	}
144		144
		145	void InjectedBundle::setPrivateBrowsingEnabled(WebPageGroupProxy* pageGroup, bool enabled)
		146	{
		147	const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
		148	for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
		149	(*iter)->settings()->setPrivateBrowsingEnabled(enabled);
		150	}
		151
145	void InjectedBundle::addOriginAccessWhitelistEntry(const String& sourceOrigin, const String& destinationProtocol, const String& destinationHost, bool allowDestinationSubdomains)	152	void InjectedBundle::addOriginAccessWhitelistEntry(const String& sourceOrigin, const String& destinationProtocol, const String& destinationHost, bool allowDestinationSubdomains)
146	{	153	{
147	SecurityOrigin::addOriginAccessWhitelistEntry(*SecurityOrigin::createFromString(sourceOrigin), destinationProtocol, destinationHost, allowDestinationSubdomains);	154	SecurityOrigin::addOriginAccessWhitelistEntry(*SecurityOrigin::createFromString(sourceOrigin), destinationProtocol, destinationHost, allowDestinationSubdomains);

Lines 95-100 public: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h_sec1
- Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h +1 lines
95	void setAllowFileAccessFromFileURLs(WebPageGroupProxy*, bool);	95	void setAllowFileAccessFromFileURLs(WebPageGroupProxy*, bool);
96	void setFrameFlatteningEnabled(WebPageGroupProxy*, bool);	96	void setFrameFlatteningEnabled(WebPageGroupProxy*, bool);
97	void setJavaScriptCanAccessClipboard(WebPageGroupProxy*, bool);	97	void setJavaScriptCanAccessClipboard(WebPageGroupProxy*, bool);
		98	void setPrivateBrowsingEnabled(WebPageGroupProxy*, bool);
98	void addOriginAccessWhitelistEntry(const String&, const String&, const String&, bool);	99	void addOriginAccessWhitelistEntry(const String&, const String&, const String&, bool);
99	void removeOriginAccessWhitelistEntry(const String&, const String&, const String&, bool);	100	void removeOriginAccessWhitelistEntry(const String&, const String&, const String&, bool);
100	void resetOriginAccessWhitelists();	101	void resetOriginAccessWhitelists();

Lines 148-153 void WKBundleSetJavaScriptCanAccessClipb Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp_sec1
- Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp +5 lines
148	toImpl(bundleRef)->setJavaScriptCanAccessClipboard(toImpl(pageGroupRef), enabled);	148	toImpl(bundleRef)->setJavaScriptCanAccessClipboard(toImpl(pageGroupRef), enabled);
149	}	149	}
150		150
		151	void WKBundleSetPrivateBrowsingEnabled(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, bool enabled)
		152	{
		153	toImpl(bundleRef)->setPrivateBrowsingEnabled(toImpl(pageGroupRef), enabled);
		154	}
		155
151	void WKBundleAddOriginAccessWhitelistEntry(WKBundleRef bundleRef, WKStringRef sourceOrigin, WKStringRef destinationProtocol, WKStringRef destinationHost, bool allowDestinationSubdomains)	156	void WKBundleAddOriginAccessWhitelistEntry(WKBundleRef bundleRef, WKStringRef sourceOrigin, WKStringRef destinationProtocol, WKStringRef destinationHost, bool allowDestinationSubdomains)
152	{	157	{
153	toImpl(bundleRef)->addOriginAccessWhitelistEntry(toImpl(sourceOrigin)->string(), toImpl(destinationProtocol)->string(), toImpl(destinationHost)->string(), allowDestinationSubdomains);	158	toImpl(bundleRef)->addOriginAccessWhitelistEntry(toImpl(sourceOrigin)->string(), toImpl(destinationProtocol)->string(), toImpl(destinationHost)->string(), allowDestinationSubdomains);

Lines 69-74 WK_EXPORT void WKBundleSetAllowUniversal Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h_sec1
- Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h +1 lines
69	WK_EXPORT void WKBundleSetAllowFileAccessFromFileURLs(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);	69	WK_EXPORT void WKBundleSetAllowFileAccessFromFileURLs(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
70	WK_EXPORT void WKBundleSetFrameFlatteningEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);	70	WK_EXPORT void WKBundleSetFrameFlatteningEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
71	WK_EXPORT void WKBundleSetJavaScriptCanAccessClipboard(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);	71	WK_EXPORT void WKBundleSetJavaScriptCanAccessClipboard(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
		72	WK_EXPORT void WKBundleSetPrivateBrowsingEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
72	WK_EXPORT void WKBundleClearAllDatabases(WKBundleRef bundle);	73	WK_EXPORT void WKBundleClearAllDatabases(WKBundleRef bundle);
73	WK_EXPORT void WKBundleSetDatabaseQuota(WKBundleRef bundle, uint64_t);	74	WK_EXPORT void WKBundleSetDatabaseQuota(WKBundleRef bundle, uint64_t);
74	WK_EXPORT int WKBundleNumberOfPages(WKBundleRef bundle, WKBundleFrameRef frameRef, double pageWidthInPixels, double pageHeightInPixels);	75	WK_EXPORT int WKBundleNumberOfPages(WKBundleRef bundle, WKBundleFrameRef frameRef, double pageWidthInPixels, double pageHeightInPixels);



2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by NOBODY (OOPS!).

        WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42697

        Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::beginTesting):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::setPrivateBrowsingEnabled):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

Lines 179-184 void InjectedBundle::beginTesting() Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp_sec1
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp +1 lines
179	WKBundleRemoveAllVisitedLinks(m_bundle);	179	WKBundleRemoveAllVisitedLinks(m_bundle);
180	WKBundleSetAllowUniversalAccessFromFileURLs(m_bundle, m_pageGroup, true);	180	WKBundleSetAllowUniversalAccessFromFileURLs(m_bundle, m_pageGroup, true);
181	WKBundleSetJavaScriptCanAccessClipboard(m_bundle, m_pageGroup, true);	181	WKBundleSetJavaScriptCanAccessClipboard(m_bundle, m_pageGroup, true);
		182	WKBundleSetPrivateBrowsingEnabled(m_bundle, m_pageGroup, false);
182		183
183	WKBundleRemoveAllUserContent(m_bundle, m_pageGroup);	184	WKBundleRemoveAllUserContent(m_bundle, m_pageGroup);
184		185

Lines 344-349 void LayoutTestController::setJavaScript Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp_sec1
- Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp +5 lines
344	WKBundleSetJavaScriptCanAccessClipboard(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), enabled);	344	WKBundleSetJavaScriptCanAccessClipboard(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), enabled);
345	}	345	}
346		346
		347	void LayoutTestController::setPrivateBrowsingEnabled(bool enabled)
		348	{
		349	WKBundleSetPrivateBrowsingEnabled(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), enabled);
		350	}
		351
347	void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef destinationProtocol, JSStringRef destinationHost, bool allowDestinationSubdomains)	352	void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef destinationProtocol, JSStringRef destinationHost, bool allowDestinationSubdomains)
348	{	353	{
349	WKBundleAddOriginAccessWhitelistEntry(InjectedBundle::shared().bundle(), toWK(sourceOrigin).get(), toWK(destinationProtocol).get(), toWK(destinationHost).get(), allowDestinationSubdomains);	354	WKBundleAddOriginAccessWhitelistEntry(InjectedBundle::shared().bundle(), toWK(sourceOrigin).get(), toWK(destinationProtocol).get(), toWK(destinationHost).get(), allowDestinationSubdomains);

Lines 80-85 public: Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h_sec1
- Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h +1 lines
80	void setAllowFileAccessFromFileURLs(bool);	80	void setAllowFileAccessFromFileURLs(bool);
81	void setFrameFlatteningEnabled(bool);	81	void setFrameFlatteningEnabled(bool);
82	void setJavaScriptCanAccessClipboard(bool);	82	void setJavaScriptCanAccessClipboard(bool);
		83	void setPrivateBrowsingEnabled(bool);
83	void addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef destinationProtocol, JSStringRef destinationHost, bool allowDestinationSubdomains);	84	void addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef destinationProtocol, JSStringRef destinationHost, bool allowDestinationSubdomains);
84	void removeOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef destinationProtocol, JSStringRef destinationHost, bool allowDestinationSubdomains);	85	void removeOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef destinationProtocol, JSStringRef destinationHost, bool allowDestinationSubdomains);
85		86

Lines 51-56 module WTR { Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl_sec1
- Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl +1 lines
51	void setAllowFileAccessFromFileURLs(in boolean value);	51	void setAllowFileAccessFromFileURLs(in boolean value);
52	void setFrameFlatteningEnabled(in boolean value);	52	void setFrameFlatteningEnabled(in boolean value);
53	void setJavaScriptCanAccessClipboard(in boolean value);	53	void setJavaScriptCanAccessClipboard(in boolean value);
		54	void setPrivateBrowsingEnabled(in boolean value);
54	void addOriginAccessWhitelistEntry(in DOMString sourceOrigin, in DOMString destinationProtocol, in DOMString destinationHost, in boolean allowDestinationSubdomains);	55	void addOriginAccessWhitelistEntry(in DOMString sourceOrigin, in DOMString destinationProtocol, in DOMString destinationHost, in boolean allowDestinationSubdomains);
55	void removeOriginAccessWhitelistEntry(in DOMString sourceOrigin, in DOMString destinationProtocol, in DOMString destinationHost, in boolean allowDestinationSubdomains);	56	void removeOriginAccessWhitelistEntry(in DOMString sourceOrigin, in DOMString destinationProtocol, in DOMString destinationHost, in boolean allowDestinationSubdomains);
56		57



2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by NOBODY (OOPS!).

        WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42697

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:

2011-05-25  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Skipped 3 new inspector tests that time out on gtk.



# <https://bugs.webkit.org/show_bug.cgi?id=42696>
security/set-form-autocomplete-attribute.html

# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
# <https://bugs.webkit.org/show_bug.cgi?id=42697>
storage/domstorage/localstorage/private-browsing-affects-storage.html
storage/domstorage/sessionstorage/private-browsing-affects-storage.html
storage/private-browsing-noread-nowrite.html

# WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
# <https://bugs.webkit.org/show_bug.cgi?id=42698>
http/tests/appcache/max-size.html



# <https://bugs.webkit.org/show_bug.cgi?id=42696>
security/set-form-autocomplete-attribute.html

# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
# <https://bugs.webkit.org/show_bug.cgi?id=42697>
storage/domstorage/localstorage/private-browsing-affects-storage.html
storage/domstorage/sessionstorage/private-browsing-affects-storage.html

# WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
# <https://bugs.webkit.org/show_bug.cgi?id=42698>
http/tests/appcache/max-size.html

sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7.html
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7.html
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7.html
storage/private-browsing-noread-nowrite.html
svg/animations/animate-calcMode-spline-by.html
svg/animations/animate-calcMode-spline-from-by.html
svg/animations/animate-calcMode-spline-from-to.html

Return to Bug 42697

Lines 1378-1389 printing/simultaneous-position-float-cha LayoutTests/platform/mac-wk2/Skipped_sec1
- LayoutTests/platform/mac-wk2/Skipped -6 lines
1378	# <https://bugs.webkit.org/show_bug.cgi?id=42696>	1378	# <https://bugs.webkit.org/show_bug.cgi?id=42696>
1379	security/set-form-autocomplete-attribute.html	1379	security/set-form-autocomplete-attribute.html
1380		1380
1381	# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1382	# <https://bugs.webkit.org/show_bug.cgi?id=42697>
1383	storage/domstorage/localstorage/private-browsing-affects-storage.html
1384	storage/domstorage/sessionstorage/private-browsing-affects-storage.html
1385	storage/private-browsing-noread-nowrite.html
1386
1387	# WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize	1381	# WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
1388	# <https://bugs.webkit.org/show_bug.cgi?id=42698>	1382	# <https://bugs.webkit.org/show_bug.cgi?id=42698>
1389	http/tests/appcache/max-size.html	1383	http/tests/appcache/max-size.html

Lines 1-3 Source/WebKit2/ChangeLog_sec1
- Source/WebKit2/ChangeLog +16 lines
		1	2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
		6	https://bugs.webkit.org/show_bug.cgi?id=42697
		7
		8	Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
		9
		10	* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
		11	(WKBundleSetPrivateBrowsingEnabled):
		12	* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
		13	* WebProcess/InjectedBundle/InjectedBundle.cpp:
		14	(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
		15	* WebProcess/InjectedBundle/InjectedBundle.h:
		16
1	2011-05-24 Timothy Hatcher <timothy@apple.com>	17	2011-05-24 Timothy Hatcher <timothy@apple.com>
2		18
3	Make the Web Inspector bring the right window to the front when docked.	19	Make the Web Inspector bring the right window to the front when docked.

Lines 1-3 Tools/ChangeLog_sec1
- Tools/ChangeLog +16 lines
		1	2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
		6	https://bugs.webkit.org/show_bug.cgi?id=42697
		7
		8	Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
		9
		10	* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
		11	* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
		12	(WTR::InjectedBundle::beginTesting):
		13	* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
		14	(WTR::LayoutTestController::setPrivateBrowsingEnabled):
		15	* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
		16
1	2011-05-24 Keishi Hattori <keishi@webkit.org>	17	2011-05-24 Keishi Hattori <keishi@webkit.org>
2		18
3	Reviewed by Kent Tamura.	19	Reviewed by Kent Tamura.

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +10 lines
		1	2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
		6	https://bugs.webkit.org/show_bug.cgi?id=42697
		7
		8	* platform/mac-wk2/Skipped:
		9	* platform/qt-wk2/Skipped:
		10
1	2011-05-25 Andrey Kosyakov <caseq@chromium.org>	11	2011-05-25 Andrey Kosyakov <caseq@chromium.org>
2		12
3	Unreviewed. Skipped 3 new inspector tests that time out on gtk.	13	Unreviewed. Skipped 3 new inspector tests that time out on gtk.

Lines 1773-1783 printing/setPrinting.html LayoutTests/platform/qt-wk2/Skipped_sec1
- LayoutTests/platform/qt-wk2/Skipped -6 lines
1773	# <https://bugs.webkit.org/show_bug.cgi?id=42696>	1773	# <https://bugs.webkit.org/show_bug.cgi?id=42696>
1774	security/set-form-autocomplete-attribute.html	1774	security/set-form-autocomplete-attribute.html
1775		1775
1776	# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1777	# <https://bugs.webkit.org/show_bug.cgi?id=42697>
1778	storage/domstorage/localstorage/private-browsing-affects-storage.html
1779	storage/domstorage/sessionstorage/private-browsing-affects-storage.html
1780
1781	# WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize	1776	# WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
1782	# <https://bugs.webkit.org/show_bug.cgi?id=42698>	1777	# <https://bugs.webkit.org/show_bug.cgi?id=42698>
1783	http/tests/appcache/max-size.html	1778	http/tests/appcache/max-size.html
Lines 2866-2872 sputnik/Conformance/15_Native_Objects/15 LayoutTests/platform/qt-wk2/Skipped_sec2
2866	sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7.html	2861	sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7.html
2867	sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7.html	2862	sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7.html
2868	sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7.html	2863	sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7.html
2869	storage/private-browsing-noread-nowrite.html
2870	svg/animations/animate-calcMode-spline-by.html	2864	svg/animations/animate-calcMode-spline-by.html
2871	svg/animations/animate-calcMode-spline-from-by.html	2865	svg/animations/animate-calcMode-spline-from-by.html
2872	svg/animations/animate-calcMode-spline-from-to.html	2866	svg/animations/animate-calcMode-spline-from-to.html