Attachment #83730 for bug #54573

View Details Raw Unified Return to Bug 54573

| Differences between



2011-02-24  Levi Weintraub  <leviw@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Root element should establish a new block formatting context
        https://bugs.webkit.org/show_bug.cgi?id=54573

        Always expanding the root renderer to include overhanging floats.

        Test: fast/block/float/float-overhangs-root.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):

2011-02-24  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

Lines 1407-1413 void RenderBlock::addOverflowFromPositio Source/WebCore/rendering/RenderBlock.cpp_sec1
- Source/WebCore/rendering/RenderBlock.cpp -1 / +1 lines
1407	bool RenderBlock::expandsToEncloseOverhangingFloats() const	1407	bool RenderBlock::expandsToEncloseOverhangingFloats() const
1408	{	1408	{
1409	return isInlineBlockOrInlineTable() \|\| isFloatingOrPositioned() \|\| hasOverflowClip() \|\| (parent() && parent()->isFlexibleBox())	1409	return isInlineBlockOrInlineTable() \|\| isFloatingOrPositioned() \|\| hasOverflowClip() \|\| (parent() && parent()->isFlexibleBox())
1410	\|\| hasColumns() \|\| isTableCell() \|\| isFieldset() \|\| isWritingModeRoot();	1410	\|\| hasColumns() \|\| isTableCell() \|\| isFieldset() \|\| isWritingModeRoot() \|\| isRoot();
1411	}	1411	}
1412		1412
1413	void RenderBlock::adjustPositionedBlock(RenderBox* child, const MarginInfo& marginInfo)	1413	void RenderBlock::adjustPositionedBlock(RenderBox* child, const MarginInfo& marginInfo)



2011-02-24  Levi Weintraub  <leviw@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Root element should establish a new block formatting context
        https://bugs.webkit.org/show_bug.cgi?id=54573

        Always expanding the root render object to enclose overhanging floats.

        * fast/block/float/float-overhangs-root.html: Added.
        * platform/mac/fast/block/float/float-overhangs-root-expected.checksum: Added.
        * platform/mac/fast/block/float/float-overhangs-root-expected.png: Added.
        * platform/mac/fast/block/float/float-overhangs-root-expected.txt: Added.

2011-02-24  Victoria Kirst  <vrk@google.com>

        Reviewed by Mihai Parparita.

Line 0 LayoutTests/fast/block/float/float-overhangs-root.html_sec1
- LayoutTests/fast/block/float/float-overhangs-root.html +6 lines
	1	<!DOCTYPE html>
	2	<style>
	3	html { border: solid blue; }
	4	.float { float: left; height: 350px; border: solid orange; }
	5	</style>
	6	<div class="float"></div>

Line 0 LayoutTests/platform/mac/fast/block/float/float-overhangs-root-expected.checksum_sec1
- LayoutTests/platform/mac/fast/block/float/float-overhangs-root-expected.checksum +1 lines
		1	3f3847db5fad4d81db4ba9e3c66071c5

Line 0 LayoutTests/platform/mac/fast/block/float/float-overhangs-root-expected.txt_sec1
- LayoutTests/platform/mac/fast/block/float/float-overhangs-root-expected.txt +6 lines
	1	layer at (0,0) size 800x600
	2	RenderView at (0,0) size 800x600
	3	layer at (0,0) size 800x370
	4	RenderBlock {HTML} at (0,0) size 800x370 [border: (3px solid #0000FF)]
	5	RenderBody {BODY} at (11,11) size 778x0
	6	RenderBlock (floating) {DIV} at (0,0) size 6x356 [border: (3px solid #FFA500)]

Return to Bug 54573

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +14 lines
		1	2011-02-24 Levi Weintraub <leviw@chromium.org>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Root element should establish a new block formatting context
		6	https://bugs.webkit.org/show_bug.cgi?id=54573
		7
		8	Always expanding the root renderer to include overhanging floats.
		9
		10	Test: fast/block/float/float-overhangs-root.html
		11
		12	* rendering/RenderBlock.cpp:
		13	(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
		14
1	2011-02-24 Dan Bernstein <mitz@apple.com>	15	2011-02-24 Dan Bernstein <mitz@apple.com>
2		16
3	Reviewed by Dave Hyatt.	17	Reviewed by Dave Hyatt.

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +14 lines
		1	2011-02-24 Levi Weintraub <leviw@chromium.org>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Root element should establish a new block formatting context
		6	https://bugs.webkit.org/show_bug.cgi?id=54573
		7
		8	Always expanding the root render object to enclose overhanging floats.
		9
		10	* fast/block/float/float-overhangs-root.html: Added.
		11	* platform/mac/fast/block/float/float-overhangs-root-expected.checksum: Added.
		12	* platform/mac/fast/block/float/float-overhangs-root-expected.png: Added.
		13	* platform/mac/fast/block/float/float-overhangs-root-expected.txt: Added.
		14
1	2011-02-24 Victoria Kirst <vrk@google.com>	15	2011-02-24 Victoria Kirst <vrk@google.com>
2		16
3	Reviewed by Mihai Parparita.	17	Reviewed by Mihai Parparita.