Attachment #80171 for bug #53160

View Details Raw Unified Return to Bug 53160

| Differences between



2011-01-25  Ilya Sherman  <isherman@chromium.org>

        Reviewed by NOBODY (OOPS!).

        HTMLInputElement::setValue() should schedule change event when the element is focused
        In service of https://code.google.com/p/chromium/issues/detail?id=42716
        https://bugs.webkit.org/show_bug.cgi?id=53160

        No new tests. (OOPS!)

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue):
            For a focused text field, tell the renderer that the value has changed since the last change event.

2011-01-25  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

Lines 888-897 void HTMLInputElement::setValue(const String& value, bool sendChangeEvent) a/Source/WebCore/html/HTMLInputElement.cpp_sec1
- a/Source/WebCore/html/HTMLInputElement.cpp -4 / +8 lines
888	m_data.setSuggestedValue(String());	888	m_data.setSuggestedValue(String());
889	}	889	}
890		890
891	// Don't dispatch the change event when focused, it will be dispatched	891	if (sendChangeEvent) {
892	// when the control loses focus.	892	// Don't dispatch the change event when focused, it will be dispatched
893	if (sendChangeEvent && document()->focusedNode() != this)	893	// when the control loses focus.
894	dispatchFormControlChangeEvent();	894	if (document()->focusedNode() != this)
		895	dispatchFormControlChangeEvent();
		896	else if (isTextField())
		897	toRenderTextControl(renderer())->setChangedSinceLastChangeEvent(true);
		898	}
895		899
896	InputElement::notifyFormStateChanged(this);	900	InputElement::notifyFormStateChanged(this);
897	}	901	}

Return to Bug 53160

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +14 lines
		1	2011-01-25 Ilya Sherman <isherman@chromium.org>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	HTMLInputElement::setValue() should schedule change event when the element is focused
		6	In service of https://code.google.com/p/chromium/issues/detail?id=42716
		7	https://bugs.webkit.org/show_bug.cgi?id=53160
		8
		9	No new tests. (OOPS!)
		10
		11	* html/HTMLInputElement.cpp:
		12	(WebCore::HTMLInputElement::setValue):
		13	For a focused text field, tell the renderer that the value has changed since the last change event.
		14
1	2011-01-25 Sam Weinig <sam@webkit.org>	15	2011-01-25 Sam Weinig <sam@webkit.org>
2		16
3	Reviewed by David Hyatt.	17	Reviewed by David Hyatt.