Attachment #70055 for bug #47329

View Details Raw Unified Return to Bug 47329



2010-10-07  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Chromium multi-dll build broken due to WebResourceRawHeaders methods lacking WEBKIT_API decl spec
        https://bugs.webkit.org/show_bug.cgi?id=47329

        * public/WebResourceRawHeaders.h:
        (WebKit::WebResourceRawHeaders::WebResourceRawHeaders):
        (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders):
        (WebKit::WebResourceRawHeaders::operator =):
        * src/WebResourceRawHeaders.cpp:
        (WebKit::WebResourceRawHeaders::initialize):
        (WebKit::WebResourceRawHeaders::reset):
        (WebKit::WebResourceRawHeaders::assign):

2010-10-06  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

Lines 45-55 class WebString; a/WebKit/chromium/public/WebResourceRawHeaders.h_sec1
- a/WebKit/chromium/public/WebResourceRawHeaders.h -4 / +13 lines
45		45
46	class WebResourceRawHeaders {	46	class WebResourceRawHeaders {
47	public:	47	public:
48	WebResourceRawHeaders();	48	WebResourceRawHeaders() { initialize(); }
49	~WebResourceRawHeaders();	49	~WebResourceRawHeaders() { reset(); }
		50	WebResourceRawHeaders(const WebResourceRawHeaders& r) { assign(r); }
		51	WebResourceRawHeaders& operator =(const WebResourceRawHeaders& r)
		52	{
		53	assign(r);
		54	return *this;
		55	}
50		56
51	void addRequestHeader(const WebString& name, const WebString& value);	57	WEBKIT_API void initialize();
52	void addResponseHeader(const WebString& name, const WebString& value);	58	WEBKIT_API void reset();
		59	WEBKIT_API void assign(const WebResourceRawHeaders& r);
		60	WEBKIT_API void addRequestHeader(const WebString& name, const WebString& value);
		61	WEBKIT_API void addResponseHeader(const WebString& name, const WebString& value);
53		62
54	#if WEBKIT_IMPLEMENTATION	63	#if WEBKIT_IMPLEMENTATION
55	WebResourceRawHeaders(WTF::PassRefPtr<WebCore::ResourceRawHeaders>);	64	WebResourceRawHeaders(WTF::PassRefPtr<WebCore::ResourceRawHeaders>);




namespace WebKit {

void WebResourceRawHeaders::initialize()
{
    m_private = adoptRef(new ResourceRawHeaders());
}

void WebResourceRawHeaders::reset()
{
    m_private.reset();
}

void WebResourceRawHeaders::assign(const WebResourceRawHeaders& r)
{
    m_private = r.m_private;
}

WebResourceRawHeaders::WebResourceRawHeaders(WTF::PassRefPtr<WebCore::ResourceRawHeaders> value)
{
    m_private = value;

Return to Bug 47329

Lines 1-3 a/WebKit/chromium/ChangeLog_sec1
- a/WebKit/chromium/ChangeLog +16 lines
		1	2010-10-07 Andrey Kosyakov <caseq@chromium.org>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Chromium multi-dll build broken due to WebResourceRawHeaders methods lacking WEBKIT_API decl spec
		6	https://bugs.webkit.org/show_bug.cgi?id=47329
		7
		8	* public/WebResourceRawHeaders.h:
		9	(WebKit::WebResourceRawHeaders::WebResourceRawHeaders):
		10	(WebKit::WebResourceRawHeaders::~WebResourceRawHeaders):
		11	(WebKit::WebResourceRawHeaders::operator =):
		12	* src/WebResourceRawHeaders.cpp:
		13	(WebKit::WebResourceRawHeaders::initialize):
		14	(WebKit::WebResourceRawHeaders::reset):
		15	(WebKit::WebResourceRawHeaders::assign):
		16
1	2010-10-06 Chris Guillory <chris.guillory@google.com>	17	2010-10-06 Chris Guillory <chris.guillory@google.com>
2		18
3	Reviewed by Chris Fleizach.	19	Reviewed by Chris Fleizach.

Lines 40-55 using namespace WebCore; a/WebKit/chromium/src/WebResourceRawHeaders.cpp_sec1
- a/WebKit/chromium/src/WebResourceRawHeaders.cpp -2 / +7 lines
40		40
41	namespace WebKit {	41	namespace WebKit {
42		42
43	WebResourceRawHeaders::WebResourceRawHeaders()	43	void WebResourceRawHeaders::initialize()
44	{	44	{
45	m_private = adoptRef(new ResourceRawHeaders());	45	m_private = adoptRef(new ResourceRawHeaders());
46	}	46	}
47		47
48	WebResourceRawHeaders::~WebResourceRawHeaders()	48	void WebResourceRawHeaders::reset()
49	{	49	{
50	m_private.reset();	50	m_private.reset();
51	}	51	}
52		52
		53	void WebResourceRawHeaders::assign(const WebResourceRawHeaders& r)
		54	{
		55	m_private = r.m_private;
		56	}
		57
53	WebResourceRawHeaders::WebResourceRawHeaders(WTF::PassRefPtr<WebCore::ResourceRawHeaders> value)	58	WebResourceRawHeaders::WebResourceRawHeaders(WTF::PassRefPtr<WebCore::ResourceRawHeaders> value)
54	{	59	{
55	m_private = value;	60	m_private = value;