Attachment #63921 for bug #43742

View Details Raw Unified Return to Bug 43742

| Differences between



2010-08-09  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by NOBODY (OOPS!).

        Fast-path for array lookup with double subscript
        https://bugs.webkit.org/show_bug.cgi?id=43742

        Added fast-path in op_get_by_val for JSArrays when the subscript isDouble().

        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):

2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64938.

Lines 2285-2290 DEFINE_STUB_FUNCTION(EncodedJSValue, op_get_by_val) a/JavaScriptCore/jit/JITStubs.cpp_sec1
- a/JavaScriptCore/jit/JITStubs.cpp +9 lines
2285	CHECK_FOR_EXCEPTION();	2285	CHECK_FOR_EXCEPTION();
2286	return JSValue::encode(result);	2286	return JSValue::encode(result);
2287	}	2287	}
		2288
		2289	if (subscript.isDouble() && isJSArray(globalData, baseValue)) {
		2290	double d = subscript.asDouble();
		2291	if (d >= 0 && d <= UINT_MAX) {
		2292	uint32_t i = subscript.toUInt32(callFrame);
		2293	if (asArray(baseValue)->canGetIndex(i))
		2294	return JSValue::encode(asArray(baseValue)->getIndex(i));
		2295	}
		2296	}
2288		2297
2289	Identifier property(callFrame, subscript.toString(callFrame));	2298	Identifier property(callFrame, subscript.toString(callFrame));
2290	JSValue result = baseValue.get(callFrame, property);	2299	JSValue result = baseValue.get(callFrame, property);

Return to Bug 43742

Lines 1-3 a/JavaScriptCore/ChangeLog_sec1
- a/JavaScriptCore/ChangeLog +12 lines
		1	2010-08-09 Andreas Kling <andreas.kling@nokia.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Fast-path for array lookup with double subscript
		6	https://bugs.webkit.org/show_bug.cgi?id=43742
		7
		8	Added fast-path in op_get_by_val for JSArrays when the subscript isDouble().
		9
		10	* jit/JITStubs.cpp:
		11	(JSC::DEFINE_STUB_FUNCTION):
		12
1	2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>	13	2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
2		14
3	Unreviewed, rolling out r64938.	15	Unreviewed, rolling out r64938.