Attachment #396760 for bug #209964

View Details Raw Unified Return to Bug 209964

| Differences between



2020-04-17  Paulo Matos  <pmatos@igalia.com>

        Re-enable previously skipped mips tests
        https://bugs.webkit.org/show_bug.cgi?id=209964

        Reviewed by NOBODY (OOPS!).

        Followup to r259454 - where we re-enabled a few stress tests for arm.

        * stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
        * stress/dont-range-based-iterate-vector-that-is-mutated.js:
        * stress/ensure-code-block-is-not-precise-allocation.js:
        * stress/generator-cell-with-type.js:
        * stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
        * stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
        * stress/toctou-having-a-bad-time-new-array.js:

2020-04-16  Ross Kirsling  <ross.kirsling@sony.com>

        REGRESSION(r259480): Two new failing i18n tests

Lines 1-4 a/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js_sec1
- a/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js -1 lines
1	//@ skip if ["mips"].include?($architecture)
2	//@ slow!	1	//@ slow!
3	//@ runDefault("--jitPolicyScale=0")	2	//@ runDefault("--jitPolicyScale=0")
4		3

Lines 1-4 a/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js_sec1
- a/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js -1 lines
1	//@ skip if not $jitTests and $architecture =~ /mips/ and $hostOS == "linux"
2	// Should not crash when run with ASAN.	1	// Should not crash when run with ASAN.
3		2
4	function foo(arr1, arr2) {	3	function foo(arr1, arr2) {

Lines 1-4 a/JSTests/stress/ensure-code-block-is-not-precise-allocation.js_sec1
- a/JSTests/stress/ensure-code-block-is-not-precise-allocation.js -1 / +1 lines
1	//@ if $architecture == "mips" then skip else slow! end	1	//@ slow!
2	// Does not crash.	2	// Does not crash.
3	function foo() {	3	function foo() {
4	+new Proxy({}, {get: foo});	4	+new Proxy({}, {get: foo});

Lines 1-5 a/JSTests/stress/generator-cell-with-type.js_sec1
- a/JSTests/stress/generator-cell-with-type.js -3 / +6 lines
1	// This test takes too long on mips devices.	1	// This test takes too long on mips devices.
2	//@ skip if ["mips"].include?($architecture)	2	//@ requireOptions("-e", "let iterations=1e5") if ["mips"].include?($architecture)
		3
		4	iterations = typeof(iterations) === 'undefined' ? 1e6 : iterations;
		5
3	function shouldBe(actual, expected) {	6	function shouldBe(actual, expected) {
4	if (actual !== expected)	7	if (actual !== expected)
5	throw new Error('bad value: ' + actual);	8	throw new Error('bad value: ' + actual);
Lines 32-41 function test(gen) a/JSTests/stress/generator-cell-with-type.js_sec2
32	}	35	}
33	noInline(test);	36	noInline(test);
34	var gen = generator();	37	var gen = generator();
35	for (var i = 0; i < 1e6; ++i)	38	for (var i = 0; i < iterations; ++i)
36	test(gen);	39	test(gen);
37		40
38	for (var i = 0; i < 1e6; ++i) {	41	for (var i = 0; i < iterations; ++i) {
39	test(gen);	42	test(gen);
40	shouldThrow(() => {	43	shouldThrow(() => {
41	test({	44	test({

Lines 1-5 a/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js_sec1
- a/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js -1 lines
1	//@ requireOptions("--jitPolicyScale=0")	1	//@ requireOptions("--jitPolicyScale=0")
2	//@ skip if ["mips"].include?($architecture)
3	//@ slow!	2	//@ slow!
4		3
5	for (let j = 0; j < 500; j++) {	4	for (let j = 0; j < 500; j++) {

Lines 1-4 a/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js_sec1
- a/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js -1 / +1 lines
1	//@ skip if $buildType == "debug" \|\| ["mips"].include?($architecture)	1	//@ skip if $buildType == "debug"
2	//@ slow!	2	//@ slow!
3	//@ runDefault("--collectContinuously=1", "--slowPathAllocsBetweenGCs=100")	3	//@ runDefault("--collectContinuously=1", "--slowPathAllocsBetweenGCs=100")
4		4

Lines 1-4 a/JSTests/stress/toctou-having-a-bad-time-new-array.js_sec1
- a/JSTests/stress/toctou-having-a-bad-time-new-array.js -1 / +1 lines
1	//@ skip if $buildType == "debug" or ["mips"].include?($architecture)	1	//@ skip if $buildType == "debug"
2		2
3	let code = `	3	let code = `
4	function foo() {	4	function foo() {

Return to Bug 209964

Lines 1-3 a/JSTests/ChangeLog_sec1
- a/JSTests/ChangeLog +17 lines
		1	2020-04-17 Paulo Matos <pmatos@igalia.com>
		2
		3	Re-enable previously skipped mips tests
		4	https://bugs.webkit.org/show_bug.cgi?id=209964
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Followup to r259454 - where we re-enabled a few stress tests for arm.
		9
		10	* stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
		11	* stress/dont-range-based-iterate-vector-that-is-mutated.js:
		12	* stress/ensure-code-block-is-not-precise-allocation.js:
		13	* stress/generator-cell-with-type.js:
		14	* stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
		15	* stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
		16	* stress/toctou-having-a-bad-time-new-array.js:
		17
1	2020-04-16 Ross Kirsling <ross.kirsling@sony.com>	18	2020-04-16 Ross Kirsling <ross.kirsling@sony.com>
2		19
3	REGRESSION(r259480): Two new failing i18n tests	20	REGRESSION(r259480): Two new failing i18n tests