Attachment #389470 for bug #207097

View Details Raw Unified Return to Bug 207097

| Differences between



2020-02-02  Pablo Saavedra  <psaavedra@igalia.com>

        Build error with -DENABLE_VIDEO_TRACK=OFF after r255151
        https://bugs.webkit.org/show_bug.cgi?id=207097

        Reviewed by NOBODY (OOPS!).

        No new tests, only build error fix up

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::selectorText const):

2020-02-01  Michael Catanzaro  <mcatanzaro@gnome.org>

        Silence compiler warnings



                if (cs->value() == "placeholder")
                    builder.appendLiteral("::-webkit-input-placeholder");
                break;
#if ENABLE(VIDEO_TRACK)
            case CSSSelector::PseudoElementCue: {
                if (auto* selectorList = cs->selectorList()) {
                    builder.appendLiteral("::cue(");

                    builder.appendLiteral("::cue");
                break;
            }
#endif
            default:
                builder.appendLiteral("::");
                builder.append(cs->serializingValue());

Return to Bug 207097

Lines 736-741 String CSSSelector::selectorText(const String& rightSide) const a/Source/WebCore/css/CSSSelector.cpp_sec1
- a/Source/WebCore/css/CSSSelector.cpp +2 lines
736	if (cs->value() == "placeholder")	736	if (cs->value() == "placeholder")
737	builder.appendLiteral("::-webkit-input-placeholder");	737	builder.appendLiteral("::-webkit-input-placeholder");
738	break;	738	break;
		739	#if ENABLE(VIDEO_TRACK)
739	case CSSSelector::PseudoElementCue: {	740	case CSSSelector::PseudoElementCue: {
740	if (auto* selectorList = cs->selectorList()) {	741	if (auto* selectorList = cs->selectorList()) {
741	builder.appendLiteral("::cue(");	742	builder.appendLiteral("::cue(");
Lines 745-750 String CSSSelector::selectorText(const String& rightSide) const a/Source/WebCore/css/CSSSelector.cpp_sec2
745	builder.appendLiteral("::cue");	746	builder.appendLiteral("::cue");
746	break;	747	break;
747	}	748	}
		749	#endif
748	default:	750	default:
749	builder.appendLiteral("::");	751	builder.appendLiteral("::");
750	builder.append(cs->serializingValue());	752	builder.append(cs->serializingValue());

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +12 lines
		1	2020-02-02 Pablo Saavedra <psaavedra@igalia.com>
		2
		3	Build error with -DENABLE_VIDEO_TRACK=OFF after r255151
		4	https://bugs.webkit.org/show_bug.cgi?id=207097
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	No new tests, only build error fix up
		9
		10	* css/CSSSelector.cpp:
		11	(WebCore::CSSSelector::selectorText const):
		12
1	2020-02-01 Michael Catanzaro <mcatanzaro@gnome.org>	13	2020-02-01 Michael Catanzaro <mcatanzaro@gnome.org>
2		14
3	Silence compiler warnings	15	Silence compiler warnings