Attachment #359806 for bug #193690

View Details Raw Unified Return to Bug 193690

| Differences between



2019-01-22  Simon Fraser  <simon.fraser@apple.com>

        Make scrollingcoordinator tests only run on iOS/macOS WK2
        https://bugs.webkit.org/show_bug.cgi?id=193690

        Reviewed by NOBODY (OOPS!).
        
        scrollingcoordinator is only active in WK2, and both WPE and WinCairo skip this directory
        already, so skip it at the top level, and re-enable for mac-wk2 and ios-wk2.

        Add some iOS results for two tests.

        Also do some cleanup after tiled-drawing/ios was removed on 1/18.

        * TestExpectations:
        * platform/ios-device/TestExpectations:
        * platform/ios-wk2/TestExpectations:
        * platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
        * platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
        * platform/ios/TestExpectations:
        * platform/mac-wk2/TestExpectations:

2019-01-22  Simon Fraser  <simon.fraser@apple.com>

        Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results

Lines 39-45 fast/events/touch/ios [ Skip ] a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations -1 / +1 lines
39	fast/history/ios [ Skip ]	39	fast/history/ios [ Skip ]
40	fast/scrolling/ios [ Skip ]	40	fast/scrolling/ios [ Skip ]
41	fast/text/mac [ Skip ]	41	fast/text/mac [ Skip ]
42	scrollingcoordinator/ios [ Skip ]	42	scrollingcoordinator [ Skip ]
43	fast/content-observation [ Skip ]	43	fast/content-observation [ Skip ]
44	media/mac [ Skip ]	44	media/mac [ Skip ]
45	media/ios [ Skip ]	45	media/ios [ Skip ]




svg/custom/pattern-reference.svg [ Crash ]

tiled-drawing/ios/iphone7/compositing-layers-deep-color.html [ Failure ]

quicklook/numbers.html [ ImageOnlyFailure ]

scrollbars/overflow-scrollbar-combinations.html [ Timeout ]

security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ ImageOnlyFailure ]

# <https://bugs.webkit.org/show_bug.cgi?id=175987> Manage tests which require different device types better
tiled-drawing/ios/iphone7
fast/forms/ios/ipad
fast/events/touch/ios/iphone7




fast/scrolling/ios [ Pass ]
fast/viewport/ios [ Pass ]
fast/visual-viewport/ios/ [ Pass ]
scrollingcoordinator [ Pass ]
tiled-drawing/ios [ Pass ]
fast/web-share [ Pass ]
editing/find [ Pass ]
editing/input/ios [ Pass ]

fast/events/context-activated-by-key-event.html [ Skip ]

webkit.org/b/168924 scrollingcoordinator/ios/non-stable-viewport-scroll.html [ Pass Failure ]
webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]

webkit.org/b/169640 imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html [ Failure ]



webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ]

webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]

webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]

webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]



layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x8
  RenderBlock {HTML} at (0,0) size 800x8
    RenderBody {BODY} at (8,8) size 784x0
layer at (50,50) size 324x224
  RenderIFrame {IFRAME} at (50,50) size 324x224 [border: (2px inset #000000)]
    layer at (0,0) size 1008x1016
      RenderView at (0,0) size 300x200
    layer at (0,0) size 300x1016
      RenderBlock {HTML} at (0,0) size 300x1016
        RenderBody {BODY} at (8,8) size 1000x1000



layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x8
  RenderBlock {HTML} at (0,0) size 800x8
    RenderBody {BODY} at (8,8) size 784x0
layer at (200,150) size 324x224
  RenderIFrame {IFRAME} at (200,150) size 324x224 [border: (2px inset #000000)]
    layer at (0,0) size 1008x1016
      RenderView at (0,0) size 300x200
    layer at (0,0) size 300x1016
      RenderBlock {HTML} at (0,0) size 300x1016
        RenderBody {BODY} at (8,8) size 1000x1000



transforms/3d/point-mapping/3d-point-mapping-3.html [ Failure ]
transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ]

# Scrolling coordinator tests that fail:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ]
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure ]

# Userscript tests that fail:
userscripts/user-script-plugin-document.html [ Failure ]




# Platform-specific directories. Skipped globally, then re-enabled here.
#//////////////////////////////////////////////////////////////////////////////////////////

tiled-drawing [ Pass ]
tiled-drawing/ios [ Skip ]
fast/visual-viewport/tiled-drawing [ Pass ]
swipe [ Pass ]
fast/web-share [ Pass ]
editing/find [ Pass ]
editing/undo-manager [ Pass ]
fast/visual-viewport/tiled-drawing [ Pass ]
fast/web-share [ Pass ]
scrollingcoordinator [ Pass ]
scrollingcoordinator/ios [ Skip ]
swipe [ Pass ]
tiled-drawing [ Pass ]

fast/events/autoscroll-when-zoomed.html [ Pass ]
fast/events/autoscroll-main-document.html [ Pass ]

Return to Bug 193690

Lines 120-127 media/invalid-media-url-crash.html [ Crash ] a/LayoutTests/platform/ios-device/TestExpectations_sec1
- a/LayoutTests/platform/ios-device/TestExpectations -3 lines
120		120
121	svg/custom/pattern-reference.svg [ Crash ]	121	svg/custom/pattern-reference.svg [ Crash ]
122		122
123	tiled-drawing/ios/iphone7/compositing-layers-deep-color.html [ Failure ]
124
125	quicklook/numbers.html [ ImageOnlyFailure ]	123	quicklook/numbers.html [ ImageOnlyFailure ]
126		124
127	scrollbars/overflow-scrollbar-combinations.html [ Timeout ]	125	scrollbars/overflow-scrollbar-combinations.html [ Timeout ]
Lines 131-137 security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.htm a/LayoutTests/platform/ios-device/TestExpectations_sec2
131	security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ ImageOnlyFailure ]	129	security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ ImageOnlyFailure ]
132		130
133	# <https://bugs.webkit.org/show_bug.cgi?id=175987> Manage tests which require different device types better	131	# <https://bugs.webkit.org/show_bug.cgi?id=175987> Manage tests which require different device types better
134	tiled-drawing/ios/iphone7
135	fast/forms/ios/ipad	132	fast/forms/ios/ipad
136	fast/events/touch/ios/iphone7	133	fast/events/touch/ios/iphone7
137		134

Lines 11-18 fast/history/ios [ Pass ] a/LayoutTests/platform/ios-wk2/TestExpectations_sec1
- a/LayoutTests/platform/ios-wk2/TestExpectations -4 / +2 lines
11	fast/scrolling/ios [ Pass ]	11	fast/scrolling/ios [ Pass ]
12	fast/viewport/ios [ Pass ]	12	fast/viewport/ios [ Pass ]
13	fast/visual-viewport/ios/ [ Pass ]	13	fast/visual-viewport/ios/ [ Pass ]
14	scrollingcoordinator/ios [ Pass ]	14	scrollingcoordinator [ Pass ]
15	tiled-drawing/ios [ Pass ]
16	fast/web-share [ Pass ]	15	fast/web-share [ Pass ]
17	editing/find [ Pass ]	16	editing/find [ Pass ]
18	editing/input/ios [ Pass ]	17	editing/input/ios [ Pass ]
Lines 1190-1195 fast/css/deferred-parsing/hover-test.html [ Skip ] a/LayoutTests/platform/ios-wk2/TestExpectations_sec2
1190	fast/events/context-activated-by-key-event.html [ Skip ]	1189	fast/events/context-activated-by-key-event.html [ Skip ]
1191		1190
1192	webkit.org/b/168924 scrollingcoordinator/ios/non-stable-viewport-scroll.html [ Pass Failure ]	1191	webkit.org/b/168924 scrollingcoordinator/ios/non-stable-viewport-scroll.html [ Pass Failure ]
		1192	webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]
1193		1193
1194	webkit.org/b/169640 imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html [ Failure ]	1194	webkit.org/b/169640 imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html [ Failure ]
1195		1195
Lines 1217-1224 webkit.org/b/171331 http/tests/preload/single_download_preload.html [ Pass Failu a/LayoutTests/platform/ios-wk2/TestExpectations_sec3
1217		1217
1218	webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ]	1218	webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ]
1219		1219
1220	webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]
1221
1222	webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]	1220	webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
1223		1221
1224	webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]	1222	webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]

Lines 1531-1540 svg/zoom/text/zoom-svg-float-border-padding.xml [ Failure ] a/LayoutTests/platform/ios/TestExpectations_sec1
- a/LayoutTests/platform/ios/TestExpectations -4 lines
1531	transforms/3d/point-mapping/3d-point-mapping-3.html [ Failure ]	1531	transforms/3d/point-mapping/3d-point-mapping-3.html [ Failure ]
1532	transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ]	1532	transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ]
1533		1533
1534	# Scrolling coordinator tests that fail:
1535	scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ]
1536	scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure ]
1537
1538	# Userscript tests that fail:	1534	# Userscript tests that fail:
1539	userscripts/user-script-plugin-document.html [ Failure ]	1535	userscripts/user-script-plugin-document.html [ Failure ]
1540		1536

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +22 lines
		1	2019-01-22 Simon Fraser <simon.fraser@apple.com>
		2
		3	Make scrollingcoordinator tests only run on iOS/macOS WK2
		4	https://bugs.webkit.org/show_bug.cgi?id=193690
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	scrollingcoordinator is only active in WK2, and both WPE and WinCairo skip this directory
		9	already, so skip it at the top level, and re-enable for mac-wk2 and ios-wk2.
		10
		11	Add some iOS results for two tests.
		12
		13	Also do some cleanup after tiled-drawing/ios was removed on 1/18.
		14
		15	* TestExpectations:
		16	* platform/ios-device/TestExpectations:
		17	* platform/ios-wk2/TestExpectations:
		18	* platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
		19	* platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
		20	* platform/ios/TestExpectations:
		21	* platform/mac-wk2/TestExpectations:
		22
1	2019-01-22 Simon Fraser <simon.fraser@apple.com>	23	2019-01-22 Simon Fraser <simon.fraser@apple.com>
2		24
3	Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results	25	Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results

Line 0 a/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt_sec1
- a/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt +12 lines
	1	layer at (0,0) size 800x600
	2	RenderView at (0,0) size 800x600
	3	layer at (0,0) size 800x8
	4	RenderBlock {HTML} at (0,0) size 800x8
	5	RenderBody {BODY} at (8,8) size 784x0
	6	layer at (50,50) size 324x224
	7	RenderIFrame {IFRAME} at (50,50) size 324x224 [border: (2px inset #000000)]
	8	layer at (0,0) size 1008x1016
	9	RenderView at (0,0) size 300x200
	10	layer at (0,0) size 300x1016
	11	RenderBlock {HTML} at (0,0) size 300x1016
	12	RenderBody {BODY} at (8,8) size 1000x1000

Lines 5-17 a/LayoutTests/platform/mac-wk2/TestExpectations_sec1
- a/LayoutTests/platform/mac-wk2/TestExpectations -5 / +6 lines
5	# Platform-specific directories. Skipped globally, then re-enabled here.	5	# Platform-specific directories. Skipped globally, then re-enabled here.
6	#//////////////////////////////////////////////////////////////////////////////////////////	6	#//////////////////////////////////////////////////////////////////////////////////////////
7		7
8	tiled-drawing [ Pass ]
9	tiled-drawing/ios [ Skip ]
10	fast/visual-viewport/tiled-drawing [ Pass ]
11	swipe [ Pass ]
12	fast/web-share [ Pass ]
13	editing/find [ Pass ]	8	editing/find [ Pass ]
14	editing/undo-manager [ Pass ]	9	editing/undo-manager [ Pass ]
		10	fast/visual-viewport/tiled-drawing [ Pass ]
		11	fast/web-share [ Pass ]
		12	scrollingcoordinator [ Pass ]
		13	scrollingcoordinator/ios [ Skip ]
		14	swipe [ Pass ]
		15	tiled-drawing [ Pass ]
15		16
16	fast/events/autoscroll-when-zoomed.html [ Pass ]	17	fast/events/autoscroll-when-zoomed.html [ Pass ]
17	fast/events/autoscroll-main-document.html [ Pass ]	18	fast/events/autoscroll-main-document.html [ Pass ]