Attachment #351556 for bug #190250

View Details Raw Unified Return to Bug 190250

| Differences between



2018-10-03  Dan Bernstein  <mitz@apple.com>

        WebCore part of [Xcode] Update some build settings as recommended by Xcode 10
        https://bugs.webkit.org/show_bug.cgi?id=190250

        Reviewed by NOBODY (OOPS!).

        No new tests (OOPS!).

        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS.

        * WebCore.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck and remove a
          duplicate reference in a Compile Sources build phase.

        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Suppress -Wdeprecated-implementations
          around implementations of deprecated accessibility methods.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForBOM): Addressed CLANG_WARN_COMMA.

        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
          Suppress -Wdeprecated-implementations around implementations of this deprecated delegate method.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]): Ditto.

2018-10-03  Antoine Quint  <graouts@apple.com>

        [Web Animations] REGRESSION: setting 'animation-name: none' after a 'fill: forwards' animation has completed does not revert to the unanimated style

Lines 37-42 CLANG_CXX_LIBRARY = libc++; Source/WebCore/Configurations/Base.xcconfig_sec1
- Source/WebCore/Configurations/Base.xcconfig +4 lines
37	CLANG_ENABLE_OBJC_WEAK = YES;	37	CLANG_ENABLE_OBJC_WEAK = YES;
38	CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;	38	CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
39	CLANG_WARN_BOOL_CONVERSION = YES;	39	CLANG_WARN_BOOL_CONVERSION = YES;
		40	CLANG_WARN_COMMA = YES;
40	CLANG_WARN_CONSTANT_CONVERSION = YES;	41	CLANG_WARN_CONSTANT_CONVERSION = YES;
41	CLANG_WARN_CXX0X_EXTENSIONS = NO;	42	CLANG_WARN_CXX0X_EXTENSIONS = NO;
42	CLANG_WARN_EMPTY_BODY = YES;	43	CLANG_WARN_EMPTY_BODY = YES;
Lines 51-56 CLANG_WARN_SUSPICIOUS_MOVE = YES; Source/WebCore/Configurations/Base.xcconfig_sec2
51	CLANG_WARN_UNREACHABLE_CODE = YES;	52	CLANG_WARN_UNREACHABLE_CODE = YES;
52	CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;	53	CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
53	GCC_WARN_UNDECLARED_SELECTOR = YES;	54	GCC_WARN_UNDECLARED_SELECTOR = YES;
		55	CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
		56	CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
54	COMBINE_HIDPI_IMAGES = NO;	57	COMBINE_HIDPI_IMAGES = NO;
55	DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;	58	DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
56	ENABLE_STRICT_OBJC_MSGSEND = YES;	59	ENABLE_STRICT_OBJC_MSGSEND = YES;
Lines 79-84 GCC_WARN_ABOUT_MISSING_NEWLINE = YES; Source/WebCore/Configurations/Base.xcconfig_sec3
79	GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;	82	GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
80	GCC_WARN_ABOUT_RETURN_TYPE = YES;	83	GCC_WARN_ABOUT_RETURN_TYPE = YES;
81	GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;	84	GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
		85	CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
82	GCC_WARN_SIGN_COMPARE = YES;	86	GCC_WARN_SIGN_COMPARE = YES;
83	GCC_WARN_UNINITIALIZED_AUTOS = YES;	87	GCC_WARN_UNINITIALIZED_AUTOS = YES;
84	GCC_WARN_UNUSED_FUNCTION = YES;	88	GCC_WARN_UNUSED_FUNCTION = YES;



2018-10-03  Dan Bernstein  <mitz@apple.com>

        PAL part of [Xcode] Update some build settings as recommended by Xcode 10
        https://bugs.webkit.org/show_bug.cgi?id=190250

        Reviewed by NOBODY (OOPS!).

        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS.

        * PAL.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.

2018-10-01  Dean Jackson  <dino@apple.com>

        Remove CSS Animation Triggers

Lines 37-42 CLANG_CXX_LIBRARY = libc++; Source/WebCore/PAL/Configurations/Base.xcconfig_sec1
- Source/WebCore/PAL/Configurations/Base.xcconfig +4 lines
37	CLANG_ENABLE_OBJC_WEAK = YES;	37	CLANG_ENABLE_OBJC_WEAK = YES;
38	CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;	38	CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
39	CLANG_WARN_BOOL_CONVERSION = YES;	39	CLANG_WARN_BOOL_CONVERSION = YES;
		40	CLANG_WARN_COMMA = YES;
40	CLANG_WARN_CONSTANT_CONVERSION = YES;	41	CLANG_WARN_CONSTANT_CONVERSION = YES;
41	CLANG_WARN_CXX0X_EXTENSIONS = NO;	42	CLANG_WARN_CXX0X_EXTENSIONS = NO;
42	CLANG_WARN_EMPTY_BODY = YES;	43	CLANG_WARN_EMPTY_BODY = YES;
Lines 51-56 CLANG_WARN_SUSPICIOUS_MOVE = YES; Source/WebCore/PAL/Configurations/Base.xcconfig_sec2
51	CLANG_WARN_UNREACHABLE_CODE = YES;	52	CLANG_WARN_UNREACHABLE_CODE = YES;
52	CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;	53	CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
53	GCC_WARN_UNDECLARED_SELECTOR = YES;	54	GCC_WARN_UNDECLARED_SELECTOR = YES;
		55	CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
		56	CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
54	COMBINE_HIDPI_IMAGES = NO;	57	COMBINE_HIDPI_IMAGES = NO;
55	DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;	58	DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
56	ENABLE_STRICT_OBJC_MSGSEND = YES;	59	ENABLE_STRICT_OBJC_MSGSEND = YES;
Lines 79-84 GCC_WARN_ABOUT_MISSING_NEWLINE = YES; Source/WebCore/PAL/Configurations/Base.xcconfig_sec3
79	GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;	82	GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
80	GCC_WARN_ABOUT_RETURN_TYPE = YES;	83	GCC_WARN_ABOUT_RETURN_TYPE = YES;
81	GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;	84	GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
		85	CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
82	GCC_WARN_SIGN_COMPARE = YES;	86	GCC_WARN_SIGN_COMPARE = YES;
83	GCC_WARN_UNINITIALIZED_AUTOS = YES;	87	GCC_WARN_UNINITIALIZED_AUTOS = YES;
84	GCC_WARN_UNUSED_FUNCTION = YES;	88	GCC_WARN_UNUSED_FUNCTION = YES;

Lines 782-788 Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj_sec1
- Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj -1 / +1 lines
782	1C09D0351E31C32800725F18 /* Project object */ = {	782	1C09D0351E31C32800725F18 /* Project object */ = {
783	isa = PBXProject;	783	isa = PBXProject;
784	attributes = {	784	attributes = {
785	LastUpgradeCheck = 0830;	785	LastUpgradeCheck = 1000;
786	TargetAttributes = {	786	TargetAttributes = {
787	1C09D03C1E31C32800725F18 = {	787	1C09D03C1E31C32800725F18 = {
788	CreatedOnToolsVersion = 8.3;	788	CreatedOnToolsVersion = 8.3;



    return textMarkerRangeFromVisiblePositions(m_object->axObjectCache(), startPosition, endPosition);
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray*)accessibilityActionNames
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return nil;

    return additional;
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray*)accessibilityAttributeNames
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return nil;

// FIXME: split up this function in a better way.
// suggestions: Use a hash table that maps attribute names to function calls,
// or maybe pointers to member functions
IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString*)attributeName
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return nil;

    return NSAccessibilityUnignoredAncestor(self);
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return NO;

// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.
//
// Registering an object is also required for observing notifications. Only registered objects can be observed.
IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsIgnored
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return YES;

    return m_object->accessibilityIsIgnored();
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray* )accessibilityParameterizedAttributeNames
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return nil;

    m_object->scrollToGlobalPoint(IntPoint(point));
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)accessibilityPerformAction:(NSString*)action
IGNORE_WARNINGS_END
{
    if (![self updateObjectBackingStore])
        return;

        [self accessibilityScrollToVisible];
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
IGNORE_WARNINGS_END
{
#if PLATFORM(MAC)
    // In case anything we do by changing values causes an alert or other modal

    return nil;
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSString*)accessibilityActionDescription:(NSString*)action
IGNORE_WARNINGS_END
{
    // we have no custom actions
    return NSAccessibilityActionDescription(action);

}
#endif

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString*)attribute forParameter:(id)parameter
IGNORE_WARNINGS_END
{
    id textMarker = nil;
    id textMarkerRange = nil;



    size_t buf2Len = len;
    const unsigned char* buf1 = reinterpret_cast<const unsigned char*>(m_buffer.data());
    const unsigned char* buf2 = reinterpret_cast<const unsigned char*>(data);
    unsigned char c1 = buf1Len ? (static_cast<void>(--buf1Len), *buf1++) : buf2Len ? (static_cast<void>(--buf2Len), *buf2++) : 0;
    unsigned char c2 = buf1Len ? (static_cast<void>(--buf1Len), *buf1++) : buf2Len ? (static_cast<void>(--buf2Len), *buf2++) : 0;
    unsigned char c3 = buf1Len ? (static_cast<void>(--buf1Len), *buf1++) : buf2Len ? (static_cast<void>(--buf2Len), *buf2++) : 0;

    // Check for the BOM.
    if (c1 == 0xFF && c2 == 0xFE) {



    return requestResult.autorelease();
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)connection:(NSURLConnection *)connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge
IGNORE_WARNINGS_END
{
    ASSERT(!isMainThread());
    UNUSED_PARAM(connection);

    [self callFunctionOnMainThread:WTFMove(work)];
}

IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)connection:(NSURLConnection *)connection canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace *)protectionSpace
IGNORE_WARNINGS_END
{
    ASSERT(!isMainThread());
    UNUSED_PARAM(connection);

Return to Bug 190250

Lines 1117-1123 - (id)textMarkerRangeFromVisiblePosition Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec1
- Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm +20 lines
1117	return textMarkerRangeFromVisiblePositions(m_object->axObjectCache(), startPosition, endPosition);	1117	return textMarkerRangeFromVisiblePositions(m_object->axObjectCache(), startPosition, endPosition);
1118	}	1118	}
1119		1119
		1120	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
1120	- (NSArray*)accessibilityActionNames	1121	- (NSArray*)accessibilityActionNames
		1122	IGNORE_WARNINGS_END
1121	{	1123	{
1122	if (![self updateObjectBackingStore])	1124	if (![self updateObjectBackingStore])
1123	return nil;	1125	return nil;
Lines 1251-1257 - (NSArray*)additionalAccessibilityAttri Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec2
1251	return additional;	1253	return additional;
1252	}	1254	}
1253		1255
		1256	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
1254	- (NSArray*)accessibilityAttributeNames	1257	- (NSArray*)accessibilityAttributeNames
		1258	IGNORE_WARNINGS_END
1255	{	1259	{
1256	if (![self updateObjectBackingStore])	1260	if (![self updateObjectBackingStore])
1257	return nil;	1261	return nil;
Lines 2426-2432 - (NSString *)valueDescriptionForMeter Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec3
2426	// FIXME: split up this function in a better way.	2430	// FIXME: split up this function in a better way.
2427	// suggestions: Use a hash table that maps attribute names to function calls,	2431	// suggestions: Use a hash table that maps attribute names to function calls,
2428	// or maybe pointers to member functions	2432	// or maybe pointers to member functions
		2433	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
2429	- (id)accessibilityAttributeValue:(NSString*)attributeName	2434	- (id)accessibilityAttributeValue:(NSString*)attributeName
		2435	IGNORE_WARNINGS_END
2430	{	2436	{
2431	if (![self updateObjectBackingStore])	2437	if (![self updateObjectBackingStore])
2432	return nil;	2438	return nil;
Lines 3301-3307 - (id)accessibilityHitTest:(NSPoint)poin Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec4
3301	return NSAccessibilityUnignoredAncestor(self);	3307	return NSAccessibilityUnignoredAncestor(self);
3302	}	3308	}
3303		3309
		3310	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3304	- (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName	3311	- (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
		3312	IGNORE_WARNINGS_END
3305	{	3313	{
3306	if (![self updateObjectBackingStore])	3314	if (![self updateObjectBackingStore])
3307	return NO;	3315	return NO;
Lines 3354-3360 - (BOOL)accessibilityIsAttributeSettable Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec5
3354	// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.	3362	// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.
3355	//	3363	//
3356	// Registering an object is also required for observing notifications. Only registered objects can be observed.	3364	// Registering an object is also required for observing notifications. Only registered objects can be observed.
		3365	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3357	- (BOOL)accessibilityIsIgnored	3366	- (BOOL)accessibilityIsIgnored
		3367	IGNORE_WARNINGS_END
3358	{	3368	{
3359	if (![self updateObjectBackingStore])	3369	if (![self updateObjectBackingStore])
3360	return YES;	3370	return YES;
Lines 3364-3370 - (BOOL)accessibilityIsIgnored Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec6
3364	return m_object->accessibilityIsIgnored();	3374	return m_object->accessibilityIsIgnored();
3365	}	3375	}
3366		3376
		3377	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3367	- (NSArray* )accessibilityParameterizedAttributeNames	3378	- (NSArray* )accessibilityParameterizedAttributeNames
		3379	IGNORE_WARNINGS_END
3368	{	3380	{
3369	if (![self updateObjectBackingStore])	3381	if (![self updateObjectBackingStore])
3370	return nil;	3382	return nil;
Lines 3584-3590 - (void)_accessibilityScrollToGlobalPoin Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec7
3584	m_object->scrollToGlobalPoint(IntPoint(point));	3596	m_object->scrollToGlobalPoint(IntPoint(point));
3585	}	3597	}
3586		3598
		3599	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3587	- (void)accessibilityPerformAction:(NSString*)action	3600	- (void)accessibilityPerformAction:(NSString*)action
		3601	IGNORE_WARNINGS_END
3588	{	3602	{
3589	if (![self updateObjectBackingStore])	3603	if (![self updateObjectBackingStore])
3590	return;	3604	return;
Lines 3615-3621 - (void)accessibilityPerformAction:(NSSt Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec8
3615	[self accessibilityScrollToVisible];	3629	[self accessibilityScrollToVisible];
3616	}	3630	}
3617		3631
		3632	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3618	- (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName	3633	- (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
		3634	IGNORE_WARNINGS_END
3619	{	3635	{
3620	#if PLATFORM(MAC)	3636	#if PLATFORM(MAC)
3621	// In case anything we do by changing values causes an alert or other modal	3637	// In case anything we do by changing values causes an alert or other modal
Lines 3758-3764 - (id)_accessibilityParentForSubview:(NS Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec9
3758	return nil;	3774	return nil;
3759	}	3775	}
3760		3776
		3777	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3761	- (NSString)accessibilityActionDescription:(NSString)action	3778	- (NSString)accessibilityActionDescription:(NSString)action
		3779	IGNORE_WARNINGS_END
3762	{	3780	{
3763	// we have no custom actions	3781	// we have no custom actions
3764	return NSAccessibilityActionDescription(action);	3782	return NSAccessibilityActionDescription(action);
Lines 3887-3893 static void formatForDebugger(const Visi Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm_sec10
3887	}	3905	}
3888	#endif	3906	#endif
3889		3907
		3908	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
3890	- (id)accessibilityAttributeValue:(NSString*)attribute forParameter:(id)parameter	3909	- (id)accessibilityAttributeValue:(NSString*)attribute forParameter:(id)parameter
		3910	IGNORE_WARNINGS_END
3891	{	3911	{
3892	id textMarker = nil;	3912	id textMarker = nil;
3893	id textMarkerRange = nil;	3913	id textMarkerRange = nil;

Lines 415-423 size_t TextResourceDecoder::checkForBOM( Source/WebCore/loader/TextResourceDecoder.cpp_sec1
- Source/WebCore/loader/TextResourceDecoder.cpp -3 / +3 lines
415	size_t buf2Len = len;	415	size_t buf2Len = len;
416	const unsigned char* buf1 = reinterpret_cast<const unsigned char*>(m_buffer.data());	416	const unsigned char* buf1 = reinterpret_cast<const unsigned char*>(m_buffer.data());
417	const unsigned char* buf2 = reinterpret_cast<const unsigned char*>(data);	417	const unsigned char* buf2 = reinterpret_cast<const unsigned char*>(data);
418	unsigned char c1 = buf1Len ? (--buf1Len, buf1++) : buf2Len ? (--buf2Len, buf2++) : 0;	418	unsigned char c1 = buf1Len ? (static_cast<void>(--buf1Len), buf1++) : buf2Len ? (static_cast<void>(--buf2Len), buf2++) : 0;
419	unsigned char c2 = buf1Len ? (--buf1Len, buf1++) : buf2Len ? (--buf2Len, buf2++) : 0;	419	unsigned char c2 = buf1Len ? (static_cast<void>(--buf1Len), buf1++) : buf2Len ? (static_cast<void>(--buf2Len), buf2++) : 0;
420	unsigned char c3 = buf1Len ? (--buf1Len, buf1++) : buf2Len ? (--buf2Len, buf2++) : 0;	420	unsigned char c3 = buf1Len ? (static_cast<void>(--buf1Len), buf1++) : buf2Len ? (static_cast<void>(--buf2Len), buf2++) : 0;
421		421
422	// Check for the BOM.	422	// Check for the BOM.
423	if (c1 == 0xFF && c2 == 0xFE) {	423	if (c1 == 0xFF && c2 == 0xFE) {

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +26 lines
		1	2018-10-03 Dan Bernstein <mitz@apple.com>
		2
		3	WebCore part of [Xcode] Update some build settings as recommended by Xcode 10
		4	https://bugs.webkit.org/show_bug.cgi?id=190250
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	No new tests (OOPS!).
		9
		10	* Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
		11	CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS.
		12
		13	* WebCore.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck and remove a
		14	duplicate reference in a Compile Sources build phase.
		15
		16	* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Suppress -Wdeprecated-implementations
		17	around implementations of deprecated accessibility methods.
		18
		19	* loader/TextResourceDecoder.cpp:
		20	(WebCore::TextResourceDecoder::checkForBOM): Addressed CLANG_WARN_COMMA.
		21
		22	* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
		23	(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
		24	Suppress -Wdeprecated-implementations around implementations of this deprecated delegate method.
		25	(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]): Ditto.
		26
1	2018-10-03 Antoine Quint <graouts@apple.com>	27	2018-10-03 Antoine Quint <graouts@apple.com>
2		28
3	[Web Animations] REGRESSION: setting 'animation-name: none' after a 'fill: forwards' animation has completed does not revert to the unanimated style	29	[Web Animations] REGRESSION: setting 'animation-name: none' after a 'fill: forwards' animation has completed does not revert to the unanimated style

Lines 1-3 Source/WebCore/PAL/ChangeLog_sec1
- Source/WebCore/PAL/ChangeLog +12 lines
		1	2018-10-03 Dan Bernstein <mitz@apple.com>
		2
		3	PAL part of [Xcode] Update some build settings as recommended by Xcode 10
		4	https://bugs.webkit.org/show_bug.cgi?id=190250
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
		9	CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS.
		10
		11	* PAL.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
		12
1	2018-10-01 Dean Jackson <dino@apple.com>	13	2018-10-01 Dean Jackson <dino@apple.com>
2		14
3	Remove CSS Animation Triggers	15	Remove CSS Animation Triggers

Lines 161-167 - (NSURLRequest *)connection:(NSURLConne Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm_sec1
- Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm +4 lines
161	return requestResult.autorelease();	161	return requestResult.autorelease();
162	}	162	}
163		163
		164	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
164	- (void)connection:(NSURLConnection )connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge )challenge	165	- (void)connection:(NSURLConnection )connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge )challenge
		166	IGNORE_WARNINGS_END
165	{	167	{
166	ASSERT(!isMainThread());	168	ASSERT(!isMainThread());
167	UNUSED_PARAM(connection);	169	UNUSED_PARAM(connection);
Lines 179-185 - (void)connection:(NSURLConnection *)co Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm_sec2
179	[self callFunctionOnMainThread:WTFMove(work)];	181	[self callFunctionOnMainThread:WTFMove(work)];
180	}	182	}
181		183
		184	IGNORE_WARNINGS_BEGIN("deprecated-implementations")
182	- (BOOL)connection:(NSURLConnection )connection canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace )protectionSpace	185	- (BOOL)connection:(NSURLConnection )connection canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace )protectionSpace
		186	IGNORE_WARNINGS_END
183	{	187	{
184	ASSERT(!isMainThread());	188	ASSERT(!isMainThread());
185	UNUSED_PARAM(connection);	189	UNUSED_PARAM(connection);

Lines 200-206 Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec1
- Source/WebCore/WebCore.xcodeproj/project.pbxproj -15 / +9 lines
200	07B7116D1D899E63009F0FFB /* CaptureDevice.h in Headers / = {isa = PBXBuildFile; fileRef = 07B7116A1D899E63009F0FFB / CaptureDevice.h */; settings = {ATTRIBUTES = (Private, ); }; };	200	07B7116D1D899E63009F0FFB /* CaptureDevice.h in Headers / = {isa = PBXBuildFile; fileRef = 07B7116A1D899E63009F0FFB / CaptureDevice.h */; settings = {ATTRIBUTES = (Private, ); }; };
201	07B7116F1D899E63009F0FFB /* CaptureDeviceManager.h in Headers / = {isa = PBXBuildFile; fileRef = 07B7116C1D899E63009F0FFB / CaptureDeviceManager.h */; settings = {ATTRIBUTES = (Private, ); }; };	201	07B7116F1D899E63009F0FFB /* CaptureDeviceManager.h in Headers / = {isa = PBXBuildFile; fileRef = 07B7116C1D899E63009F0FFB / CaptureDeviceManager.h */; settings = {ATTRIBUTES = (Private, ); }; };
202	07C046C41E42508B007201E7 /* CAAudioStreamDescription.h in Headers / = {isa = PBXBuildFile; fileRef = 073B87581E40DCFD0071C0EC / CAAudioStreamDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };	202	07C046C41E42508B007201E7 /* CAAudioStreamDescription.h in Headers / = {isa = PBXBuildFile; fileRef = 073B87581E40DCFD0071C0EC / CAAudioStreamDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
203	07C046C81E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.h in Headers / = {isa = PBXBuildFile; fileRef = 07C046C61E42512F007201E7 / AudioTrackPrivateMediaStreamCocoa.h */; };
204	07C046CB1E426413007201E7 /* AudioStreamDescription.h in Headers / = {isa = PBXBuildFile; fileRef = 073B87561E40DCE50071C0EC / AudioStreamDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };	203	07C046CB1E426413007201E7 /* AudioStreamDescription.h in Headers / = {isa = PBXBuildFile; fileRef = 073B87561E40DCE50071C0EC / AudioStreamDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
205	07C1C0E21BFB600100BD2256 /* MediaTrackSupportedConstraints.h in Headers / = {isa = PBXBuildFile; fileRef = 07C1C0E01BFB600100BD2256 / MediaTrackSupportedConstraints.h */; };	204	07C1C0E21BFB600100BD2256 /* MediaTrackSupportedConstraints.h in Headers / = {isa = PBXBuildFile; fileRef = 07C1C0E01BFB600100BD2256 / MediaTrackSupportedConstraints.h */; };
206	07C1C0E51BFB60ED00BD2256 /* RealtimeMediaSourceSupportedConstraints.h in Headers / = {isa = PBXBuildFile; fileRef = 07C1C0E41BFB60ED00BD2256 / RealtimeMediaSourceSupportedConstraints.h */; settings = {ATTRIBUTES = (Private, ); }; };	205	07C1C0E51BFB60ED00BD2256 /* RealtimeMediaSourceSupportedConstraints.h in Headers / = {isa = PBXBuildFile; fileRef = 07C1C0E41BFB60ED00BD2256 / RealtimeMediaSourceSupportedConstraints.h */; settings = {ATTRIBUTES = (Private, ); }; };
Lines 1002-1007 Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec2
1002	371F53E90D2704F900ECE0D5 /* CSSUnicodeRangeValue.h in Headers / = {isa = PBXBuildFile; fileRef = 371F53E70D2704F900ECE0D5 / CSSUnicodeRangeValue.h */; };	1001	371F53E90D2704F900ECE0D5 /* CSSUnicodeRangeValue.h in Headers / = {isa = PBXBuildFile; fileRef = 371F53E70D2704F900ECE0D5 / CSSUnicodeRangeValue.h */; };
1003	372ADA38197F47B900FC501E /* ProtectionSpaceCocoa.h in Headers / = {isa = PBXBuildFile; fileRef = 372ADA37197F47B900FC501E / ProtectionSpaceCocoa.h */; settings = {ATTRIBUTES = (Private, ); }; };	1002	372ADA38197F47B900FC501E /* ProtectionSpaceCocoa.h in Headers / = {isa = PBXBuildFile; fileRef = 372ADA37197F47B900FC501E / ProtectionSpaceCocoa.h */; settings = {ATTRIBUTES = (Private, ); }; };
1004	372C00D9129619F8005C9575 /* FindOptions.h in Headers / = {isa = PBXBuildFile; fileRef = 372C00D8129619F8005C9575 / FindOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };	1003	372C00D9129619F8005C9575 /* FindOptions.h in Headers / = {isa = PBXBuildFile; fileRef = 372C00D8129619F8005C9575 / FindOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
		1004	372D3E54216578AE00C5E021 /* DataURLDecoder.h in Headers / = {isa = PBXBuildFile; fileRef = E4A007821B820EC8002C5A6E / DataURLDecoder.h */; };
		1005	372D3E55216578AE00C5E021 /* ScriptModuleLoader.h in Headers / = {isa = PBXBuildFile; fileRef = E38838951BAD145F00D62EE3 / ScriptModuleLoader.h */; };
		1006	372D3E56216578AE00C5E021 /* AudioTrackPrivateMediaStreamCocoa.h in Headers / = {isa = PBXBuildFile; fileRef = 07C046C61E42512F007201E7 / AudioTrackPrivateMediaStreamCocoa.h */; };
		1007	372D3E57216578AE00C5E021 /* NavigatorCredentials.h in Headers / = {isa = PBXBuildFile; fileRef = 57D846261FE895F800CA3682 / NavigatorCredentials.h */; };
1005	375CD232119D43C800A2A859 /* Hyphenation.h in Headers / = {isa = PBXBuildFile; fileRef = 375CD231119D43C800A2A859 / Hyphenation.h */; };	1008	375CD232119D43C800A2A859 /* Hyphenation.h in Headers / = {isa = PBXBuildFile; fileRef = 375CD231119D43C800A2A859 / Hyphenation.h */; };
1006	3774ABA50FA21EB400AD7DE9 /* OverlapTestRequestClient.h in Headers / = {isa = PBXBuildFile; fileRef = 3774ABA30FA21EB400AD7DE9 / OverlapTestRequestClient.h */; settings = {ATTRIBUTES = (Private, ); }; };	1009	3774ABA50FA21EB400AD7DE9 /* OverlapTestRequestClient.h in Headers / = {isa = PBXBuildFile; fileRef = 3774ABA30FA21EB400AD7DE9 / OverlapTestRequestClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
1007	37919C240B7D188600A56998 /* PositionIterator.h in Headers / = {isa = PBXBuildFile; fileRef = 37919C220B7D188600A56998 / PositionIterator.h */; settings = {ATTRIBUTES = (); }; };	1010	37919C240B7D188600A56998 /* PositionIterator.h in Headers / = {isa = PBXBuildFile; fileRef = 37919C220B7D188600A56998 / PositionIterator.h */; settings = {ATTRIBUTES = (); }; };
Lines 1721-1727 Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec3
1721	555130011E7CCCCB00A69E38 /* DecodingOptions.h in Headers / = {isa = PBXBuildFile; fileRef = 555130001E7CCCCA00A69E38 / DecodingOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };	1724	555130011E7CCCCB00A69E38 /* DecodingOptions.h in Headers / = {isa = PBXBuildFile; fileRef = 555130001E7CCCCA00A69E38 / DecodingOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
1722	555B87ED1CAAF0AB00349425 /* ImageDecoderCG.h in Headers / = {isa = PBXBuildFile; fileRef = 555B87EB1CAAF0AB00349425 / ImageDecoderCG.h */; };	1725	555B87ED1CAAF0AB00349425 /* ImageDecoderCG.h in Headers / = {isa = PBXBuildFile; fileRef = 555B87EB1CAAF0AB00349425 / ImageDecoderCG.h */; };
1723	5576A5651D88A70800CCC04C /* ImageFrame.h in Headers / = {isa = PBXBuildFile; fileRef = 5576A5631D88A70800CCC04C / ImageFrame.h */; settings = {ATTRIBUTES = (Private, ); }; };	1726	5576A5651D88A70800CCC04C /* ImageFrame.h in Headers / = {isa = PBXBuildFile; fileRef = 5576A5631D88A70800CCC04C / ImageFrame.h */; settings = {ATTRIBUTES = (Private, ); }; };
1724	55A336F71D8209F40022C4C7 /* NativeImage.h in Headers / = {isa = PBXBuildFile; fileRef = 55A336F61D8209F40022C4C7 / NativeImage.h */; };
1725	55A336F91D821E3C0022C4C7 /* ImageBackingStore.h in Headers / = {isa = PBXBuildFile; fileRef = 55A336F81D821E3C0022C4C7 / ImageBackingStore.h */; settings = {ATTRIBUTES = (Private, ); }; };	1727	55A336F91D821E3C0022C4C7 /* ImageBackingStore.h in Headers / = {isa = PBXBuildFile; fileRef = 55A336F81D821E3C0022C4C7 / ImageBackingStore.h */; settings = {ATTRIBUTES = (Private, ); }; };
1726	55AF14E61EAAC59B0026EEAA /* UTIRegistry.h in Headers / = {isa = PBXBuildFile; fileRef = 55AF14E41EAAC59B0026EEAA / UTIRegistry.h */; settings = {ATTRIBUTES = (Private, ); }; };	1728	55AF14E61EAAC59B0026EEAA /* UTIRegistry.h in Headers / = {isa = PBXBuildFile; fileRef = 55AF14E41EAAC59B0026EEAA / UTIRegistry.h */; settings = {ATTRIBUTES = (Private, ); }; };
1727	55EC9599206AA7A0007DD0A9 /* PaintFrequencyTracker.h in Headers / = {isa = PBXBuildFile; fileRef = 55EC95972069C92D007DD0A9 / PaintFrequencyTracker.h */; settings = {ATTRIBUTES = (Private, ); }; };	1729	55EC9599206AA7A0007DD0A9 /* PaintFrequencyTracker.h in Headers / = {isa = PBXBuildFile; fileRef = 55EC95972069C92D007DD0A9 / PaintFrequencyTracker.h */; settings = {ATTRIBUTES = (Private, ); }; };
Lines 1786-1792 Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec4
1786	57C7A68C1E56967500C67D71 /* BasicCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57C7A68B1E56967500C67D71 / BasicCredential.h */; settings = {ATTRIBUTES = (Private, ); }; };	1788	57C7A68C1E56967500C67D71 /* BasicCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57C7A68B1E56967500C67D71 / BasicCredential.h */; settings = {ATTRIBUTES = (Private, ); }; };
1787	57C7A69F1E57917800C67D71 /* JSBasicCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57C7A69D1E57910D00C67D71 / JSBasicCredential.h */; };	1789	57C7A69F1E57917800C67D71 /* JSBasicCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57C7A69D1E57910D00C67D71 / JSBasicCredential.h */; };
1788	57D0018D1DD5413200ED19D9 /* JSCryptoKeyUsage.h in Headers / = {isa = PBXBuildFile; fileRef = 57D0018C1DD5413200ED19D9 / JSCryptoKeyUsage.h */; };	1790	57D0018D1DD5413200ED19D9 /* JSCryptoKeyUsage.h in Headers / = {isa = PBXBuildFile; fileRef = 57D0018C1DD5413200ED19D9 / JSCryptoKeyUsage.h */; };
1789	57D846281FE8960500CA3682 /* NavigatorCredentials.h in Headers / = {isa = PBXBuildFile; fileRef = 57D846261FE895F800CA3682 / NavigatorCredentials.h */; };
1790	57D8462E1FEAF69900CA3682 /* PublicKeyCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57D8462B1FEAF68F00CA3682 / PublicKeyCredential.h */; settings = {ATTRIBUTES = (Private, ); }; };	1791	57D8462E1FEAF69900CA3682 /* PublicKeyCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57D8462B1FEAF68F00CA3682 / PublicKeyCredential.h */; settings = {ATTRIBUTES = (Private, ); }; };
1791	57D846351FEAFCD300CA3682 /* JSPublicKeyCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57D846301FEAFC2F00CA3682 / JSPublicKeyCredential.h */; };	1792	57D846351FEAFCD300CA3682 /* JSPublicKeyCredential.h in Headers / = {isa = PBXBuildFile; fileRef = 57D846301FEAFC2F00CA3682 / JSPublicKeyCredential.h */; };
1792	57DCED74214305F00016B847 /* PublicKeyCredentialData.h in Headers / = {isa = PBXBuildFile; fileRef = 57DCED72214305F00016B847 / PublicKeyCredentialData.h */; settings = {ATTRIBUTES = (Private, ); }; };	1793	57DCED74214305F00016B847 /* PublicKeyCredentialData.h in Headers / = {isa = PBXBuildFile; fileRef = 57DCED72214305F00016B847 / PublicKeyCredentialData.h */; settings = {ATTRIBUTES = (Private, ); }; };
Lines 4715-4721 Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec5
4715	E35802B61DC8435D00A9773C /* DOMJITIDLTypeFilter.h in Headers / = {isa = PBXBuildFile; fileRef = E35802B51DC8435800A9773C / DOMJITIDLTypeFilter.h */; settings = {ATTRIBUTES = (Private, ); }; };	4716	E35802B61DC8435D00A9773C /* DOMJITIDLTypeFilter.h in Headers / = {isa = PBXBuildFile; fileRef = E35802B51DC8435800A9773C / DOMJITIDLTypeFilter.h */; settings = {ATTRIBUTES = (Private, ); }; };
4716	E377FE4D1DADE16500CDD025 /* NodeConstants.h in Headers / = {isa = PBXBuildFile; fileRef = E3D049931DADC04500718F3C / NodeConstants.h */; settings = {ATTRIBUTES = (Private, ); }; };	4717	E377FE4D1DADE16500CDD025 /* NodeConstants.h in Headers / = {isa = PBXBuildFile; fileRef = E3D049931DADC04500718F3C / NodeConstants.h */; settings = {ATTRIBUTES = (Private, ); }; };
4717	E37C86501EB63E3F0087C6CA /* JSDOMPromise.h in Headers / = {isa = PBXBuildFile; fileRef = E37C864F1EB63E2D0087C6CA / JSDOMPromise.h */; settings = {ATTRIBUTES = (Private, ); }; };	4718	E37C86501EB63E3F0087C6CA /* JSDOMPromise.h in Headers / = {isa = PBXBuildFile; fileRef = E37C864F1EB63E2D0087C6CA / JSDOMPromise.h */; settings = {ATTRIBUTES = (Private, ); }; };
4718	E38838991BAD145F00D62EE3 /* ScriptModuleLoader.h in Headers / = {isa = PBXBuildFile; fileRef = E38838951BAD145F00D62EE3 / ScriptModuleLoader.h */; };