Attachment #28264 for bug #3547

View Details Raw Unified Return to Bug 3547

| Differences between



2009-03-04  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by NOBODY (OOPS!).

        https://bugs.webkit.org/show_bug.cgi?id=3547
        XMLHttpRequest.statusText returns always "OK"

        Return ResourceResponse status text. It is now up to each platform
        to correctly set the status text or set it to "OK" to retain current
        behavior.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::statusText):

2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.




String XMLHttpRequest::statusText(ExceptionCode& ec) const
{
    // FIXME: <http://bugs.webkit.org/show_bug.cgi?id=3547> XMLHttpRequest.statusText returns always "OK".
    if (m_response.httpStatusCode())
        return "OK";

    if (m_state == OPENED) {
        // See comments in getStatus() above.
        ec = INVALID_STATE_ERR;
    }

    return m_response.httpStatusText();
}

void XMLHttpRequest::didFail(const ResourceError& error)



2009-03-04  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by NOBODY (OOPS!).

        https://bugs.webkit.org/show_bug.cgi?id=3547
        XMLHttpRequest.statusText returns always "OK"

        Added platform specific expected results for tests that now pass.

        * platform/gtk/http: Added.
        * platform/gtk/http/tests: Added.
        * platform/gtk/http/tests/xmlhttprequest: Added.
        * platform/gtk/http/tests/xmlhttprequest/web-apps: Added.
        * platform/gtk/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
        * platform/gtk/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
        * platform/qt/http/tests/xmlhttprequest: Added.
        * platform/qt/http/tests/xmlhttprequest/web-apps: Added.
        * platform/qt/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
        * platform/qt/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
        * platform/win/http: Added.
        * platform/win/http/tests: Added.
        * platform/win/http/tests/xmlhttprequest: Added.
        * platform/win/http/tests/xmlhttprequest/web-apps: Added.
        * platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
        * platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.

2009-03-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

Line 0 LayoutTests/platform/gtk/http/tests/xmlhttprequest/web-apps/012-expected.txt_sec1
- LayoutTests/platform/gtk/http/tests/xmlhttprequest/web-apps/012-expected.txt +1 lines
		1	PASS

Line 0 LayoutTests/platform/gtk/http/tests/xmlhttprequest/web-apps/013-expected.txt_sec1
- LayoutTests/platform/gtk/http/tests/xmlhttprequest/web-apps/013-expected.txt +1 lines
		1	PASS

Line 0 LayoutTests/platform/qt/http/tests/xmlhttprequest/web-apps/012-expected.txt_sec1
- LayoutTests/platform/qt/http/tests/xmlhttprequest/web-apps/012-expected.txt +1 lines
		1	PASS

Line 0 LayoutTests/platform/qt/http/tests/xmlhttprequest/web-apps/013-expected.txt_sec1
- LayoutTests/platform/qt/http/tests/xmlhttprequest/web-apps/013-expected.txt +1 lines
		1	PASS

Line 0 LayoutTests/platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt_sec1
- LayoutTests/platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt +1 lines
		1	PASS

Line 0 LayoutTests/platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt_sec1
- LayoutTests/platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt +1 lines
		1	PASS

Return to Bug 3547

Lines 1109-1124 int XMLHttpRequest::status(ExceptionCode WebCore/xml/XMLHttpRequest.cpp_sec1
- WebCore/xml/XMLHttpRequest.cpp -5 / +1 lines
1109		1109
1110	String XMLHttpRequest::statusText(ExceptionCode& ec) const	1110	String XMLHttpRequest::statusText(ExceptionCode& ec) const
1111	{	1111	{
1112	// FIXME: <http://bugs.webkit.org/show_bug.cgi?id=3547> XMLHttpRequest.statusText returns always "OK".
1113	if (m_response.httpStatusCode())
1114	return "OK";
1115
1116	if (m_state == OPENED) {	1112	if (m_state == OPENED) {
1117	// See comments in getStatus() above.	1113	// See comments in getStatus() above.
1118	ec = INVALID_STATE_ERR;	1114	ec = INVALID_STATE_ERR;
1119	}	1115	}
1120		1116
1121	return String();	1117	return m_response.httpStatusText();
1122	}	1118	}
1123		1119
1124	void XMLHttpRequest::didFail(const ResourceError& error)	1120	void XMLHttpRequest::didFail(const ResourceError& error)

Lines 1-3 WebCore/ChangeLog_sec1
- WebCore/ChangeLog +14 lines
		1	2009-03-04 Adam Bergkvist <adam.bergkvist@ericsson.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	https://bugs.webkit.org/show_bug.cgi?id=3547
		6	XMLHttpRequest.statusText returns always "OK"
		7
		8	Return ResourceResponse status text. It is now up to each platform
		9	to correctly set the status text or set it to "OK" to retain current
		10	behavior.
		11
		12	* xml/XMLHttpRequest.cpp:
		13	(WebCore::XMLHttpRequest::statusText):
		14
1	2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>	15	2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
2		16
3	Reviewed by Simon Hausmann.	17	Reviewed by Simon Hausmann.

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +26 lines
		1	2009-03-04 Adam Bergkvist <adam.bergkvist@ericsson.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	https://bugs.webkit.org/show_bug.cgi?id=3547
		6	XMLHttpRequest.statusText returns always "OK"
		7
		8	Added platform specific expected results for tests that now pass.
		9
		10	* platform/gtk/http: Added.
		11	* platform/gtk/http/tests: Added.
		12	* platform/gtk/http/tests/xmlhttprequest: Added.
		13	* platform/gtk/http/tests/xmlhttprequest/web-apps: Added.
		14	* platform/gtk/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
		15	* platform/gtk/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
		16	* platform/qt/http/tests/xmlhttprequest: Added.
		17	* platform/qt/http/tests/xmlhttprequest/web-apps: Added.
		18	* platform/qt/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
		19	* platform/qt/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
		20	* platform/win/http: Added.
		21	* platform/win/http/tests: Added.
		22	* platform/win/http/tests/xmlhttprequest: Added.
		23	* platform/win/http/tests/xmlhttprequest/web-apps: Added.
		24	* platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
		25	* platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
		26
1	2009-03-03 Anders Carlsson <andersca@apple.com>	27	2009-03-03 Anders Carlsson <andersca@apple.com>
2		28
3	Reviewed by John Sullivan.	29	Reviewed by John Sullivan.