|
Lines 1-3
a/Websites/perf.webkit.org/ChangeLog_sec1
|
|
|
1 |
2016-05-21 Ryosuke Niwa <rniwa@webkit.org> |
| 2 |
|
| 3 |
Some applications truncates the last closing parenthesis in perf dashboard URL |
| 4 |
https://bugs.webkit.org/show_bug.cgi?id=157976 |
| 5 |
|
| 6 |
Reviewed by NOBODY (OOPS!). |
| 7 |
|
| 8 |
Unfortunately, different applications use different heuristics to determine the end of each URL. Two trailing |
| 9 |
parentheses, for example, is just fine in Radar as well as Apple Mail if the URL is short enough. Using other |
| 10 |
characters such as ] and } wouldn't work either because they would be %-escaped. At that point, we might as well |
| 11 |
as %-escape everything. |
| 12 |
|
| 13 |
Work around the bug by parsing the URL as if it had one extra ')' if the parsing had failed. Also shorten the charts |
| 14 |
page's URL by avoid emitting "-null" for each pane when the pane doesn't have a currently selected point or selection. |
| 15 |
This improves the odds of the entire URL being recognized by various applications. |
| 16 |
|
| 17 |
We could, in theory, implement some sort of a URL shorter but that can wait until when we support real user accounts. |
| 18 |
|
| 19 |
* public/v3/pages/chart-pane.js: |
| 20 |
(ChartPane.prototype.serializeState): Don't serialize the selection or the current point if nothing is selected. |
| 21 |
* public/v3/pages/page-router.js: |
| 22 |
(PageRouter.prototype._deserializeHashQueryValue): Try parsing the value again with one extra ] at the end if |
| 23 |
the JSON parsing had failed. |
| 24 |
|
| 1 |
2016-05-18 Ryosuke Niwa <rniwa@webkit.org> |
25 |
2016-05-18 Ryosuke Niwa <rniwa@webkit.org> |
| 2 |
|
26 |
|
| 3 |
Perf dashboard "Add pane" should list first by test, then by machine |
27 |
Perf dashboard "Add pane" should list first by test, then by machine |