Attachment #206947 for bug #118828

View Details Raw Unified Return to Bug 118828



2013-07-17  Ryosuke Niwa  <rniwa@webkit.org>

        willWriteSelectionToPasteboard and willPerformDragSourceAction editing callbacks are not called for drag and drop
        https://bugs.webkit.org/show_bug.cgi?id=118828

        Reviewed by NOBODY (OOPS!).

        Call these two callbacks when we start a drag and drop.

        No new tests for now but we should start logging these callbacks in DRT and WTR's EditorClients.

        * page/DragController.cpp:
        (WebCore::DragController::startDrag):

2013-07-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Introduce toSVGInlineFlowBox() and use it



    Image* image = getImage(element);
    if (state.type == DragSourceActionSelection) {
        if (!clipboard->hasData()) {
            RefPtr<Range> selectionRange = src->selection()->toNormalizedRange();
            ASSERT(selectionRange);

            src->editor().willWriteSelectionToPasteboard(selectionRange.get());

            if (enclosingTextFormControl(src->selection()->start()))
                clipboard->writePlainText(src->editor().selectedTextForClipboard());
            else
                RefPtr<Range> selectionRange = src->selection()->toNormalizedRange();
                ASSERT(selectionRange);

                clipboard->writeRange(selectionRange.get(), src);

            src->editor().didWriteSelectionToPasteboard();
        }
        m_client->willPerformDragSourceAction(DragSourceActionSelection, dragOrigin, clipboard);
        if (!dragImage) {

Return to Bug 118828

Lines 790-803 bool DragController::startDrag(Frame* sr Source/WebCore/page/DragController.cpp_sec1
- Source/WebCore/page/DragController.cpp -5 / +8 lines
790	Image* image = getImage(element);	790	Image* image = getImage(element);
791	if (state.type == DragSourceActionSelection) {	791	if (state.type == DragSourceActionSelection) {
792	if (!clipboard->hasData()) {	792	if (!clipboard->hasData()) {
		793	RefPtr<Range> selectionRange = src->selection()->toNormalizedRange();
		794	ASSERT(selectionRange);
		795
		796	src->editor().willWriteSelectionToPasteboard(selectionRange.get());
		797
793	if (enclosingTextFormControl(src->selection()->start()))	798	if (enclosingTextFormControl(src->selection()->start()))
794	clipboard->writePlainText(src->editor().selectedTextForClipboard());	799	clipboard->writePlainText(src->editor().selectedTextForClipboard());
795	else {	800	else
796	RefPtr<Range> selectionRange = src->selection()->toNormalizedRange();
797	ASSERT(selectionRange);
798
799	clipboard->writeRange(selectionRange.get(), src);	801	clipboard->writeRange(selectionRange.get(), src);
800	}	802
		803	src->editor().didWriteSelectionToPasteboard();
801	}	804	}
802	m_client->willPerformDragSourceAction(DragSourceActionSelection, dragOrigin, clipboard);	805	m_client->willPerformDragSourceAction(DragSourceActionSelection, dragOrigin, clipboard);
803	if (!dragImage) {	806	if (!dragImage) {

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +14 lines
		1	2013-07-17 Ryosuke Niwa <rniwa@webkit.org>
		2
		3	willWriteSelectionToPasteboard and willPerformDragSourceAction editing callbacks are not called for drag and drop
		4	https://bugs.webkit.org/show_bug.cgi?id=118828
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Call these two callbacks when we start a drag and drop.
		9
		10	No new tests for now but we should start logging these callbacks in DRT and WTR's EditorClients.
		11
		12	* page/DragController.cpp:
		13	(WebCore::DragController::startDrag):
		14
1	2013-07-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>	15	2013-07-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2		16
3	Introduce toSVGInlineFlowBox() and use it	17	Introduce toSVGInlineFlowBox() and use it