Attachment #199528 for bug #115130

View Details Raw Unified Return to Bug 115130

| Differences between



2013-04-24  Brent Fulgham  <bfulgham@webkit.org>

        [Windows, WinCairo] Fix Crash in fast/js/create-lots-of-workers.html
        https://bugs.webkit.org/show_bug.cgi?id=115130

        Reviewed by NOBODY (OOPS!).

        * wtf/RefCounted.h:
        (WTF::RefCountedCustomAllocated::RefCountedCustomAllocated): Add a
        default constructor needed to satisfy Visual Studio.

2013-04-24  Roger Fong  <roger_fong@apple.com>

        Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.

Lines 220-225 public: Source/WTF/wtf/RefCounted.h_sec1
- Source/WTF/wtf/RefCounted.h +1 lines
220	}	220	}
221		221
222	protected:	222	protected:
		223	RefCountedCustomAllocated() { }
223	~RefCountedCustomAllocated()	224	~RefCountedCustomAllocated()
224	{	225	{
225	}	226	}



2013-04-24  Brent Fulgham  <bfulgham@webkit.org>

        [Windows, WinCairo] Fix Crash in fast/js/create-lots-of-workers.html
        https://bugs.webkit.org/show_bug.cgi?id=115130

        Reviewed by NOBODY (OOPS!).

        The DedicatedWorkerContext appears to be getting cast or used in
        a placement new operation that confuses the fastAlloc/fastFree
        system, causing a crash.  This change switches to the system
        allocator to avoid this problem.

        No new tests: Tested by fast/js/create-lots-of-workers.html

        * workers/WorkerContext.h:
        (WorkerContext): Make WorkerContext (and therefore, DedicatedWorkerContext)
        a RefCountedCustomAllocated so that it does not try to use fastMalloc. 

2013-04-24  Beth Dakin  <bdakin@apple.com>

        Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in 



    class WorkerNavigator;
    class WorkerThread;

    class WorkerContext : public RefCountedCustomAllocated<WorkerContext>, public ScriptExecutionContext, public EventTarget {
    public:
        virtual ~WorkerContext();


        WorkerNavigator* optionalNavigator() const { return m_navigator.get(); }
        WorkerLocation* optionalLocation() const { return m_location.get(); }

        using RefCountedCustomAllocated<WorkerContext>::ref;
        using RefCountedCustomAllocated<WorkerContext>::deref;

        bool isClosing() { return m_closing; }


Return to Bug 115130

Lines 55-61 namespace WebCore { Source/WebCore/workers/WorkerContext.h_sec1
- Source/WebCore/workers/WorkerContext.h -3 / +3 lines
55	class WorkerNavigator;	55	class WorkerNavigator;
56	class WorkerThread;	56	class WorkerThread;
57		57
58	class WorkerContext : public RefCounted<WorkerContext>, public ScriptExecutionContext, public EventTarget {	58	class WorkerContext : public RefCountedCustomAllocated<WorkerContext>, public ScriptExecutionContext, public EventTarget {
59	public:	59	public:
60	virtual ~WorkerContext();	60	virtual ~WorkerContext();
61		61
Lines 117-124 namespace WebCore { Source/WebCore/workers/WorkerContext.h_sec2
117	WorkerNavigator* optionalNavigator() const { return m_navigator.get(); }	117	WorkerNavigator* optionalNavigator() const { return m_navigator.get(); }
118	WorkerLocation* optionalLocation() const { return m_location.get(); }	118	WorkerLocation* optionalLocation() const { return m_location.get(); }
119		119
120	using RefCounted<WorkerContext>::ref;	120	using RefCountedCustomAllocated<WorkerContext>::ref;
121	using RefCounted<WorkerContext>::deref;	121	using RefCountedCustomAllocated<WorkerContext>::deref;
122		122
123	bool isClosing() { return m_closing; }	123	bool isClosing() { return m_closing; }
124		124

Lines 1-3 Source/WTF/ChangeLog_sec1
- Source/WTF/ChangeLog +11 lines
		1	2013-04-24 Brent Fulgham <bfulgham@webkit.org>
		2
		3	[Windows, WinCairo] Fix Crash in fast/js/create-lots-of-workers.html
		4	https://bugs.webkit.org/show_bug.cgi?id=115130
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* wtf/RefCounted.h:
		9	(WTF::RefCountedCustomAllocated::RefCountedCustomAllocated): Add a
		10	default constructor needed to satisfy Visual Studio.
		11
1	2013-04-24 Roger Fong <roger_fong@apple.com>	12	2013-04-24 Roger Fong <roger_fong@apple.com>
2		13
3	Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.	14	Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +18 lines
		1	2013-04-24 Brent Fulgham <bfulgham@webkit.org>
		2
		3	[Windows, WinCairo] Fix Crash in fast/js/create-lots-of-workers.html
		4	https://bugs.webkit.org/show_bug.cgi?id=115130
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	The DedicatedWorkerContext appears to be getting cast or used in
		9	a placement new operation that confuses the fastAlloc/fastFree
		10	system, causing a crash. This change switches to the system
		11	allocator to avoid this problem.
		12
		13	No new tests: Tested by fast/js/create-lots-of-workers.html
		14
		15	* workers/WorkerContext.h:
		16	(WorkerContext): Make WorkerContext (and therefore, DedicatedWorkerContext)
		17	a RefCountedCustomAllocated so that it does not try to use fastMalloc.
		18
1	2013-04-24 Beth Dakin <bdakin@apple.com>	19	2013-04-24 Beth Dakin <bdakin@apple.com>
2		20
3	Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in	21	Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in