Attachment #188128 for bug #109721

View Details Raw Unified Return to Bug 109721



2013-02-13  Arko Saha  <arko@motorola.com>

        [Microdata] HTMLPropertiesCollection code cleanup
        https://bugs.webkit.org/show_bug.cgi?id=109721

        Reviewed by NOBODY (OOPS!).

        Removed forward declaration of DOMStringList class.
        Removed unused findRefElements() method declaration.
        Also Removed unused parameter Element* from updatePropertyCache() method.

        No new test since no change in behavior.

        * html/HTMLPropertiesCollection.cpp:
        (WebCore::HTMLPropertiesCollection::updateNameCache):
        * html/HTMLPropertiesCollection.h:
        (WebCore):
        (HTMLPropertiesCollection):
        (WebCore::HTMLPropertiesCollection::updatePropertyCache):

2013-02-13  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Remove remaining dead code from the GLib unicode backend



#include "HTMLPropertiesCollection.h"

#include "DOMSettableTokenList.h"
#include "DOMStringList.h"
#include "HTMLElement.h"
#include "HTMLNames.h"
#include "Node.h"

        for (HTMLElement* element = virtualItemAfter(refElement, 0); element; element = virtualItemAfter(refElement, element)) {
            DOMSettableTokenList* itemProperty = element->itemProp();
            for (unsigned propertyIndex = 0; propertyIndex < itemProperty->length(); ++propertyIndex)
                updatePropertyCache(itemProperty->item(propertyIndex));
        }
    }





namespace WebCore {

class DOMStringList;
class PropertyNodeList;

class HTMLPropertiesCollection : public HTMLCollection {

private:
    HTMLPropertiesCollection(Node*);

    Node* findRefElements(Node* previous) const;

    virtual Element* virtualItemAfter(unsigned& offsetInArray, Element*) const OVERRIDE;
    HTMLElement* virtualItemAfter(HTMLElement* base, Element* previous) const;

    void updateNameCache() const;

    void updatePropertyCache(const AtomicString& propertyName) const
    {
        if (!m_propertyNames)
            m_propertyNames = DOMStringList::create();

Return to Bug 109721

Lines 35-41 Source/WebCore/html/HTMLPropertiesCollection.cpp_sec1
- Source/WebCore/html/HTMLPropertiesCollection.cpp -2 / +1 lines
35	#include "HTMLPropertiesCollection.h"	35	#include "HTMLPropertiesCollection.h"
36		36
37	#include "DOMSettableTokenList.h"	37	#include "DOMSettableTokenList.h"
38	#include "DOMStringList.h"
39	#include "HTMLElement.h"	38	#include "HTMLElement.h"
40	#include "HTMLNames.h"	39	#include "HTMLNames.h"
41	#include "Node.h"	40	#include "Node.h"
Lines 122-128 void HTMLPropertiesCollection::updateNam Source/WebCore/html/HTMLPropertiesCollection.cpp_sec2
122	for (HTMLElement* element = virtualItemAfter(refElement, 0); element; element = virtualItemAfter(refElement, element)) {	121	for (HTMLElement* element = virtualItemAfter(refElement, 0); element; element = virtualItemAfter(refElement, element)) {
123	DOMSettableTokenList* itemProperty = element->itemProp();	122	DOMSettableTokenList* itemProperty = element->itemProp();
124	for (unsigned propertyIndex = 0; propertyIndex < itemProperty->length(); ++propertyIndex)	123	for (unsigned propertyIndex = 0; propertyIndex < itemProperty->length(); ++propertyIndex)
125	updatePropertyCache(element, itemProperty->item(propertyIndex));	124	updatePropertyCache(itemProperty->item(propertyIndex));
126	}	125	}
127	}	126	}
128		127

Lines 38-44 Source/WebCore/html/HTMLPropertiesCollection.h_sec1
- Source/WebCore/html/HTMLPropertiesCollection.h -4 / +1 lines
38		38
39	namespace WebCore {	39	namespace WebCore {
40		40
41	class DOMStringList;
42	class PropertyNodeList;	41	class PropertyNodeList;
43		42
44	class HTMLPropertiesCollection : public HTMLCollection {	43	class HTMLPropertiesCollection : public HTMLCollection {
Lines 61-74 public: Source/WebCore/html/HTMLPropertiesCollection.h_sec2
61	private:	60	private:
62	HTMLPropertiesCollection(Node*);	61	HTMLPropertiesCollection(Node*);
63		62
64	Node* findRefElements(Node* previous) const;
65
66	virtual Element* virtualItemAfter(unsigned& offsetInArray, Element*) const OVERRIDE;	63	virtual Element* virtualItemAfter(unsigned& offsetInArray, Element*) const OVERRIDE;
67	HTMLElement* virtualItemAfter(HTMLElement* base, Element* previous) const;	64	HTMLElement* virtualItemAfter(HTMLElement* base, Element* previous) const;
68		65
69	void updateNameCache() const;	66	void updateNameCache() const;
70		67
71	void updatePropertyCache(Element*, const AtomicString& propertyName) const	68	void updatePropertyCache(const AtomicString& propertyName) const
72	{	69	{
73	if (!m_propertyNames)	70	if (!m_propertyNames)
74	m_propertyNames = DOMStringList::create();	71	m_propertyNames = DOMStringList::create();

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +20 lines
		1	2013-02-13 Arko Saha <arko@motorola.com>
		2
		3	[Microdata] HTMLPropertiesCollection code cleanup
		4	https://bugs.webkit.org/show_bug.cgi?id=109721
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Removed forward declaration of DOMStringList class.
		9	Removed unused findRefElements() method declaration.
		10	Also Removed unused parameter Element* from updatePropertyCache() method.
		11
		12	No new test since no change in behavior.
		13
		14	* html/HTMLPropertiesCollection.cpp:
		15	(WebCore::HTMLPropertiesCollection::updateNameCache):
		16	* html/HTMLPropertiesCollection.h:
		17	(WebCore):
		18	(HTMLPropertiesCollection):
		19	(WebCore::HTMLPropertiesCollection::updatePropertyCache):
		20
1	2013-02-13 Martin Robinson <mrobinson@igalia.com>	21	2013-02-13 Martin Robinson <mrobinson@igalia.com>
2		22
3	[GTK] Remove remaining dead code from the GLib unicode backend	23	[GTK] Remove remaining dead code from the GLib unicode backend