Attachment #182635 for bug #106832

View Details Raw Unified Return to Bug 106832



2013-01-14  Ojan Vafai  <ojan@chromium.org>

        Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
        https://bugs.webkit.org/show_bug.cgi?id=106832

        Reviewed by NOBODY (OOPS!).

        These are both called from locations that either set these bits themselves
        or clearly don't need these bits set (e.g. computePreferredLogicalWidths).

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::splitColumn):
        (WebCore::RenderTable::appendColumn):

2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Move AudioDestinationChromium into WebCore



    }

    m_columnPos.grow(numEffCols() + 1);
    setNeedsLayoutAndPrefWidthsRecalc();
}

void RenderTable::appendColumn(unsigned span)

    }

    m_columnPos.grow(numEffCols() + 1);
    setNeedsLayoutAndPrefWidthsRecalc();
}

RenderTableCol* RenderTable::firstColumn() const

Return to Bug 106832

Lines 758-764 void RenderTable::splitColumn(unsigned position, unsigned firstSpan) a/Source/WebCore/rendering/RenderTable.cpp_sec1
- a/Source/WebCore/rendering/RenderTable.cpp -2 lines
758	}	758	}
759		759
760	m_columnPos.grow(numEffCols() + 1);	760	m_columnPos.grow(numEffCols() + 1);
761	setNeedsLayoutAndPrefWidthsRecalc();
762	}	761	}
763		762
764	void RenderTable::appendColumn(unsigned span)	763	void RenderTable::appendColumn(unsigned span)
Lines 780-786 void RenderTable::appendColumn(unsigned span) a/Source/WebCore/rendering/RenderTable.cpp_sec2
780	}	779	}
781		780
782	m_columnPos.grow(numEffCols() + 1);	781	m_columnPos.grow(numEffCols() + 1);
783	setNeedsLayoutAndPrefWidthsRecalc();
784	}	782	}
785		783
786	RenderTableCol* RenderTable::firstColumn() const	784	RenderTableCol* RenderTable::firstColumn() const

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +14 lines
		1	2013-01-14 Ojan Vafai <ojan@chromium.org>
		2
		3	Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
		4	https://bugs.webkit.org/show_bug.cgi?id=106832
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	These are both called from locations that either set these bits themselves
		9	or clearly don't need these bits set (e.g. computePreferredLogicalWidths).
		10
		11	* rendering/RenderTable.cpp:
		12	(WebCore::RenderTable::splitColumn):
		13	(WebCore::RenderTable::appendColumn):
		14
1	2013-01-14 Mark Pilgrim <pilgrim@chromium.org>	15	2013-01-14 Mark Pilgrim <pilgrim@chromium.org>
2		16
3	[Chromium] Move AudioDestinationChromium into WebCore	17	[Chromium] Move AudioDestinationChromium into WebCore