Attachment #154224 for bug #91592

View Details Raw Unified Return to Bug 91592

| Differences between



2012-07-24  Seokju Kwon  <seokju.kwon@samsung.com>

        [EFL] Highlight the element under mouse on web inspector
        https://bugs.webkit.org/show_bug.cgi?id=91592

        Reviewed by NOBODY (OOPS!).

        Implement highlighting the nodes when using the inspector.

        * WebCoreSupport/InspectorClientEfl.cpp:
        (WebCore::InspectorClientEfl::highlight):
        (WebCore::InspectorClientEfl::hideHighlight):
        (WebCore::InspectorClientEfl::invalidateView):
        (WebCore):
        * WebCoreSupport/InspectorClientEfl.h:
        (InspectorClientEfl):
        * ewk/ewk_paint_context.cpp:
        (ewk_paint_context_paint_contents):

2012-07-23  Pierre Rossi  <pierre.rossi@gmail.com>

        Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client




void InspectorClientEfl::highlight()
{
    invalidateView(m_inspectedView);
}

void InspectorClientEfl::hideHighlight()
{
    invalidateView(m_inspectedView);
}

bool InspectorClientEfl::sendMessageToFrontend(const String& message)

    return inspectorFilesPath;
}

void InspectorClientEfl::invalidateView(Evas_Object* webView)
{
    Evas_Coord width, height;
    Evas_Object* mainFrame = ewk_view_frame_main_get(webView);
    if (mainFrame && ewk_frame_contents_size_get(mainFrame, &width, &height)) {
        WebCore::Page* page = EWKPrivate::corePage(webView);
        if (page)
            page->mainFrame()->view()->invalidateRect(WebCore::IntRect(0, 0, width, height));
    }
}

InspectorFrontendClientEfl::InspectorFrontendClientEfl(Evas_Object* inspectedView, Evas_Object* inspectorView, InspectorClientEfl* inspectorClient)
    : InspectorFrontendClientLocal(EWKPrivate::corePage(inspectedView)->inspectorController(), EWKPrivate::corePage(inspectorView), adoptPtr(new InspectorFrontendSettingsEfl()))
    , m_inspectedView(inspectedView)

Lines 62-67 public: a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h_sec1
- a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h +1 lines
62		62
63	void releaseFrontendPage();	63	void releaseFrontendPage();
64	String inspectorFilesPath();	64	String inspectorFilesPath();
		65	void invalidateView(Evas_Object*);
65		66
66	private:	67	private:
67	Evas_Object* m_inspectedView;	68	Evas_Object* m_inspectedView;

Lines 20-25 a/Source/WebKit/efl/ewk/ewk_paint_context.cpp_sec1
- a/Source/WebKit/efl/ewk/ewk_paint_context.cpp +13 lines
20		20
21	#include "config.h"	21	#include "config.h"
22		22
		23	#if ENABLE(INSPECTOR)
		24	#include "InspectorController.h"
		25	#include "Page.h"
		26	#endif
23	#include "ewk_paint_context_private.h"	27	#include "ewk_paint_context_private.h"
24	#include "ewk_private.h"	28	#include "ewk_private.h"
25		29
Lines 169-172 void ewk_paint_context_paint_contents(Ewk_Paint_Context* context, WebCore::Frame a/Source/WebKit/efl/ewk/ewk_paint_context.cpp_sec2
169	if (view->isTransparent())	173	if (view->isTransparent())
170	context->graphicContext->clearRect(paintArea);	174	context->graphicContext->clearRect(paintArea);
171	view->paintContents(context->graphicContext.get(), paintArea);	175	view->paintContents(context->graphicContext.get(), paintArea);
		176
		177	#if ENABLE(INSPECTOR)
		178	WebCore::Page* page = view->frame()->page();
		179	if (page) {
		180	WebCore::InspectorController* controller = page->inspectorController();
		181	if (controller->highlightedNode())
		182	controller->drawHighlight(*context->graphicContext);
		183	}
		184	#endif
172	}	185	}

Return to Bug 91592

Lines 107-118 void InspectorClientEfl::bringFrontendToFront() a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp_sec1
- a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp -2 / +13 lines
107		107
108	void InspectorClientEfl::highlight()	108	void InspectorClientEfl::highlight()
109	{	109	{
110	notImplemented();	110	invalidateView(m_inspectedView);
111	}	111	}
112		112
113	void InspectorClientEfl::hideHighlight()	113	void InspectorClientEfl::hideHighlight()
114	{	114	{
115	notImplemented();	115	invalidateView(m_inspectedView);
116	}	116	}
117		117
118	bool InspectorClientEfl::sendMessageToFrontend(const String& message)	118	bool InspectorClientEfl::sendMessageToFrontend(const String& message)
Lines 136-141 String InspectorClientEfl::inspectorFilesPath() a/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp_sec2
136	return inspectorFilesPath;	136	return inspectorFilesPath;
137	}	137	}
138		138
		139	void InspectorClientEfl::invalidateView(Evas_Object* webView)
		140	{
		141	Evas_Coord width, height;
		142	Evas_Object* mainFrame = ewk_view_frame_main_get(webView);
		143	if (mainFrame && ewk_frame_contents_size_get(mainFrame, &width, &height)) {
		144	WebCore::Page* page = EWKPrivate::corePage(webView);
		145	if (page)
		146	page->mainFrame()->view()->invalidateRect(WebCore::IntRect(0, 0, width, height));
		147	}
		148	}
		149
139	InspectorFrontendClientEfl::InspectorFrontendClientEfl(Evas_Object* inspectedView, Evas_Object* inspectorView, InspectorClientEfl* inspectorClient)	150	InspectorFrontendClientEfl::InspectorFrontendClientEfl(Evas_Object* inspectedView, Evas_Object* inspectorView, InspectorClientEfl* inspectorClient)
140	: InspectorFrontendClientLocal(EWKPrivate::corePage(inspectedView)->inspectorController(), EWKPrivate::corePage(inspectorView), adoptPtr(new InspectorFrontendSettingsEfl()))	151	: InspectorFrontendClientLocal(EWKPrivate::corePage(inspectedView)->inspectorController(), EWKPrivate::corePage(inspectorView), adoptPtr(new InspectorFrontendSettingsEfl()))
141	, m_inspectedView(inspectedView)	152	, m_inspectedView(inspectedView)

Lines 1-3 a/Source/WebKit/efl/ChangeLog_sec1
- a/Source/WebKit/efl/ChangeLog +19 lines
		1	2012-07-24 Seokju Kwon <seokju.kwon@samsung.com>
		2
		3	[EFL] Highlight the element under mouse on web inspector
		4	https://bugs.webkit.org/show_bug.cgi?id=91592
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Implement highlighting the nodes when using the inspector.
		9
		10	* WebCoreSupport/InspectorClientEfl.cpp:
		11	(WebCore::InspectorClientEfl::highlight):
		12	(WebCore::InspectorClientEfl::hideHighlight):
		13	(WebCore::InspectorClientEfl::invalidateView):
		14	(WebCore):
		15	* WebCoreSupport/InspectorClientEfl.h:
		16	(InspectorClientEfl):
		17	* ewk/ewk_paint_context.cpp:
		18	(ewk_paint_context_paint_contents):
		19
1	2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>	20	2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
2		21
3	Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client	22	Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client