Attachment #148220 for bug #89408

View Details Raw Unified Return to Bug 89408



2012-06-18  Simon Fraser  <simon.fraser@apple.com>

        Provide bug links for suspicious commits
        https://bugs.webkit.org/show_bug.cgi?id=89408
        
        Reviewed by NOBODY (OOPS!).

        Add links to bugs for the suspicious commits if we have bug data.

        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
        (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
        (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):

2012-06-18  Simon Fraser  <simon.fraser@apple.com>

        Minor fix suggested by Adam Barth.

        Use $(this._what).empty(); rather than removing children one at a time.

Lines 70-75 var g_searchCache = new base.AsynchronousCache(function(query, callback) { a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js_sec1
- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js +5 lines
70	});	70	});
71	});	71	});
72		72
		73	bugzilla.bugURL = function(bugNumber)
		74	{
		75	return config.kBugzillaURL + '/show_bug.cgi?id=' + bugNumber;
		76	};
		77
73	bugzilla.quickSearch = function(query, callback)	78	bugzilla.quickSearch = function(query, callback)
74	{	79	{
75	g_searchCache.get(query, callback);	80	g_searchCache.get(query, callback);



        this._addDetail('summary', commitData);
        this._addDetail('author', commitData);
        this._addDetail('reviewer', commitData);
        this._addDetail('bugID', commitData, bugzilla.bugURL);
    },
    hasRevision: function(revision)
    {
        return this._revision == revision;
    },
    _addDetail: function(part, commitData, linkFunction)
    {
        var content = commitData[part];
        if (!content)


        var span = this._details.appendChild(document.createElement('span'));
        span.className = part;
        
        if (linkFunction) {
            var link = base.createLinkNode(linkFunction(content), content, '_blank');
            span.appendChild(link);
        } else
            span.textContent = content;
    }
});




            color: Gray;
        }

        ol.notifications>li ul.causes>li>div.description>span>span.bugID::before {
            content: 'bug ';
            padding-left: 8px;
        }

        ol.notifications>li ul.causes>li>div.description>span>span.bugID>a {
            cursor: hand;
            pointer-events: auto;
        }

        ol.notifications>li ul.causes>li>div.description>span>span.reviewer::before {
            content: ' (';
        }

Return to Bug 89408

Lines 117-128 ui.notifications.SuspiciousCommit = base.extends(Cause, { a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js_sec1
- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js -2 / +8 lines
117	this._addDetail('summary', commitData);	117	this._addDetail('summary', commitData);
118	this._addDetail('author', commitData);	118	this._addDetail('author', commitData);
119	this._addDetail('reviewer', commitData);	119	this._addDetail('reviewer', commitData);
		120	this._addDetail('bugID', commitData, bugzilla.bugURL);
120	},	121	},
121	hasRevision: function(revision)	122	hasRevision: function(revision)
122	{	123	{
123	return this._revision == revision;	124	return this._revision == revision;
124	},	125	},
125	_addDetail: function(part, commitData)	126	_addDetail: function(part, commitData, linkFunction)
126	{	127	{
127	var content = commitData[part];	128	var content = commitData[part];
128	if (!content)	129	if (!content)
Lines 130-136 ui.notifications.SuspiciousCommit = base.extends(Cause, { a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js_sec2
130		131
131	var span = this._details.appendChild(document.createElement('span'));	132	var span = this._details.appendChild(document.createElement('span'));
132	span.className = part;	133	span.className = part;
133	span.textContent = content;	134
		135	if (linkFunction) {
		136	var link = base.createLinkNode(linkFunction(content), content, '_blank');
		137	span.appendChild(link);
		138	} else
		139	span.textContent = content;
134	}	140	}
135	});	141	});
136		142

Lines 146-151 ol.notifications>li ul.causes>li>ul.actions { a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css_sec1
- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css +10 lines
146	color: Gray;	146	color: Gray;
147	}	147	}
148		148
		149	ol.notifications>li ul.causes>li>div.description>span>span.bugID::before {
		150	content: 'bug ';
		151	padding-left: 8px;
		152	}
		153
		154	ol.notifications>li ul.causes>li>div.description>span>span.bugID>a {
		155	cursor: hand;
		156	pointer-events: auto;
		157	}
		158
149	ol.notifications>li ul.causes>li>div.description>span>span.reviewer::before {	159	ol.notifications>li ul.causes>li>div.description>span>span.reviewer::before {
150	content: ' (';	160	content: ' (';
151	}	161	}

Lines 1-5 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +15 lines
1	2012-06-18 Simon Fraser <simon.fraser@apple.com>	1	2012-06-18 Simon Fraser <simon.fraser@apple.com>
2		2
		3	Provide bug links for suspicious commits
		4	https://bugs.webkit.org/show_bug.cgi?id=89408
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Add links to bugs for the suspicious commits if we have bug data.
		9
		10	* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
		11	* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
		12	* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
		13	(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
		14	(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
		15
		16	2012-06-18 Simon Fraser <simon.fraser@apple.com>
		17
3	Minor fix suggested by Adam Barth.	18	Minor fix suggested by Adam Barth.
4		19
5	Use $(this._what).empty(); rather than removing children one at a time.	20	Use $(this._what).empty(); rather than removing children one at a time.