Attachment #145870 for bug #88197

View Details Raw Unified Return to Bug 88197

| Differences between



2012-06-05  Joe Thomas  <joethomas@motorola.com>

        ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
        https://bugs.webkit.org/show_bug.cgi?id=88197

        Reviewed by NOBODY (OOPS!).

        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
        to true while it handles width/height of Percentage types.

        Test: svg/in-html/svg-assert-failure-percentage.html

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):

2012-06-05  Greg Billock  <gbillock@google.com>

        New constructor for WebIntent to be used for delivery



            intrinsicRatio = 1;
        return;
    }

    // This code path can't yield percentage intrinsic sizes, assert that.
    computeIntrinsicRatioInformation(intrinsicSize, intrinsicRatio, isPercentageIntrinsicSize);
    ASSERT(!isPercentageIntrinsicSize);
}

void RenderReplaced::computeIntrinsicRatioInformation(FloatSize& intrinsicSize, double& intrinsicRatio, bool& isPercentageIntrinsicSize) const



2012-06-05  Joe Thomas  <joethomas@motorola.com>

        ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
        https://bugs.webkit.org/show_bug.cgi?id=88197

        Reviewed by NOBODY (OOPS!).

        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
        to true while it handles width/height of Percentage types.

        * svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
        * svg/in-html/svg-assert-failure-percentage.html: Added.

2012-06-05  Emil A Eklund  <eae@chromium.org>

        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test

Line 0 LayoutTests/svg/in-html/svg-assert-failure-percentage-expected.txt_sec1
- LayoutTests/svg/in-html/svg-assert-failure-percentage-expected.txt +1 lines
		1	NO Assert!



<!DOCTYPE html>
<html>
<script>
if (window.layoutTestController)
    layoutTestController.dumpAsText();
</script>
<svg style= "max-height:5%"> </svg>
NO Assert!
</html>

Return to Bug 88197

Lines 287-296 void RenderReplaced::computeIntrinsicRat Source/WebCore/rendering/RenderReplaced.cpp_sec1
- Source/WebCore/rendering/RenderReplaced.cpp -3 lines
287	intrinsicRatio = 1;	287	intrinsicRatio = 1;
288	return;	288	return;
289	}	289	}
290
291	// This code path can't yield percentage intrinsic sizes, assert that.
292	computeIntrinsicRatioInformation(intrinsicSize, intrinsicRatio, isPercentageIntrinsicSize);	290	computeIntrinsicRatioInformation(intrinsicSize, intrinsicRatio, isPercentageIntrinsicSize);
293	ASSERT(!isPercentageIntrinsicSize);
294	}	291	}
295		292
296	void RenderReplaced::computeIntrinsicRatioInformation(FloatSize& intrinsicSize, double& intrinsicRatio, bool& isPercentageIntrinsicSize) const	293	void RenderReplaced::computeIntrinsicRatioInformation(FloatSize& intrinsicSize, double& intrinsicRatio, bool& isPercentageIntrinsicSize) const

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +15 lines
		1	2012-06-05 Joe Thomas <joethomas@motorola.com>
		2
		3	ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
		4	https://bugs.webkit.org/show_bug.cgi?id=88197
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
		9	to true while it handles width/height of Percentage types.
		10
		11	Test: svg/in-html/svg-assert-failure-percentage.html
		12
		13	* rendering/RenderReplaced.cpp:
		14	(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):
		15
1	2012-06-05 Greg Billock <gbillock@google.com>	16	2012-06-05 Greg Billock <gbillock@google.com>
2		17
3	New constructor for WebIntent to be used for delivery	18	New constructor for WebIntent to be used for delivery

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +13 lines
		1	2012-06-05 Joe Thomas <joethomas@motorola.com>
		2
		3	ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
		4	https://bugs.webkit.org/show_bug.cgi?id=88197
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
		9	to true while it handles width/height of Percentage types.
		10
		11	* svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
		12	* svg/in-html/svg-assert-failure-percentage.html: Added.
		13
1	2012-06-05 Emil A Eklund <eae@chromium.org>	14	2012-06-05 Emil A Eklund <eae@chromium.org>
2		15
3	Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test	16	Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test

Line 0 LayoutTests/svg/in-html/svg-assert-failure-percentage.html_sec1
- LayoutTests/svg/in-html/svg-assert-failure-percentage.html +9 lines
	1	<!DOCTYPE html>
	2	<html>
	3	<script>
	4	if (window.layoutTestController)
	5	layoutTestController.dumpAsText();
	6	</script>
	7	<svg style= "max-height:5%"> </svg>
	8	NO Assert!
	9	</html>