Attachment #131276 for bug #80804

View Details Raw Unified Return to Bug 80804

| Differences between



2012-03-11  Shawn Singh  <shawnsingh@chromium.org>

        Fix regression on fast/table/table-row-compositing-repaint-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=80804

        Reviewed by NOBODY (OOPS!).

        Covered by existing tests.

        http://trac.webkit.org/changeset/110401/ accidentally caused
        fast/table/table-row-compositing-repaint-crash.html to fail.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateBacking):

2012-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r110359.



            // The RenderLayer's needs to update repaint rects here, because the target
            // repaintContainer may have changed after becoming a composited layer.
            // https://bugs.webkit.org/show_bug.cgi?id=80641
            if (layer->parent())
                layer->computeRepaintRects();

#if PLATFORM(MAC) && USE(CA)
            Settings* settings = m_renderView->document()->settings();

Return to Bug 80804

Lines 420-426 bool RenderLayerCompositor::updateBacking(RenderLayer* layer, CompositingChangeR a/Source/WebCore/rendering/RenderLayerCompositor.cpp_sec1
- a/Source/WebCore/rendering/RenderLayerCompositor.cpp -1 / +2 lines
420	// The RenderLayer's needs to update repaint rects here, because the target	420	// The RenderLayer's needs to update repaint rects here, because the target
421	// repaintContainer may have changed after becoming a composited layer.	421	// repaintContainer may have changed after becoming a composited layer.
422	// https://bugs.webkit.org/show_bug.cgi?id=80641	422	// https://bugs.webkit.org/show_bug.cgi?id=80641
423	layer->computeRepaintRects();	423	if (layer->parent())
		424	layer->computeRepaintRects();
424		425
425	#if PLATFORM(MAC) && USE(CA)	426	#if PLATFORM(MAC) && USE(CA)
426	Settings* settings = m_renderView->document()->settings();	427	Settings* settings = m_renderView->document()->settings();

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +15 lines
		1	2012-03-11 Shawn Singh <shawnsingh@chromium.org>
		2
		3	Fix regression on fast/table/table-row-compositing-repaint-crash.html
		4	https://bugs.webkit.org/show_bug.cgi?id=80804
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Covered by existing tests.
		9
		10	http://trac.webkit.org/changeset/110401/ accidentally caused
		11	fast/table/table-row-compositing-repaint-crash.html to fail.
		12
		13	* rendering/RenderLayerCompositor.cpp:
		14	(WebCore::RenderLayerCompositor::updateBacking):
		15
1	2012-03-11 Sheriff Bot <webkit.review.bot@gmail.com>	16	2012-03-11 Sheriff Bot <webkit.review.bot@gmail.com>
2		17
3	Unreviewed, rolling out r110359.	18	Unreviewed, rolling out r110359.