Attachment #126035 for bug #77724

View Details Raw Unified Return to Bug 77724

| Differences between



2012-02-08  Matt Falkenhagen  <falken@chromium.org>

        Improve http-equiv content-language parsing
        https://bugs.webkit.org/show_bug.cgi?id=77724

        Reviewed by NOBODY (OOPS!).

        Add more tests for mapping http-equiv content-language to -webkit-locale. The desired behavior of some
        of these is not yet decided, so some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

        * fast/text/content-language-case-insensitivity-expected.txt:
        * fast/text/content-language-case-insensitivity.html: Style fixes.
        * fast/text/content-language-empty-expected.txt: Added.
        * fast/text/content-language-empty.html: Added.
        * fast/text/content-language-late-expected.txt: Added.
        * fast/text/content-language-late.html: Added.
        * fast/text/content-language-mapped-to-webkit-locale-expected.txt: 
        * fast/text/content-language-mapped-to-webkit-locale.html: Style fixes.
        * fast/text/content-language-multiple-expected.txt: Added.
        * fast/text/content-language-multiple.html: Added.
        * fast/text/content-language-no-content-expected.txt: Added.
        * fast/text/content-language-no-content.html: Added.
        * fast/text/content-language-only-whitespace-expected.txt: Added.
        * fast/text/content-language-only-whitespace.html: Added.
        * fast/text/content-language-with-whitespace-expected.txt: Added.
        * fast/text/content-language-with-whitespace.html: Added.

2012-02-07  Erik Arvidsson  <arv@chromium.org>

        [V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference

Lines 1-6 a/LayoutTests/fast/text/content-language-case-insensitivity-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-case-insensitivity-expected.txt -1 / +1 lines
1	Test for bug 76701: map content-language to -webkit-locale. This particular test tests that the matching of the http-equiv attribute to the content-language state is case insensitive.	1	Test for bug 76701: map content-language to -webkit-locale. This particular test tests that the matching of the http-equiv attribute to the content-language state is case insensitive.
2		2
3	PASS languageOfNode('x1') is "ja-JP"	3	PASS languageOfNode('x') is "ja-JP"
4	PASS successfullyParsed is true	4	PASS successfullyParsed is true
5		5
6	TEST COMPLETE	6	TEST COMPLETE



insensitive.
</p>
<div id="console"></div>
<div id="x"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "ja-JP");

var successfullyParsed = true;
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>



Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language of empty string is ignored. This expectation may change, see bug. HTML5 decrees that the meta element be ignored in case of the empty string. It's unclear what other browsers do.

FAIL languageOfNode('x') should be auto. Was ''.
PASS languageOfNode('y') is "ar"
PASS successfullyParsed is true

TEST COMPLETE




<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-language" content="">
<link rel="stylesheet" href="../js/resources/js-test-style.css">
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map HTTP-EQUIV content-language to -webkit-locale. This particular test tests
that a content-language of empty string is ignored. This expectation may
change, see bug. HTML5 decrees that the meta element be ignored in case of the
empty string. It's unclear what other browsers do.
</p>
<div id="console"></div>
<div id="x"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "auto");
shouldBeEqualToString("languageOfNode('y')", "ar");
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
</html>



Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language is used even if it appears at the end of the document. This expectation may change, see bug. According to the HTML 5 spec, a meta element should be processed when it is inserted into the document, regardless of where. IE and Firefox also seem to process the content-language at the end of the document.

FAIL languageOfNode('x') should be ja-JP. Was auto.
PASS languageOfNode('y') is "ar"
PASS successfullyParsed is true

TEST COMPLETE




<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<link rel="stylesheet" href="../js/resources/js-test-style.css">
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map HTTP-EQUIV content-language to -webkit-locale. This particular test tests
that a content-language is used even if it appears at the end of the document.
This expectation may change, see bug.  According to the HTML 5 spec, a meta
element should be processed when it is inserted into the document, regardless
of where. IE and Firefox also seem to process the content-language at the end
of the document.
</p>
<div id="console"></div>
<div id="x"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "ja-JP");
shouldBeEqualToString("languageOfNode('y')", "ar");
</script>
<script src="../js/resources/js-test-post.js"></script>
<meta http-equiv="content-language" content="ja-JP">
</body>
</html>

Lines 1-7 a/LayoutTests/fast/text/content-language-mapped-to-webkit-locale-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-mapped-to-webkit-locale-expected.txt -2 / +2 lines
1	Test for bug 76701: map content-language to -webkit-locale.	1	Test for bug 76701: map content-language to -webkit-locale.
2		2
3	PASS languageOfNode('x1') is "zh-CN"	3	PASS languageOfNode('x') is "zh-CN"
4	PASS languageOfNode('m1') is "ar"	4	PASS languageOfNode('y') is "ar"
5	PASS successfullyParsed is true	5	PASS successfullyParsed is true
6		6
7	TEST COMPLETE	7	TEST COMPLETE



<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map content-language to -webkit-locale.</p>
<div id="console"></div>
<div id="x"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "zh-CN");
shouldBeEqualToString("languageOfNode('y')", "ar");

var successfullyParsed = true;
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>



Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that in the event of multiple content-languages, the final content-language is used as the pragma-set default language. This expectation may change, see bug. The HTML5 spec decrees that the first successfully processed one be used. Firefox and IE seem to use the final one.

PASS languageOfNode('x') is "zh_CN"
PASS languageOfNode('y') is "ar"
PASS successfullyParsed is true

TEST COMPLETE




<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-language" content="   ">
<meta http-equiv="content-language" content="ja_JP">
<meta http-equiv="content-language" content="zh_CN">
<link rel="stylesheet" href="../js/resources/js-test-style.css">
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map HTTP-EQUIV content-language to -webkit-locale. This particular test tests
that in the event of multiple content-languages, the final content-language is
used as the pragma-set default language. This expectation may change, see bug.
The HTML5 spec decrees that the first successfully processed one be used.
Firefox and IE seem to use the final one.
</p>
<div id="console"></div>
<div id="x" lang="zh_CN"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "zh_CN");
shouldBeEqualToString("languageOfNode('y')", "ar");
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
</html>



Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language with missing content is effectively ignored. This expectation may change, see comments in bug.

PASS languageOfNode('x') is "auto"
PASS languageOfNode('y') is "ar"
PASS successfullyParsed is true

TEST COMPLETE




<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-language">
<link rel="stylesheet" href="../js/resources/js-test-style.css">
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that
a content-language with missing content is effectively ignored. This expectation
may change, see comments in bug.
</p>
<div id="console"></div>
<div id="x"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "auto");
shouldBeEqualToString("languageOfNode('y')", "ar");
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
</html>



Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language with whitespace-only content is ignored. This expectation may change, see bug. HTML5 decrees that the meta element be ignored in case of whitespace only content. It's unclear what other browsers do.

FAIL languageOfNode('x') should be auto. Was '  \9\a  '.
PASS languageOfNode('y') is "ar"
PASS successfullyParsed is true

TEST COMPLETE




<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-language" content="  	
 ">
<link rel="stylesheet" href="../js/resources/js-test-style.css">
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map HTTP-EQUIV content-language to -webkit-locale. This particular test tests
that a content-language with whitespace-only content is ignored. This
expectation may change, see bug. HTML5 decrees that the meta element be ignored
in case of whitespace only content.  It's unclear what other browsers do.</p>
<div id="console"></div>
<div id="x"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "auto");
shouldBeEqualToString("languageOfNode('y')", "ar");
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
</html>



Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that the the pragma-set default language is set to the first sequence of non-whitespace characters of the content-language content. This expectation may change, see bug. This expectation is as per the HTML 5 spec. It appears that Firefox does not exactly do this, but trims the leading and trailing whitespace. It's unclear what IE does.

FAIL languageOfNode('x') should be ja_JP. Was '  \a\9\9ja-JP   \9  zh_CN \9\a\a\9\9'.
PASS languageOfNode('y') is "ar"
PASS successfullyParsed is true

TEST COMPLETE




<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-language" content="  
		ja-JP   	 zh_CN 	

		">
<link rel="stylesheet" href="../js/resources/js-test-style.css">
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
map HTTP-EQUIV content-language to -webkit-locale. This particular test tests
that the the pragma-set default language is set to the first sequence of
non-whitespace characters of the content-language content. This expectation may
change, see bug. This expectation is as per the HTML 5 spec. It appears that
Firefox does not exactly do this, but trims the leading and trailing
whitespace.  It's unclear what IE does.
</p>
<div id="console"></div>
<div id="x"></div>
<div id="y" lang="ar"></div>
<script>
function languageOfNode(id) {
    var element = document.getElementById(id);
    return window.getComputedStyle(element).webkitLocale;
}
shouldBeEqualToString("languageOfNode('x')", "ja_JP");
shouldBeEqualToString("languageOfNode('y')", "ar");
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
</html>

Return to Bug 77724

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +27 lines
		1	2012-02-08 Matt Falkenhagen <falken@chromium.org>
		2
		3	Improve http-equiv content-language parsing
		4	https://bugs.webkit.org/show_bug.cgi?id=77724
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Add more tests for mapping http-equiv content-language to -webkit-locale. The desired behavior of some
		9	of these is not yet decided, so some of the tests currently fail and the expectations may change. See comments in bug and in the tests.
		10
		11	* fast/text/content-language-case-insensitivity-expected.txt:
		12	* fast/text/content-language-case-insensitivity.html: Style fixes.
		13	* fast/text/content-language-empty-expected.txt: Added.
		14	* fast/text/content-language-empty.html: Added.
		15	* fast/text/content-language-late-expected.txt: Added.
		16	* fast/text/content-language-late.html: Added.
		17	* fast/text/content-language-mapped-to-webkit-locale-expected.txt:
		18	* fast/text/content-language-mapped-to-webkit-locale.html: Style fixes.
		19	* fast/text/content-language-multiple-expected.txt: Added.
		20	* fast/text/content-language-multiple.html: Added.
		21	* fast/text/content-language-no-content-expected.txt: Added.
		22	* fast/text/content-language-no-content.html: Added.
		23	* fast/text/content-language-only-whitespace-expected.txt: Added.
		24	* fast/text/content-language-only-whitespace.html: Added.
		25	* fast/text/content-language-with-whitespace-expected.txt: Added.
		26	* fast/text/content-language-with-whitespace.html: Added.
		27
1	2012-02-07 Erik Arvidsson <arv@chromium.org>	28	2012-02-07 Erik Arvidsson <arv@chromium.org>
2		29
3	[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference	30	[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference

Lines 12-26 matching of the http-equiv attribute to the content-language state is case a/LayoutTests/fast/text/content-language-case-insensitivity.html_sec1
- a/LayoutTests/fast/text/content-language-case-insensitivity.html -4 / +2 lines
12	insensitive.	12	insensitive.
13	</p>	13	</p>
14	<div id="console"></div>	14	<div id="console"></div>
15	<div id="x1"/>	15	<div id="x"></div>
16	<script>	16	<script>
17	function languageOfNode(id) {	17	function languageOfNode(id) {
18	var element = document.getElementById(id);	18	var element = document.getElementById(id);
19	return window.getComputedStyle(element).webkitLocale;	19	return window.getComputedStyle(element).webkitLocale;
20	}	20	}
21	shouldBeEqualToString("languageOfNode('x1')", "ja-JP");	21	shouldBeEqualToString("languageOfNode('x')", "ja-JP");
22
23	var successfullyParsed = true;
24	</script>	22	</script>
25	<script src="../js/resources/js-test-post.js"></script>	23	<script src="../js/resources/js-test-post.js"></script>
26	</body>	24	</body>

Line 0 a/LayoutTests/fast/text/content-language-empty-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-empty-expected.txt +8 lines
	1	Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language of empty string is ignored. This expectation may change, see bug. HTML5 decrees that the meta element be ignored in case of the empty string. It's unclear what other browsers do.
	2
	3	FAIL languageOfNode('x') should be auto. Was ''.
	4	PASS languageOfNode('y') is "ar"
	5	PASS successfullyParsed is true
	6
	7	TEST COMPLETE
	8

Line 0 a/LayoutTests/fast/text/content-language-empty.html_sec1
- a/LayoutTests/fast/text/content-language-empty.html +28 lines
	1	<!DOCTYPE html>
	2	<html xmlns="http://www.w3.org/1999/xhtml">
	3	<head>
	4	<meta http-equiv="content-language" content="">
	5	<link rel="stylesheet" href="../js/resources/js-test-style.css">
	6	<script src="../js/resources/js-test-pre.js"></script>
	7	</head>
	8	<body>
	9	<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=76701">bug 76701</a>:
	10	map HTTP-EQUIV content-language to -webkit-locale. This particular test tests
	11	that a content-language of empty string is ignored. This expectation may
	12	change, see bug. HTML5 decrees that the meta element be ignored in case of the
	13	empty string. It's unclear what other browsers do.
	14	</p>
	15	<div id="console"></div>
	16	<div id="x"></div>
	17	<div id="y" lang="ar"></div>
	18	<script>
	19	function languageOfNode(id) {
	20	var element = document.getElementById(id);
	21	return window.getComputedStyle(element).webkitLocale;
	22	}
	23	shouldBeEqualToString("languageOfNode('x')", "auto");
	24	shouldBeEqualToString("languageOfNode('y')", "ar");
	25	</script>
	26	<script src="../js/resources/js-test-post.js"></script>
	27	</body>
	28	</html>

Line 0 a/LayoutTests/fast/text/content-language-late-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-late-expected.txt +8 lines
	1	Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language is used even if it appears at the end of the document. This expectation may change, see bug. According to the HTML 5 spec, a meta element should be processed when it is inserted into the document, regardless of where. IE and Firefox also seem to process the content-language at the end of the document.
	2
	3	FAIL languageOfNode('x') should be ja-JP. Was auto.
	4	PASS languageOfNode('y') is "ar"
	5	PASS successfullyParsed is true
	6
	7	TEST COMPLETE
	8

Line 0 a/LayoutTests/fast/text/content-language-multiple-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-multiple-expected.txt +8 lines
	1	Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that in the event of multiple content-languages, the final content-language is used as the pragma-set default language. This expectation may change, see bug. The HTML5 spec decrees that the first successfully processed one be used. Firefox and IE seem to use the final one.
	2
	3	PASS languageOfNode('x') is "zh_CN"
	4	PASS languageOfNode('y') is "ar"
	5	PASS successfullyParsed is true
	6
	7	TEST COMPLETE
	8

Line 0 a/LayoutTests/fast/text/content-language-no-content-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-no-content-expected.txt +8 lines
	1	Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that a content-language with missing content is effectively ignored. This expectation may change, see comments in bug.
	2
	3	PASS languageOfNode('x') is "auto"
	4	PASS languageOfNode('y') is "ar"
	5	PASS successfullyParsed is true
	6
	7	TEST COMPLETE
	8

Line 0 a/LayoutTests/fast/text/content-language-with-whitespace-expected.txt_sec1
- a/LayoutTests/fast/text/content-language-with-whitespace-expected.txt +8 lines
	1	Test for bug 76701: map HTTP-EQUIV content-language to -webkit-locale. This particular test tests that the the pragma-set default language is set to the first sequence of non-whitespace characters of the content-language content. This expectation may change, see bug. This expectation is as per the HTML 5 spec. It appears that Firefox does not exactly do this, but trims the leading and trailing whitespace. It's unclear what IE does.
	2
	3	FAIL languageOfNode('x') should be ja_JP. Was ' \a\9\9ja-JP \9 zh_CN \9\a\a\9\9'.
	4	PASS languageOfNode('y') is "ar"
	5	PASS successfullyParsed is true
	6
	7	TEST COMPLETE
	8