Attachment #116465 for bug #73065

View Details Raw Unified Return to Bug 73065



2011-11-23  Adam Barth  <abarth@webkit.org>

        [Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=73065

        Reviewed by NOBODY (OOPS!).

        This API no longer has any callers.

        * public/WebSecurityOrigin.h:
        * src/WebSecurityOrigin.cpp:
        (WebKit::WebSecurityOrigin::isUnique):

2011-11-23  Ami Fischman  <fischman@chromium.org>

        Teach VideoLayerChromium how to render native texture (to support HW video decode).



    WEBKIT_EXPORT unsigned short port() const;

    // A unique WebSecurityOrigin is the least privileged WebSecurityOrigin.
    WEBKIT_EXPORT bool isUnique() const;

    // FIXME: Remove this function once there are no more callers.
    WEBKIT_EXPORT bool isEmpty() const;

    // Returns true if this WebSecurityOrigin can script objects in the given
    // SecurityOrigin. For example, call this function before allowing



    return m_private->port();
}

bool WebSecurityOrigin::isUnique() const
bool WebSecurityOrigin::isEmpty() const
{
    ASSERT(m_private);
    return m_private->isUnique();

Return to Bug 73065

Lines 70-79 public: Source/WebKit/chromium/public/WebSecurityOrigin.h_sec1
- Source/WebKit/chromium/public/WebSecurityOrigin.h -4 / +1 lines
70	WEBKIT_EXPORT unsigned short port() const;	70	WEBKIT_EXPORT unsigned short port() const;
71		71
72	// A unique WebSecurityOrigin is the least privileged WebSecurityOrigin.	72	// A unique WebSecurityOrigin is the least privileged WebSecurityOrigin.
73	bool isUnique() const { return isEmpty(); }	73	WEBKIT_EXPORT bool isUnique() const;
74
75	// FIXME: Remove this function once there are no more callers.
76	WEBKIT_EXPORT bool isEmpty() const;
77		74
78	// Returns true if this WebSecurityOrigin can script objects in the given	75	// Returns true if this WebSecurityOrigin can script objects in the given
79	// SecurityOrigin. For example, call this function before allowing	76	// SecurityOrigin. For example, call this function before allowing

Lines 90-97 unsigned short WebSecurityOrigin::port() Source/WebKit/chromium/src/WebSecurityOrigin.cpp_sec1
- Source/WebKit/chromium/src/WebSecurityOrigin.cpp -2 / +1 lines
90	return m_private->port();	90	return m_private->port();
91	}	91	}
92		92
93	// FIXME: Rename this API to isUnique.	93	bool WebSecurityOrigin::isUnique() const
94	bool WebSecurityOrigin::isEmpty() const
95	{	94	{
96	ASSERT(m_private);	95	ASSERT(m_private);
97	return m_private->isUnique();	96	return m_private->isUnique();

Lines 1-3 Source/WebKit/chromium/ChangeLog_sec1
- Source/WebKit/chromium/ChangeLog +13 lines
		1	2011-11-23 Adam Barth <abarth@webkit.org>
		2
		3	[Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
		4	https://bugs.webkit.org/show_bug.cgi?id=73065
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	This API no longer has any callers.
		9
		10	* public/WebSecurityOrigin.h:
		11	* src/WebSecurityOrigin.cpp:
		12	(WebKit::WebSecurityOrigin::isUnique):
		13
1	2011-11-23 Ami Fischman <fischman@chromium.org>	14	2011-11-23 Ami Fischman <fischman@chromium.org>
2		15
3	Teach VideoLayerChromium how to render native texture (to support HW video decode).	16	Teach VideoLayerChromium how to render native texture (to support HW video decode).