View Details Raw Unified Return to Bug 67801
Collapse All Expand All
- Source/WebKit2/ChangeLog +13 lines
Lines 1-3 Source/WebKit2/ChangeLog_sec1
1 
2011-09-08  Anders Carlsson  <andersca@apple.com>
2 

            

            

              3
              
        Don't release the modal placeholder window if it's closed

            

            

              4
              
        https://bugs.webkit.org/show_bug.cgi?id=67801

            

            

              5
              
        <rdar://problem/10088059>

            

            

              6
              

            

            

              7
              
        Reviewed by NOBODY (OOPS!).

            

            

              8
              

            

            

              9
              
        This is a speculative fix - nothing should really be able to close the modal placeholder window.

            

            

              10
              

            

            

              11
              
        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

            

            

              12
              
        (WebKit::PluginProcessProxy::beginModal):

            

            

              13
              

            

        

          1
          
2011-09-07  Alexei Svitkine  <asvitkine@chromium.org>

          14
          
2011-09-07  Alexei Svitkine  <asvitkine@chromium.org>

        

        

          2
          

          15
          

        

        

          3
          
        Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.

          16
          
        Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.

        



-
  Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm
    
      +1 lines
    




  

    
      
            Lines 210-215
      
      void PluginProcessProxy::beginModal()
      
        Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm_sec1
      
    
  

        

          210
          
    ASSERT(!m_activationObserver);

          210
          
    ASSERT(!m_activationObserver);

        

        

          211
          
    

          211
          
    

        

        

          212
          
    m_placeholderWindow.adoptNS([[WKPlaceholderModalWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1) styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES]);

          212
          
    m_placeholderWindow.adoptNS([[WKPlaceholderModalWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1) styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES]);

        

            

              
              
              213
              
    [m_placeholderWindow.get() setReleasedWhenClosed:NO];

            

        

          213
          
    

          214
          
    

        

        

          214
          
    m_activationObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationWillBecomeActiveNotification object:NSApp queue:nil

          215
          
    m_activationObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationWillBecomeActiveNotification object:NSApp queue:nil

        

        

          215
          
                                                                         usingBlock:^(NSNotification *){ applicationDidBecomeActive(); }];

          216
          
                                                                         usingBlock:^(NSNotification *){ applicationDidBecomeActive(); }];

        






  

  Return to Bug 67801