Attachment #105092 for bug #66806

View Details Raw Unified Return to Bug 66806

| Differences between



2011-08-24  James Robinson  <jamesr@chromium.org>

        [chromium] Stacktrace not in test output when a test crashes
        https://bugs.webkit.org/show_bug.cgi?id=66806

        Reviewed by NOBODY (OOPS!).

        Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
        trace.

        * Scripts/webkitpy/layout_tests/port/chromium.py:

2011-08-24  Adam Barth  <abarth@webkit.org>

        Remove empty directory.

Lines 576-583 class ChromiumDriver(Driver): a/Tools/Scripts/webkitpy/layout_tests/port/chromium.py_sec1
- a/Tools/Scripts/webkitpy/layout_tests/port/chromium.py -1 / +8 lines
576	if not text:	576	if not text:
577	text = None	577	text = None
578		578
		579	error = ''.join(error)
		580	# Currently the stacktrace is in the text output, not error, so append the two together so
		581	# that we can see stack in the output. See http://webkit.org/b/66806
		582	# FIXME: We really should properly handle the stderr output separately.
		583	if crash:
		584	error = error + str(text)
		585
579	return DriverOutput(text, output_image, actual_checksum, audio=audio_bytes,	586	return DriverOutput(text, output_image, actual_checksum, audio=audio_bytes,
580	crash=crash, test_time=run_time, timeout=timeout, error=''.join(error))	587	crash=crash, test_time=run_time, timeout=timeout, error=error)
581		588
582	def stop(self):	589	def stop(self):
583	if not self._proc:	590	if not self._proc:

Return to Bug 66806

Lines 1-3 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +12 lines
		1	2011-08-24 James Robinson <jamesr@chromium.org>
		2
		3	[chromium] Stacktrace not in test output when a test crashes
		4	https://bugs.webkit.org/show_bug.cgi?id=66806
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
		9	trace.
		10
		11	* Scripts/webkitpy/layout_tests/port/chromium.py:
		12
1	2011-08-24 Adam Barth <abarth@webkit.org>	13	2011-08-24 Adam Barth <abarth@webkit.org>
2		14
3	Remove empty directory.	15	Remove empty directory.