Bug 6294 - DOMString should assert when passed non-ascii characters
Summary: DOMString should assert when passed non-ascii characters
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 6228
Blocks:
  Show dependency tree / graph
 
Reported: 2005-12-29 19:27 PST by Eric Seidel (no email)
Modified: 2006-11-06 03:37 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-12-29 19:27:36 PST 
Darin's comments on 6228:

In parseUASheet, we can make the DOMString from the char* without decoding
because we know it has all ASCII characters in it. Unlike QString, that
function does not work for non-ASCII Latin-1 characters. So I think it's worth
a comment and adding an assertion to DOMStringImpl::DOMStringImpl(const char *)
to check for non-ASCII characters.
Comment 1 Alexey Proskuryakov 2006-06-24 15:55:45 PDT 
FWIW, I don't see the problem in StringImpl::init() - was it fixed, or am I overlooking it?
Comment 2 Alexey Proskuryakov 2006-11-06 03:37:32 PST 
I still don't see the problem, closing as invalid.