Bug 4856 - Plain text fields should not have "Make Link" in their contextual menu
Summary: Plain text fields should not have "Make Link" in their contextual menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Normal
Assignee: Nobody
URL: http://www.ibm.com/
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-05 11:26 PDT by mitz
Modified: 2007-03-06 11:46 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-09-05 11:26:41 PDT
A "Make Link" item shows up in the contextual menu of a plain text field if the selected text is a URL. The 
item does not belong there, since you cannot do make a link in a plain text field.

To reproduce: open attachment 2978 [details] in Safari, select all text in the text field and control-click the 
selected text.

Expected: no "Make Link" item in the contextual menu.

Actual: "Make Link" item shows up in the contextual menu.
Comment 1 Eric Seidel (no email) 2005-12-28 01:20:54 PST
Hum... too bad there is no way to make a layout test for this.  I wonder if this is a form control issue or an 
editing issue.  Probably form controls, in which case this would be in render_forms.cpp I think.
Comment 2 mitz 2005-12-28 06:21:00 PST
Woops, the testcase to open is attachment 2987 [details].

I think this is basically an AppKit issue: open Interface Builder and create a window with a text field. Enter 
test mode, type an HTTP URI into the text field, select all and control-click.
Comment 3 mitz 2007-02-06 09:00:35 PST
In TOT (with Safari 2.0.4) there is no longer a Make Link item but there are two consecutive separators between Go To Address and Copy.