Bug 20613 - Can't add a keyframe rule via the DOM
Summary: Can't add a keyframe rule via the DOM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks: 20594
  Show dependency tree / graph
 
Reported: 2008-09-02 17:28 PDT by Dean Jackson
Modified: 2008-09-08 18:04 PDT (History)
1 user (show)

See Also:

Attachments
patch for keyframes via dom (4.66 KB, patch)
2008-09-05 19:40 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
updated patch (4.72 KB, patch)
2008-09-08 15:10 PDT, Dean Jackson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2008-09-02 17:28:53 PDT 
I forgot to add the back-door keyframe parsing to the CSS grammar, which means programmatically added keyframe rules don't work.

See LayoutTests/css3/keyframes-rule.html
Comment 1 Dean Jackson 2008-09-05 19:40:43 PDT 
Created attachment 23209 [details]
patch for keyframes via dom

Updated test too. Note that keyframes rules are sorted.
Comment 2 Dean Jackson 2008-09-05 19:41:18 PDT 
This will fix the failing LayoutTest
Comment 3 Dean Jackson 2008-09-08 15:10:11 PDT 
Created attachment 23275 [details]
updated patch

i'd left a line out
Comment 4 mitz 2008-09-08 17:29:33 PDT 
Comment on attachment 23275 [details]
updated patch

r=me
Comment 5 Dean Jackson 2008-09-08 18:04:17 PDT 
Committed r36278
	M	WebCore/ChangeLog
	M	WebCore/css/CSSGrammar.y
	M	WebCore/css/tokenizer.flex
	M	LayoutTests/ChangeLog
	M	LayoutTests/css3/keyframes-rule-expected.txt
	M	LayoutTests/css3/keyframes-rule.html