Bug 19438 - Transaction errors are never displayed in database query view
Summary: Transaction errors are never displayed in database query view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-08 12:59 PDT by Adam Roben (:aroben)
Modified: 2008-06-08 13:58 PDT (History)
0 users

See Also:


Attachments
patch + changelog (4.00 KB, patch)
2008-06-08 13:23 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff
patch v2 + changelog (5.42 KB, patch)
2008-06-08 13:42 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-06-08 12:59:24 PDT
Transaction errors are never displayed in database query view.

To repro:
1. Go to http://webkit.org/misc/DatabaseExample.html
2. Go to the Databases panel and click on the NoteTest database
3. Enter the following text on the query input line:
INSERT INTO WebKitStickyNotes (note) VALUES (NULL)

Results:
The line of text you entered disappears, and no error is shown.
Comment 1 Adam Roben (:aroben) 2008-06-08 13:23:40 PDT
Created attachment 21579 [details]
patch + changelog
Comment 2 Darin Adler 2008-06-08 13:26:20 PDT
Comment on attachment 21579 [details]
patch + changelog

r=me; seems fine as is

But this seems a little strange to me. Why wouldn't we instead use two different error functions for the two different cases, and then share a common worker function?
Comment 3 Adam Roben (:aroben) 2008-06-08 13:29:13 PDT
(In reply to comment #2)
> (From update of attachment 21579 [details] [edit])
> r=me; seems fine as is
> 
> But this seems a little strange to me. Why wouldn't we instead use two
> different error functions for the two different cases, and then share a common
> worker function?

Yeah, that's probably a better way to go. I guess this patch is a little too quick-n-dirty.
Comment 4 Adam Roben (:aroben) 2008-06-08 13:42:03 PDT
Created attachment 21580 [details]
patch v2 + changelog

Updated to address Darin's comments.
Comment 5 Darin Adler 2008-06-08 13:49:32 PDT
Comment on attachment 21580 [details]
patch v2 + changelog

r=me
Comment 6 Adam Roben (:aroben) 2008-06-08 13:58:24 PDT
Committed in r34455