Inspector should support console.count

[Adam Roben (:aroben)]

The Inspector should support console.count for Firebug parity.

[Mark Rowe (bdash)]

<rdar://problem/5950865>

[Adam Roben (:aroben)]

One thing that will make implementing this tricky is that currently there's no way for the console methods to know what file/line they were called from. See https://bugs.webkit.org/show_bug.cgi?id=17234#c2 and https://bugs.webkit.org/show_bug.cgi?id=17234#c3

[Keishi Hattori]

Created attachment 21837 [details]
Testcase for console.count behavior in Firebug

I think this testcase proves that console.count only cares about the title attribute and not the line it was called.

[Adam Roben (:aroben)]

Comment on attachment 21837 [details]
Testcase for console.count behavior in Firebug

Results from Firefox 2 with Firebug 1.1b:

100
100
a 100
a 100

So it looks like Firebug is in fact doing what it claims to do.

[Keishi Hattori]

Oops. I guess it's a bug in Firebug 1.2 then.

http://gyazo.com/eae0e3bcf7fd423181f7aabf0d459e73.png

[Keishi Hattori]

Created attachment 22836 [details]
proposed patch

Line number insensitive, but can be upgraded once the line numbers are available.

[Keishi Hattori]

Created attachment 22837 [details]
fixed a minor mistake

I couldn't figure out how to update a value in m_counts without removing and adding it back.

[Geoffrey Garen]

Comment on attachment 22837 [details]
fixed a minor mistake

r=me

[Timothy Hatcher]

Landed in r35842.