Bug 18868 - SQUIRRELFISH: window.this shows up as a property, but it shouldn't
Summary: SQUIRRELFISH: window.this shows up as a property, but it shouldn't
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks: 18631
  Show dependency treegraph
 
Reported: 2008-05-03 01:35 PDT by Maciej Stachowiak
Modified: 2008-05-06 20:58 PDT (History)
0 users

See Also:


Attachments
don't keep "this" in the symbol table at runtime (3.31 KB, patch)
2008-05-06 20:14 PDT, Maciej Stachowiak
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2008-05-03 01:35:49 PDT
"this" appears as a property of the window object to enumeration and lookup as "window.this", but it should not. This is likely a side effect of us treating it as a special local/global var.
Comment 1 Geoffrey Garen 2008-05-05 20:52:33 PDT
I think we should remove "this" from the symbol table after codegen.
Comment 2 Maciej Stachowiak 2008-05-06 20:14:37 PDT
Created attachment 20995 [details]
don't keep "this" in the symbol table at runtime
Comment 3 Oliver Hunt 2008-05-06 20:23:05 PDT
Comment on attachment 20995 [details]
don't keep "this" in the symbol table at runtime

r=me, with the aswsertion changes we discussed