Bug 18664 - SQUIRRELFISH: correctly throw a SyntaxError when parsing of eval code fails
Summary: SQUIRRELFISH: correctly throw a SyntaxError when parsing of eval code fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 18624
  Show dependency tree / graph
 
Reported: 2008-04-21 11:52 PDT by Cameron Zwarich (cpst)
Modified: 2008-04-21 12:00 PDT (History)
0 users

See Also:

Attachments
Proposed patch (1.03 KB, patch)
2008-04-21 11:56 PDT, Cameron Zwarich (cpst) 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-04-21 11:52:26 PDT 
SquirrelFish does not currently throw a SyntaxError when parsing of eval code fails. This causes the failure of some JavaScriptCore tests that expect a SyntaxError.
Comment 1 Cameron Zwarich (cpst) 2008-04-21 11:56:58 PDT 
Created attachment 20733 [details]
Proposed patch

Oliver already reviewed it, but I can't land it myself. This patch fixes 8 JavaScriptCore test failures. There is no change on SunSpider.
Comment 2 Oliver Hunt 2008-04-21 12:00:38 PDT 
Committed r32332