Bug 18418 - REGRESSION (r31736?): DOM tree disappears when navigating to a new page with the Inspector open
Summary: REGRESSION (r31736?): DOM tree disappears when navigating to a new page with ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-10 17:08 PDT by Adam Roben (:aroben)
Modified: 2008-04-11 13:00 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.50 KB, patch)
2008-04-11 12:10 PDT, Timothy Hatcher 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-04-10 17:08:12 PDT 
The Inspector's DOM tree disappears when you navigate to a new page with the Inspector open.

1. Go to http://webkit.org/
2. Right-click and choose Inspect Element
3. Go to http://www.google.com/
Comment 1 Timothy Hatcher 2008-04-11 12:10:13 PDT 
Created attachment 20484 [details]
Patch
Comment 2 Adam Roben (:aroben) 2008-04-11 12:13:24 PDT 
Comment on attachment 20484 [details]
Patch

@@ -141,8 +169,7 @@ WebInspector.ElementsPanel.prototype = {
             this.focusedDOMNode = canidateFocusNode;
             if (this.treeOutline.selectedTreeElement)
                 this.treeOutline.selectedTreeElement.expand();
-        } else
-            this.focusedDOMNode = null;
+        }
     },

What's this change for? You don't mention it in the ChangeLog.

Maybe we should file a bug about the event listener being called with the inspected page's global object?

r=me
Comment 3 Timothy Hatcher 2008-04-11 13:00:23 PDT 
I moved this.focusedDOMNode = null to the top of the reset function.
Comment 4 Timothy Hatcher 2008-04-11 13:00:34 PDT 
Landed in r31815.