Bug 17707 - Conditionalize use of SAFARI_THEME in WebKitClassFactory
Summary: Conditionalize use of SAFARI_THEME in WebKitClassFactory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-07 11:49 PST by Brent Fulgham
Modified: 2008-03-07 13:16 PST (History)
0 users

See Also:


Attachments
Patch to avoid linking to SafariTheme.dll if not using safari theme (1.62 KB, patch)
2008-03-07 11:55 PST, Brent Fulgham
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-03-07 11:49:44 PST
The windows-only WebKitClassFactory.cpp class links to the SAFARI_THEME library.  This is a problem if you want to build a Cario-backed version of WebKit since it requires CoreGraphics to work.

Someday, the themes will be standardized under a more modular infrastructure, but until then a reasonable work-around is to not link to SAFARI_THEME when the "USE(SAFARI_THEME)" test fails.
Comment 1 Brent Fulgham 2008-03-07 11:55:37 PST
Created attachment 19592 [details]
Patch to avoid linking to SafariTheme.dll if not using safari theme
Comment 2 Adam Roben (:aroben) 2008-03-07 11:57:52 PST
Comment on attachment 19592 [details]
Patch to avoid linking to SafariTheme.dll if not using safari theme

r=me
Comment 3 Mark Rowe (bdash) 2008-03-07 13:16:27 PST
Landed in r30877.