RESOLVED FIXED 17492
build-wxwebkit build script fixes 
https://bugs.webkit.org/show_bug.cgi?id=17492
Summary build-wxwebkit build script fixes
Robin Dunn
Reported 2008-02-22 14:42:00 PST
Attached patch fixes and streamlines a few minor issues in build-wxwebscript.
Attachments
patch for build-wxwebkit (5.05 KB, patch)
2008-02-22 14:42 PST, Robin Dunn 		ddkilzer: review-
DetailsFormatted DiffDiff
tab-less version of the same patch (5.35 KB, patch)
2008-02-23 11:04 PST, Robin Dunn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Dunn
Comment 1 2008-02-22 14:42:58 PST
Created attachment 19282 [details] patch for build-wxwebkit
David Kilzer (:ddkilzer)
Comment 2 2008-02-22 15:18:43 PST
Comment on attachment 19282 [details] patch for build-wxwebkit Thanks for the patch, Robin! In the future, please set the "review?" flag to make sure it gets reviewed.
Darin Adler
Comment 3 2008-02-23 09:27:01 PST
Comment on attachment 19282 [details] patch for build-wxwebkit rs=me
David Kilzer (:ddkilzer)
Comment 4 2008-02-23 09:42:49 PST
(In reply to comment #3) > (From update of attachment 19282 [details] [edit]) > rs=me I think Kevin should land this patch, or review it before it's landed.
David Kilzer (:ddkilzer)
Comment 5 2008-02-23 09:45:30 PST
Comment on attachment 19282 [details] patch for build-wxwebkit Marking as r- since there are tabs in the patch. They will need to be removed before landing if the patch is otherwise correct.
David Kilzer (:ddkilzer)
Comment 6 2008-02-23 09:46:22 PST
See Item 1 on the code style guidelines page: http://webkit.org/coding/coding-style.html
Robin Dunn
Comment 7 2008-02-23 11:04:23 PST
Created attachment 19301 [details] tab-less version of the same patch I usually do avoid using tabs, but emacs shell-script mode uses them by default. Tab-less version attached.
Kevin Ollivier
Comment 8 2008-02-26 17:57:27 PST
Landed in r30614, thanks!
Maciej Stachowiak
Comment 9 2008-04-22 22:30:43 PDT
Comment on attachment 19301 [details] tab-less version of the same patch Since this is in, removin flag to get out of the review queue.
Note You need to log in before you can comment on or make changes to this bug.